From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Listopadov Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Sat, 25 Nov 2023 11:33:38 +0300 Message-ID: <87a5r2p4pq.fsf@gmail.com> References: <87y1ewgnn7.fsf@gmail.com> <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8509"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.11; emacs 30.0.50 Cc: Wilhelm Kirschbaum , 67246@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 10:23:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6osh-0001yh-9a for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 10:23:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6osN-00054L-Il; Sat, 25 Nov 2023 04:22:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6osL-000548-TA for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 04:22:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6osL-0006Vb-Kc for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 04:22:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6osQ-0000ul-H9 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 04:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Listopadov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.17009041793506 (code B ref 67246); Sat, 25 Nov 2023 09:23:02 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 25 Nov 2023 09:22:59 +0000 Original-Received: from localhost ([127.0.0.1]:37798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6osM-0000uU-IT for submit@debbugs.gnu.org; Sat, 25 Nov 2023 04:22:58 -0500 Original-Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:60810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6osJ-0000uF-2R for 67246@debbugs.gnu.org; Sat, 25 Nov 2023 04:22:57 -0500 Original-Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a0b65cbf096so41288966b.1 for <67246@debbugs.gnu.org>; Sat, 25 Nov 2023 01:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700904164; x=1701508964; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=VTP4YXOpD6QhX8mn2so/e28QLHiH1Y+WV83WRyjupfE=; b=Ds14QYyFhv/uyCsjdtq6oAP5uch2SD7VnNiKWMMnGF1dRVlu8I0dQrhyWRVihrMyuB Mwsspi5UMExvXfqBJELZcnwJntmWJgur3eQwtTdzzCDpzL886KtPqXTf7NcUlXVVQ1nY Vz6eYJ8XEjHvljqMSiQvWdo498kL7vFwiORt768q8XtONnX+t+AOR22+Dtk4iQqoI1ef 34YiB3soYJ6nl0IA1VC8FRoHZTIto06Cv1z/aEDobh+JVs90L6NE65DaTKkU9Gr10NB/ fHlyOdxgitOQeHV/iOpudYrlsILBUqazQ9wfaSk0QwOSXbyJ3hWsr4jJQ9kZdq4NUryL poFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700904164; x=1701508964; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VTP4YXOpD6QhX8mn2so/e28QLHiH1Y+WV83WRyjupfE=; b=Rycoc5x0ytX+Da7Jh1JIPCYF+uBqrjYtuDQi/el+SC7v7VcBYX7oakUGTYuyAkH7Is tPxbqkobB6X/MxglTFBau53x9EDcSS77aXrNl4/yC+Q3sSGI5yn0QPJF8U5C7PyxzZtk Wvj+sGalrjqIJWMZTBm6tX59DIrdw7w5qFA9O1QaXC//XA2VKrR/TcEIZlCus+Cj6aR2 ojJ8/iPSZYgv1GSbdziM+/c4NAMW18LD+1GfiEWTHOhZ35DjnJ3Ob3Nvu433xzPhBFRD 2sTZX48X38Cby2xkBDZOhOeN0vIUZRZkM6hwgmHKL5DRsLPV6AN7WuoJMOChK0VWIsjU odmw== X-Gm-Message-State: AOJu0YzhdRDlVnCmjekgx+qYXDQ5fLZnUQnh3nLKdARJ9rnfiO7d2KZj oAeGf0nqdGwhxSdL+GoMdV4SQgfPmuI= X-Google-Smtp-Source: AGHT+IE1gzPlJMZGizS5MR9bbxyLp2XDPR98OAz/vUDLjY146Md9RCfpLmVn0TJt+UZJ38Zj38F5/Q== X-Received: by 2002:a17:906:e99:b0:a04:b801:66f7 with SMTP id p25-20020a1709060e9900b00a04b80166f7mr4548892ejf.23.1700904163881; Sat, 25 Nov 2023 01:22:43 -0800 (PST) Original-Received: from toolbox.smtp.gmail.com (broadband-46-242-11-135.ip.moscow.rt.ru. [46.242.11.135]) by smtp.gmail.com with ESMTPSA id t24-20020a17090616d800b009ffb4af0505sm3194818ejd.104.2023.11.25.01.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 01:22:43 -0800 (PST) In-reply-to: <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274931 Archived-At: Dmitry Gutov writes: > The idea was to balance the new look between the "old" major modes and > the newer, shinier ones. So that the overall style still somewhat > appeals to the existing audience, just with added features and more > precision. Here's a Reddit recent thread about the same sentiment: > https://www.reddit.com/r/emacs/comments/18152qo/overcolorization_everything_is_purple/ > It discusses a post written by Andrey, BTW. Yes, I published this post after submitting the bug in order to raise awareness among the community. > One could basically say that a function call and a properly lookup are > easy to distinguish from glancing at the text, there's not much need > to highlight them. As opposed to e.g. implicit variable declaration or > function declaration. Yeah, as I said in my post, highlighting important parts of the code, like macro calls, or dynamic/global variables tells you that you're looking at something more intricate, that is otherwise syntactically indistinguishable from regular code. > And here's another aspect: the default built-in theme doesn't > distinguish many of the faces (and the same is true for many other > built-in themes). E.g. it doesn't distinguish variable-name-face from > variable-use-face or function-name-face from function-call-face. I'm wondering if font-lock.el needs a bit more generic faces, as packages often define their own faces, that aren't supported by themes in any way. Again, the example with elixir-mode isn't to bash the developers, but before 2019 elixir-mode (not elixir-ts-mode) defined a few faces with explicit colors. Here's a commit that fixed that https://github.com/elixir-editors/emacs-elixir/commit/f101c676cc9485aa22ec088a71d8afc72cda3d58 but before it, `elixir-atom-face' and `elixir-attribute-face' were `RoyalBlue4' and `MediumPurple4' no matter what theme you were using. IIRC the CIDER package also defines some faces like that, so it's somewhat common. I can't come up with missing faces, and most modes I use define extra faces in terms of inheritance to the inbuilt faces, but maybe font-lock-symbol-face is worth including, as some languages may want to distinguish these like elixir does right now with `elixir-ts-atom-face'.