From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71213: [PATCH] Use the current face foreground for read-passwd icons Date: Tue, 28 May 2024 09:34:50 +0200 Message-ID: <87a5kas82t.fsf@gmx.de> References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> <87jzjff7m1.fsf@gmail.com> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17197"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71213@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 09:36:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBrNS-0004In-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 09:36:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBrND-0006r2-3M; Tue, 28 May 2024 03:35:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBrNB-0006qW-Ed for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 03:35:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBrNB-0002It-0D for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 03:35:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBrNJ-0003DO-SY for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 03:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71213-submit@debbugs.gnu.org id=B71213.171688170912293 (code B ref 71213); Tue, 28 May 2024 07:36:01 +0000 Original-Received: (at 71213) by debbugs.gnu.org; 28 May 2024 07:35:09 +0000 Original-Received: from localhost ([127.0.0.1]:45599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBrMS-0003CD-MI for submit@debbugs.gnu.org; Tue, 28 May 2024 03:35:09 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:49603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBrMQ-0003Ba-VV for 71213@debbugs.gnu.org; Tue, 28 May 2024 03:35:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1716881691; x=1717486491; i=michael.albinus@gmx.de; bh=kLKISLq37jXZLoiSaTMtvH+6/ugvDXFYJe4zEqjUpSc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VswoHX5k3x8MO+fuyijRc+HACUmEorINfT/sXUwvEer/hj3NmMDyAfB9zIsdWpV8 jipw4PEwF0qo6swd2vUZzFODZuFuCi3PE5Iu7RHpaC67XzYg2pZhu4OKTN3OFxJgD LFAq4HRvJrxj9/UPjhACew8AjK5bRV6hkTv2n30rJWuQoO3J4NoaKez/USMOw1EWf F9/z0hfPyMPnrl+lg+nzcZhV9ELT58/ZCvKLz2yHvy0FaTBq4XwNaarKeXo7KkqZi uDapFJLaH8CtxkUknv9jJSPJAQOgyE/A55E2cxSTsoWZG/ZqRAfPKeR8qAGkF4hj0 GRnbrqL6QD9wWMAyMA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.151]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqs0X-1sp5zf3zmr-00mr4R; Tue, 28 May 2024 09:34:51 +0200 In-Reply-To: <87jzjff7m1.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Mon, 27 May 2024 20:11:02 +0200") X-Provags-ID: V03:K1:vmH/j1iQiV29Sc4RrCYDGyOrbSOr0JCclz8dToytZTVWhgrpY4l yNW0gVQA/pt51iJeimjlHi5DoxKDTWo6Z6rRDhfEvRTaCKmiZXIOb0Y8PkHpBbF7vyq0S91 7WTajjru+br7H/0nGmSQj1U/2a5FbJfmbfKgbi3MMNKC0sbamQ+L4TqzOFk7Mp5Q4N6huRj GrsIFwcqu3ZTp9zkhfrlA== UI-OutboundReport: notjunk:1;M01:P0:82x+N592iD8=;PnRF3eK09otI1R4DVg3WO6DjmQ1 +YMux82FP+luy4QipID2UGpMvXzO+Eqku2s2Zg2O9SMCd4V00+1AsEacj3FIw9TFbV6Km1Ldk vSpvyWp/JN5kJQngY9ETNm3vB3/XtziqPpFUV+sUT/Vg2lzLhRkgqegUrqUbcvHbwe5eYODpL kFyBcRqQb7xNBRn8R5JeGmPXFeKmhDw2nY8zTh7AxtnuNzKoOzbnFJJXZGjY+FjcC/1RoCiue FRSoTXctwn6hMb46vssX2SAczJciKcMthvAH1angY/xRC6QW+jb5Rlp0Vi3VDxQ1jE05roXog suM6OzgCrJXWGSrEGqxowLC4dkdW3HTtCKEWY9P5QyvAGuVOytolCz1vyHz1sK5nHlSinnyW6 opzNLzqYX/xVBgQDe/2OV6rWks71lFaLbo1qlStGUwGnW0I7kXV34aIhigSWEjLfhot+3hMgX y2FDBbyMiptmirC7xoITcdIhMY8IsmwGqDePZJHyoVE1xa8ORdPvT2r1SRQmF8uiDa59nD3fC z/5o0P5hw0qDk2b8ZgZLoXe9uLPVwvCz+VL9AkulZQhUxqYQzMRsXKiQZBZnuAm4HLD/p9tNI 3P+gmeHJWcB/Gil2R0IxRxxrdyNoRuKZ1OAxNbWvEJtPPJv+odBYjUQSpz8MV7DQel6MdMJzQ Wr8w5N1ifdZaUin9TCqZ8NlCENP8V7ZREHqO2sUHDfbi+YEecxWVWhComJVNCJu2yV0b9rr1K eNRcl+4IebY9vUFH9nptPIfYT7speQc9Sqs+u9oF9mHsTIVsbBZowXML/jFKaWVgDkv0e1p9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286078 Archived-At: K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, >>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>> think it makes sense for these too, since "#2e3436" (and any shade of >>> not-strictly-gray-but-close-enough) is liable to have low contrast with >>> the mode line background depending on the theme (e.g. modus-vivendi). >>> >>> Let me know what you think. >> >> I have absolutely no knowledge about image formats. I've stolen the two >> files from the Gnome repository, that's it. So I won't object any >> change. > > Right, AFAIU we followed the same approach for the icons I mention above > (grabbed the icons somewhere, realized their foreground fared poorly > depending on the background, stripped their 'fill' attribute). So I would say it is OK to install your patch. Other people will comment only if they see an unexpected change, so this is likely the best way to test your proposal :-) >> While we're at it: do the two correspinding *.pbm files also need some >> care? > > It's not a format I am familiar with, but empirically, > > (insert-image (create-image "conceal.pbm")) > > inserts an icon that automagically changes color as I switch between > light and dark themes. pbm(5) says the format is monochrome, and (info > "(elisp) Other Image Types") confirms Emacs does the obvious thing by > default (frame foreground for one bits; frame background for zero bits). > >> And do we need to create also *.xbm files? > > Not sure if we have a policy or guidelines there; etc/images/README > explains how to convert from xpm > xbm > pbm, but does not provide > judgments on which are needed. (info "(elisp) Image Formats") says > > Supported image formats (and the required support libraries) inclu= de > PBM and XBM (which do not depend on support libraries and are always > available), > > which makes me tempted to say "if we have lowest-common-denominator > formats like PBM or XBM for our icons, then we're good, the rest is > bonus"? OK. Best regards, Michael.