From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command Date: Wed, 24 Jul 2024 19:09:48 +0200 Message-ID: <87a5i61ztv.fsf@web.de> References: <87r0bsn0ok.fsf@gmail.com> <86le1xkh8w.fsf@mail.linkov.net> <87r0bpu6tn.fsf@gmail.com> <86ttggr4u5.fsf@mail.linkov.net> <87ed7k4fwd.fsf@web.de> <868qxsyq0o.fsf@mail.linkov.net> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72147@debbugs.gnu.org, Visuwesh To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 24 19:10:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWfVc-0004Ig-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jul 2024 19:10:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWfVM-0001OS-Al; Wed, 24 Jul 2024 13:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWfVB-0000wg-0m for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:10:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWfUy-0007QQ-8j for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:10:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWfV4-0005WT-0s for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2024 17:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72147 X-GNU-PR-Package: emacs Original-Received: via spool by 72147-submit@debbugs.gnu.org id=B72147.172184096021152 (code B ref 72147); Wed, 24 Jul 2024 17:10:01 +0000 Original-Received: (at 72147) by debbugs.gnu.org; 24 Jul 2024 17:09:20 +0000 Original-Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWfUO-0005V5-DB for submit@debbugs.gnu.org; Wed, 24 Jul 2024 13:09:20 -0400 Original-Received: from mout.web.de ([212.227.15.4]:51383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWfUL-0005Up-Dr for 72147@debbugs.gnu.org; Wed, 24 Jul 2024 13:09:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1721840941; x=1722445741; i=michael_heerdegen@web.de; bh=SYyk4Mf8CnV2YvgKCwBAwhzW6hs3pAl4LF/zydBdJYg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=eUe/8NZa1kmuOTX/iOrFxCghTq6nVLLdxzaxaK9doZWvtLMouLe+3xELIIex9+W+ 6fUekMvlWDdH0+sO4fMrIVWF8tmp6wdbOjdTL/aS0y0ueosk2RpxI5R30Db9du3B+ CEQ8g81e+N7n4mXighk79dFc9/OnVfkf3gO8fICXEbpHE2tZfxURGtG7dIdlPheKn vl9x+eC4QinyTqzPbMiiXsbc/hEhg8hJ/6SbFEk5Xll6pPsvCqG0Xm3m1g7vcjTE7 wc3PKcYWeZdKNuPl/FPXEYtTJQAFP2dkWa6RjXb0+nC8h/d6z9bi22AokGkUCOz/r VbHWDgT23k/ZxaaYGQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.113]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MW9ra-1sme3z2YKg-00Lwo8; Wed, 24 Jul 2024 19:09:01 +0200 In-Reply-To: <868qxsyq0o.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 23 Jul 2024 20:40:47 +0300") X-Provags-ID: V03:K1:SwgDN2nFs5oaEJmc39JpH7Mqq5Bh34ky/HyPsFZoFZj0VaBHuwD RaLdaQDhtF61V1+3nYhojuv36iyv7txGFqrTmTBcIAgZv11I1CoaS0lqa2PaksPwENnZbj0 zp+vN9niZB7tMoOI0VRxGgJevPlIxnc0JXX1HnBcLUzZUX++1R4ZmmUjrScCTYCHsLBwdSl Ex2y43VR1ohJezE27Ey7g== UI-OutboundReport: notjunk:1;M01:P0:OX/8O6cZR08=;a46VTHRP9lJLwMAJULs+9UiwGGJ 3EPbGRkePReZUhaN2CUXMlh5mYkkakf5loPLgrs88PN7xWyr+CqJHCzGGa9nHv2rT+3pa5wfG mWmvnmMw+3qM2fmQjv4WtxACnZV3vwlq9UthyQYrJ6y73BRBfrEPEI/g+WYYGDHvNUvBUaS6V tFW+MFGyJE3Hmo365t7cwisv5thwavzXoVSKim7zKiE3jOMlS7T9xW5j5O3Rx5WCYlGg/hRaY 9z9d/fO3h8msGYuT3JfsOx/VXw/Tj3Zb0zg6ZMdglS53mzr/WnS/JMGYhGsOpEbZVL06MOQOD PooNqIXBWrQEIUYjOySLZjsDx+jePLwvAV0bwKp/rrOAVqedoNCGZ26iGYB33DOFgA2rxvb7x jSvlFDvlXSSEUnSwWHEzVUV0cunMk7kAhHWWCysNy/0K/IIiDCOm5Grs238tQImLJELaeukf4 /xLvEyN2PpPE+UjGypXoWDsndlpLrqkfNirq1nCEzfIVmjpMRfZFv+NS1Ee8PSH734Jxlfgoe Y1gw8Pxo6no9MSrNq+F1czX7dNV7gKyjeKZEkCZTLy3VHsLXXNWOOZD1tmnLzz6dkFPaPvXP2 BsPxnq+xZvFUAx6e1963C+Rw1EocEwEoHbtqsaem255Vt3uJLy2tA4KmKvpa5tXvNq1qTz0Zz yNgs2inbr4pX/FVwZzvanfOVi9G0CNPgZ8+c9wh0/VnBB+kroI+6F1GdG/68WA3WhoYpDNYmm Y5vYMVH1o1ww6em8Wej/hmbU58duI7XMWRYxgoC5/f+H6jErrjIdpk/p//6X5w4Ny6EQsk5N X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289243 Archived-At: Juri Linkov writes: > >> Thanks for the patch, now pushed to master. > > > > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to > > `query-replace-read-args', for stylistic reasons? > > It's not clear how such arg should be combined with > `query-replace-lazy-highlight' in `query-replace-read-args': > > (defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight) > ... > (from (minibuffer-with-setup-hook > (minibuffer-lazy-highlight-setup > :highlight query-replace-lazy-highlight > > with `and'? With `or'? With `xor'? > `(and query-replace-lazy-highlight (not no-highlight))'? The installed patch binds query-replace-lazy-highlight to nil and shadows the old binding. This would correspond to (and query-replace-lazy-highlight (not no-highlight)) which looks reasonable in this case: we just an argument to inhibit highlighting. Because we never want highlighting in some cases (like here). Michael.