From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Xiyue Deng Newsgroups: gmane.emacs.bugs Subject: bug#72358: 29.4; oauth2.el improvements Date: Wed, 28 Aug 2024 23:58:05 -0700 Message-ID: <87a5gv6cjm.fsf@debian-hx90.lan> References: <87mslz8yzk.fsf@debian-hx90.lan> <87frrr725m.fsf@gmail.com> <87ed7a8ye6.fsf@debian-hx90.lan> <87jzh2vt3y.fsf@gmail.com> <87frrp6ch8.fsf@debian-hx90.lan> <87ttg349yd.fsf@debian-hx90.lan> <86r0b6up8p.fsf@gnu.org> <87ikw4qdvx.fsf@debian-hx90.lan> <86plqbfzat.fsf@gnu.org> <877ccjecnc.fsf@debian-hx90.lan> <86wmkj8o29.fsf@gnu.org> <87wmk9busk.fsf@debian-hx90.lan> <87seuxacij.fsf@posteo.net> <87seuxbk6f.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11743"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bjorn.bidar@thaodan.de, Eli Zaretskii , fitzsim@fitzsim.org, rpluim@gmail.com, 72358@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 29 09:00:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sjZ92-0002rc-Ek for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Aug 2024 09:00:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjZ8k-0007rc-4N; Thu, 29 Aug 2024 03:00:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjZ8e-0007rG-2E for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:00:13 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sjZ8a-0005lr-Iw for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:00:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=7SwnYZ37Z9+2puHxikFFLAYnVN6/3k1uh0+GjTkpac8=; b=IGYlAivVbqyh3BRoNE/98fhPgpuVvkVUjCWsiE05bl07DK3gvg0QtXE6GhcLnm37m721fxldh2rw4QNDa20NU67A03G2Yaa3bPLG17IB6WhGLc9zfNa26/zmbMcLPHo3byDl0/PVAU0rvWjSO8L5ihnhliU+0lyo9XHHfIzOiAiIUqmC2S5GBd4fvhud9SIdcTzAWa8OaZMbWspakkK9vvaBdYRvc1qoH67OvcGe9SuPMptrpRNBGkbec/SGP4DbTyZDacorJudrk3dcJug8aSbHI0AKFzo6Z8a/zPwp9qAvD6CwA/QC109dB8grGisSXgPPczLWKFo6lAABaanDfw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sjZ9S-0004TG-D6 for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Xiyue Deng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Aug 2024 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72358 X-GNU-PR-Package: emacs Original-Received: via spool by 72358-submit@debbugs.gnu.org id=B72358.172491481217098 (code B ref 72358); Thu, 29 Aug 2024 07:01:02 +0000 Original-Received: (at 72358) by debbugs.gnu.org; 29 Aug 2024 07:00:12 +0000 Original-Received: from localhost ([127.0.0.1]:50208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjZ8e-0004Rf-A5 for submit@debbugs.gnu.org; Thu, 29 Aug 2024 03:00:12 -0400 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:48528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjZ8b-0004QG-JN for 72358@debbugs.gnu.org; Thu, 29 Aug 2024 03:00:10 -0400 Original-Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-70f60d73436so131639a34.1 for <72358@debbugs.gnu.org>; Wed, 28 Aug 2024 23:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724914688; x=1725519488; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7SwnYZ37Z9+2puHxikFFLAYnVN6/3k1uh0+GjTkpac8=; b=HzAaf6GJc13oZRJdvFhRbNmFZsBSplab9ivLc0d5F0qiKvIGhs89+1FFSh4vNedWjZ Be7bcgXfP64EzRmBnU2ooeBtaJ6+eaXSuKp4v7nRQD7871PfblLxSNPOrdLqTCVEOvRY UQnV5QUwmQ/b11gH6UFoWP/k6uCu0iu+/Y5mYenwb+DsjMTVvz/1QzWmygg4polEn1wD 6s0FAO7BR69FTaTNtan5ShNDCDncb3ncOnF/enj39Bo1lOsQw29joxNDsQI45p0F/dHv uoW1UJhUmHCZBeAqeDyJCAvN9O/7NYIxtxQN9XF9flAC19Knx7a3pAbUyolu2ZB399Dd C11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724914688; x=1725519488; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7SwnYZ37Z9+2puHxikFFLAYnVN6/3k1uh0+GjTkpac8=; b=inHQyhdYK2rZbd8AZ5gPyFYrbldzXmf7QWzDB8bZ+7z3qU4ZUvTGo6a9jhzinMPpdm 1HHTSSG8ePmqPT6suSF47H3/IE9f1eBvnpgMVeKCXaNGUdK22TycSI5U6L+Hz0rYm+cZ XoU4uMMMVQHwLuuVm46SgAGv5nkC+2ZLxLtmsgvO9/fUGJnK1XCf8gH4yNcl9IrN5TmI qXM/Hlkj8c3972GmLTgVyhTsH2NbkHwcgr+/08dXQHtw9WXwvV6dDvXsGJx27pna/0N2 +7Otq3PXOLbAs+CMVtWB+nPLeReqnTRf6JsZb93ts4wOZ+fmmtJ7yVVhZpZujWGBELpw 3FBg== X-Forwarded-Encrypted: i=1; AJvYcCWKhiIU5CIb9Kroq3scTTCtqpEIOobjWhjGL2jnxO8KEFxXVTEMbNrHt7nFSH9Vr2GQMGh4Tw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz15NBJlGbNi564z1qpQLXoQ5NivMYbr/vzk/otoJJOGfX3HOMq vAl9qsY2s+WidjvDZH6Hv2fYEHyf/5c88ibA4tOdonCas9eSLHkEofIRJnIv X-Google-Smtp-Source: AGHT+IEx5kxab+sy0+SrnlLDb9NxZhwFaeRc9X3tuZ1XAiXMxeyHpRZnYwfZjh5CIDPlkFLKk5XtFg== X-Received: by 2002:a05:6358:61c2:b0:1b1:a810:85a5 with SMTP id e5c5f4694b2df-1b603c29ee4mr266671455d.12.1724914688384; Wed, 28 Aug 2024 23:58:08 -0700 (PDT) Original-Received: from debian-hx90 (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e56e4898sm518368b3a.179.2024.08.28.23.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 23:58:08 -0700 (PDT) In-Reply-To: <87seuxbk6f.fsf@debian-hx90.lan> (Xiyue Deng's message of "Wed, 21 Aug 2024 15:11:36 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290913 Archived-At: Xiyue Deng writes: > Hi Philip, > > Philip Kaludercic writes: > >> Xiyue Deng writes: >> >>> Eli Zaretskii writes: >>> >>>>> From: Xiyue Deng >>>>> Cc: Thomas Fitzsimmons , Bj=C3=B6rn Bidar >>>>> , rpluim@gmail.com, 72358@debbugs.gnu.org >>>>> Date: Wed, 14 Aug 2024 01:23:19 -0700 >>>>>=20 >>>>> >> It's been a few days since the last time I received feedback for >>>>> >> improvements regarding my patches. Is there any other feedbacks/r= eviews >>>>> >> I am expecting from the co-maintainers? Please also let me know w= hen >>>>> >> it's time to ask for merging and requesting a new tagged release. >>>>> > >>>>> > ?? The last message in this discussion was just yesterday evening, = and >>>>> > my understanding is that you are still discussing the issues and did >>>>> > not reach the final conclusion. If I'm mistaken, my apologies; >>>>>=20 >>>>> The recent communication was not related to my patches but to check >>>>> whether it is possible to support outlook.com OAuth2 login (and the >>>>> conclusion was no because refreshing access token was disabled as >>>>> confirmed by MS representative during an online chat.) >>>>>=20 >>>>> > please describe your conclusion and post the patch that you-all agr= ee >>>>> > would solve the issues, and let's take it from there. >>>>>=20 >>>>> I actually only received comments from Robert and I have updated my >>>>> patches according in [1][2] (also attached in EOM). >>>>>=20 >>>>> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#20 >>>>> [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#44 >>>> >>>> Thanks. >>>> >>>> Philip, could you please DTRT here? This seems to be an ELPA package. >>> >>> Friendly ping. Please also let me know if there are more review >>> comments. >> >> I'm sorry, this was a rather long thread and I didn't have the time yet >> to follow up on it. Can you confirm that you want me to review the >> patches attached to this message: >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#20 >> >> ? > > Almost with a later update for patch 5. I am now attaching the latest > patches here to avoid any confusions. Thanks! Friendly ping. --=20 Xiyue Deng