unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode'
@ 2024-10-01 18:40 john muhl
  2024-10-01 18:43 ` john muhl
  0 siblings, 1 reply; 4+ messages in thread
From: john muhl @ 2024-10-01 18:40 UTC (permalink / raw)
  To: 73586

Tags: patch

Add tags to interactive commands that only make sense in lua mode
buffers.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode'
  2024-10-01 18:40 bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode' john muhl
@ 2024-10-01 18:43 ` john muhl
  2024-10-01 19:37   ` Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: john muhl @ 2024-10-01 18:43 UTC (permalink / raw)
  To: 73586

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Tag-interactive-commands-in-lua-ts-mode.patch --]
[-- Type: text/x-patch, Size: 1495 bytes --]

From bba5bcf0df080c92508f4fc932f9ea27874f0b05 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Sat, 13 Jul 2024 18:36:38 -0500
Subject: [PATCH] Tag interactive commands in 'lua-ts-mode'

* lisp/progmodes/lua-ts-mode.el (lua-ts-send-buffer):
(lua-ts-send-file):
(lua-ts-send-region): Mark inferior interaction commands that are
only relevant in Lua buffers. (bug#73586)
---
 lisp/progmodes/lua-ts-mode.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index dd04a9e7569..7f16c75bdb5 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -676,19 +676,19 @@ lua-ts-inferior-lua
 
 (defun lua-ts-send-buffer ()
   "Send current buffer to the inferior Lua process."
-  (interactive)
+  (interactive nil lua-ts-mode)
   (lua-ts-send-region (point-min) (point-max)))
 
 (defun lua-ts-send-file (file)
   "Send contents of FILE to the inferior Lua process."
-  (interactive "f")
+  (interactive "f" lua-ts-mode)
   (with-temp-buffer
     (insert-file-contents-literally file)
     (lua-ts-send-region (point-min) (point-max))))
 
 (defun lua-ts-send-region (beg end)
   "Send region between BEG and END to the inferior Lua process."
-  (interactive "r")
+  (interactive "r" lua-ts-mode)
   (let ((string (buffer-substring-no-properties beg end))
         (proc-buffer (lua-ts-inferior-lua)))
     (comint-send-string proc-buffer "print()") ; Prevent output from
-- 
2.46.2


[-- Attachment #2: Type: text/plain, Size: 130 bytes --]



john muhl <jm@pub.pink> writes:

> Tags: patch
>
> Add tags to interactive commands that only make sense in lua mode
> buffers.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode'
  2024-10-01 18:43 ` john muhl
@ 2024-10-01 19:37   ` Stefan Kangas
  2024-10-02  6:30     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2024-10-01 19:37 UTC (permalink / raw)
  To: john muhl, 73586-done

Version: 30.1

john muhl <jm@pub.pink> writes:

> From bba5bcf0df080c92508f4fc932f9ea27874f0b05 Mon Sep 17 00:00:00 2001
> From: john muhl <jm@pub.pink>
> Date: Sat, 13 Jul 2024 18:36:38 -0500
> Subject: [PATCH] Tag interactive commands in 'lua-ts-mode'
>
> * lisp/progmodes/lua-ts-mode.el (lua-ts-send-buffer):
> (lua-ts-send-file):
> (lua-ts-send-region): Mark inferior interaction commands that are
> only relevant in Lua buffers. (bug#73586)

Thanks, installed on emacs-30 with some minor copy edits to the commit
message (commit 63058e1153a).





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode'
  2024-10-01 19:37   ` Stefan Kangas
@ 2024-10-02  6:30     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2024-10-02  6:30 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: jm, stefankangas, 73586

> Resent-To: bug-gnu-emacs@gnu.org
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 1 Oct 2024 21:37:12 +0200
> 
> Version: 30.1
> 
> john muhl <jm@pub.pink> writes:
> 
> > From bba5bcf0df080c92508f4fc932f9ea27874f0b05 Mon Sep 17 00:00:00 2001
> > From: john muhl <jm@pub.pink>
> > Date: Sat, 13 Jul 2024 18:36:38 -0500
> > Subject: [PATCH] Tag interactive commands in 'lua-ts-mode'
> >
> > * lisp/progmodes/lua-ts-mode.el (lua-ts-send-buffer):
> > (lua-ts-send-file):
> > (lua-ts-send-region): Mark inferior interaction commands that are
> > only relevant in Lua buffers. (bug#73586)
> 
> Thanks, installed on emacs-30 with some minor copy edits to the commit
> message (commit 63058e1153a).

Thanks, but this should have been installed on master, not on the
release branch.  It is not a bug, and we are after the first pretest.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-02  6:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 18:40 bug#73586: [PATCH] Tag interactive commands in 'lua-ts-mode' john muhl
2024-10-01 18:43 ` john muhl
2024-10-01 19:37   ` Stefan Kangas
2024-10-02  6:30     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).