From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73357: [PATCH] Make vc-clone interactive Date: Thu, 24 Oct 2024 19:26:19 +0800 Message-ID: <87a5et4u90.fsf@melete.silentflame.com> References: <875xqrlr3b.fsf@disroot.org> <86ploz935f.fsf@gnu.org> <87y13nk39b.fsf@disroot.org> <87ed59tkpk.fsf@posteo.net> <871q12fhf2.fsf@disroot.org> <87jzesulk7.fsf@posteo.net> <87y131ffox.fsf@disroot.org> <86msj9wmna.fsf@gnu.org> <874j516bwk.fsf@disroot.org> <87sesl93xe.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Eli Zaretskii , 73357@debbugs.gnu.org To: Philip Kaludercic , Aleksandr Vityazev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 24 13:27:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3w0V-0009GO-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Oct 2024 13:27:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3w08-00078v-0f; Thu, 24 Oct 2024 07:27:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3w04-00078k-Pp for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 07:27:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3w04-0007zK-Cl for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 07:27:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wq6gu8Gy9RE1L46dWpoR9AOJ0BgM6YBTmpQHBbnFYfQ=; b=Gp/LDMOUh3I8f6RSEiak0roxdTWQ2hG74NIV7nFzULxTFQQfgYw7JXON0YjE9L6Tj1EqVDYk7aCX5Rzrncj6VZpOlHUFNvOREJU2B5t6QU+oEtnakSP4Pjqw8zdZ24PPvlUmTbwlpfxoPytYYQBy0fLFozBFVQGzr7C9/fanQRLxPbPpVV1uepzo0WolYZN5FOM9vEOf+SfT+fB+bnSseIMafBCHXVdwcj2cWD9dhJ7ojNyR+w/NoGjRD9meBsC5KzYKBKa0KurOwyjufm3XvlNDV8lglujrINg9Wiv6iJAHh4fq0aenTHkXq6LVKq/4xOVfYtv1Z0ojl+bVvtbUUQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3w0Y-0006Hh-Js for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 07:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2024 11:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73357-submit@debbugs.gnu.org id=B73357.172976922424080 (code B ref 73357); Thu, 24 Oct 2024 11:28:02 +0000 Original-Received: (at 73357) by debbugs.gnu.org; 24 Oct 2024 11:27:04 +0000 Original-Received: from localhost ([127.0.0.1]:33892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3vzc-0006GK-FN for submit@debbugs.gnu.org; Thu, 24 Oct 2024 07:27:04 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:37506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3vzZ-0006Fm-Hc for 73357@debbugs.gnu.org; Thu, 24 Oct 2024 07:27:03 -0400 DKIM-Signature: a=rsa-sha256; b=Oa7nLeoHyYPL/GTY2wVpRaztRB2zJfiTRQbXCox3LPafps/zYtclhHazUedA2nPLfpMD1SBTmqDYZVklu3R+ivCwEywvotshYc/FsuVyHI8cuEs1u5kO+SsNpWxZryuAI1+6tmQJ6wQVG5mwHgEi/RUQs7hzctqZkvVYqZtj2s+jf7ErmvNI+szNJhZcphp2/3W09H+CvFZWKt6XRwOn//yFhQbOpKy44MYAzCuMBeH8xIVY0tmUXrRnFRqOHYzlVERA/peKMwgjyP/FIEEtaYADyN6K25GlGTlbJNvKRy289GY6Zqi8baXujwrKO2K+zjI7BUmIbB7tc7bg0eGiMg==; s=purelymail2; d=spwhitton.name; v=1; bh=YLQxKiABoO1TS2fLk+v/2HD+pkIvERVJI4X+NDLruTU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=qC3laULbhe0Ug73UgimiVSnz9JctOCsBjFPB0gzglHsQHWr/bHfLM9vmIfPcBcAdyRqfaPe1tPkP0ueiPinQEijcfCIxbbR3kj1M1S/JZtvwySH9fDd52YqBwBjzZh2opeR6gPn8nMJCW7AsqrHlzeuwXP5mK5LTt7AKF1fLZmOeRgWDtGpvhvh2tMiZXwXjBnDIQj/W2GB2+UR541b33dvoWB/c2sFZ+ZPpsxEsvjuihr619mPlvBwOdadsRQjBwy0UdH8vLfDGHkM5f4AxHw5T90vHgwPi74YNOXdvl5TsVQvVrPIwprAU7DqGmNEnQmaXYrm/FO9tQqA1AfCLgA==; s=purelymail2; d=purelymail.com; v=1; bh=YLQxKiABoO1TS2fLk+v/2HD+pkIvERVJI4X+NDLruTU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73357@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1200676560; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 24 Oct 2024 11:26:23 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E5B667ED51F; Thu, 24 Oct 2024 19:26:19 +0800 (CST) In-Reply-To: <87sesl93xe.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 24 Oct 2024 10:43:41 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294183 Archived-At: Hello, On Thu 24 Oct 2024 at 10:43am GMT, Philip Kaludercic wrote: > Aleksandr Vityazev writes: > > [...] > >>>> V4 patches: >>> >>> Thanks. >>> >>> Dmitry, any comments, or should I install this? >> >> Just a gentle ping, any news on this bug? > > FWIW as the vc-clone author, I think we can apply it, but Dmitry is the > VC maintainer so he should have the last word. I'm the new VC maintainer. Aleksandr, thank you for this. Some comments on v4: - The commit message of the first patch doesn't completely follow the guidelines in CONTRIBUTE. I think M-q will fix it. - I also find the ... thing hard to read because it's separated by other changes. Would you mind just writing out the changes twice? - vc-heuristic-alist should probaby have ':version 31.1' - Inserting vc-guess-backend right at the top doesn't seem right. There is already a section "Code for deducing what fileset and backend to assume". - I think that vc-guess-backend should be called vc-guess-url-backend or similar. 'vc-guess-backend' is too generic. - I'm not really convinced by the OPEN-DIR argument. You specifically say that it's for scripting purposes, but then, the script can just call find-file :) Is there some reason why it's better as an argument? -- Sean Whitton