From: Sean Whitton <spwhitton@spwhitton.name>
To: Philip Kaludercic <philipk@posteo.net>,
Aleksandr Vityazev <avityazev@disroot.org>
Cc: Dmitry Gutov <dmitry@gutov.dev>, Eli Zaretskii <eliz@gnu.org>,
73357@debbugs.gnu.org
Subject: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 24 Oct 2024 19:26:19 +0800 [thread overview]
Message-ID: <87a5et4u90.fsf@melete.silentflame.com> (raw)
In-Reply-To: <87sesl93xe.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 24 Oct 2024 10:43:41 +0000")
Hello,
On Thu 24 Oct 2024 at 10:43am GMT, Philip Kaludercic wrote:
> Aleksandr Vityazev <avityazev@disroot.org> writes:
>
> [...]
>
>>>> V4 patches:
>>>
>>> Thanks.
>>>
>>> Dmitry, any comments, or should I install this?
>>
>> Just a gentle ping, any news on this bug?
>
> FWIW as the vc-clone author, I think we can apply it, but Dmitry is the
> VC maintainer so he should have the last word.
I'm the new VC maintainer.
Aleksandr, thank you for this. Some comments on v4:
- The commit message of the first patch doesn't completely follow the
guidelines in CONTRIBUTE. I think M-q will fix it.
- I also find the ... thing hard to read because it's separated by
other changes. Would you mind just writing out the changes twice?
- vc-heuristic-alist should probaby have ':version 31.1'
- Inserting vc-guess-backend right at the top doesn't seem right. There
is already a section "Code for deducing what fileset and backend to
assume".
- I think that vc-guess-backend should be called vc-guess-url-backend or
similar. 'vc-guess-backend' is too generic.
- I'm not really convinced by the OPEN-DIR argument. You specifically
say that it's for scripting purposes, but then, the script can just
call find-file :) Is there some reason why it's better as an
argument?
--
Sean Whitton
next prev parent reply other threads:[~2024-10-24 11:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 13:18 bug#73357: [PATCH] Make vc-clone interactive Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-19 13:36 ` Eli Zaretskii
2024-09-19 16:38 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-24 10:22 ` Philip Kaludercic
2024-09-29 18:23 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-01 11:09 ` Philip Kaludercic
2024-10-06 14:50 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 12:06 ` Eli Zaretskii
2024-10-24 10:19 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-24 10:43 ` Philip Kaludercic
2024-10-24 11:26 ` Sean Whitton [this message]
2024-10-24 12:31 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-24 13:45 ` Sean Whitton
2024-10-24 14:19 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5et4u90.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=73357@debbugs.gnu.org \
--cc=avityazev@disroot.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).