From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75199: 30.0.93; Emacs crashes when completing with corfu Date: Mon, 30 Dec 2024 19:00:45 +0100 Message-ID: <87a5cdcape.fsf@daniel-mendler.de> References: <87cyh9qq64.fsf@fuzy.me> <86ttalnsj4.fsf@gnu.org> <87r05pmctv.fsf@fuzy.me> <86ldvxnqgv.fsf@gnu.org> <8ac665654425902f3deb81481ac0242c@fuzy.me> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18912"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 75199@debbugs.gnu.org, Eli Zaretskii To: Zhengyi Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 30 19:04:42 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSK8A-0004oW-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Dec 2024 19:04:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSK7o-0006hN-3P; Mon, 30 Dec 2024 13:04:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSK7X-0006gy-1N for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:04:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSK7W-0001E9-M0 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=KUtS+0LI6Zznkq4p6P5Zl/f3A3GUXyM0oEtZKBKrS4M=; b=ZdGwYnMXxxMrO0aRVh8p0UzXIlTaN9Fqlj6iBluHFCE5dUmSr7IZ+XlKsEXgu+8JmaaW44HIkm4dAA/YO//XMs3F21RiuvePY1TGgeGg9zI97RsOAUPjFVOkL3IZm4tKW+DZcRf1JjB9Z7mSu0p3P2ore4kJirBjB4wKJNXTMjPEuzCY0DNzNRT6+upXY5JNdwvQG75jV4VTv9pwILqjL6pFopbPZ93ImxEIpF3eJ6RjTohzNMVEAuDwbJmMXO77ulvdrYU/Z3BPJufgoFu4uVKutlVkY1T7AqMPWUHebKL1mxOzb9cmwaCuBN2NFknkf97uOM3/WkjZkCenwc3eOQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSK7W-00079D-E1 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2024 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75199 X-GNU-PR-Package: emacs Original-Received: via spool by 75199-submit@debbugs.gnu.org id=B75199.173558178727400 (code B ref 75199); Mon, 30 Dec 2024 18:04:02 +0000 Original-Received: (at 75199) by debbugs.gnu.org; 30 Dec 2024 18:03:07 +0000 Original-Received: from localhost ([127.0.0.1]:59890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSK6c-00077s-I1 for submit@debbugs.gnu.org; Mon, 30 Dec 2024 13:03:06 -0500 Original-Received: from server.qxqx.de ([49.12.34.165]:60999 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSK6a-00077L-0i for 75199@debbugs.gnu.org; Mon, 30 Dec 2024 13:03:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KUtS+0LI6Zznkq4p6P5Zl/f3A3GUXyM0oEtZKBKrS4M=; b=GP1nuxS1aEEYteWNip8D3bI8hH cURUWPGxNWoXxRWwnuEnPx7+ogrO4v1jTdeLKtmi7KPBsi+/rBQDzaTv24jj+gDB7sC72jFn+1/N/ tZK3UnP2JeCkNZs3T0zK5+PnOnBIQ0Mv3K94juXTSyApI5lICPns1oiDqgiyy/cTO8/g=; In-Reply-To: <8ac665654425902f3deb81481ac0242c@fuzy.me> (Zhengyi Fu's message of "Mon, 30 Dec 2024 23:55:12 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298013 Archived-At: Zhengyi Fu writes: > On 2024-12-30 23:24, Eli Zaretskii wrote: > >> Earlier you wrote: >> >>> The error is probably caused by the width value of 0 passed to >>> XCreatePixmapFromBitmapData(). >>> It seems gui_intersect_rectangles() returns true even if the resulted >>> rectangle is empty. Is that correct behavior? >> Can you tell how this happens? Is corfu doing something special with >> the fringes? > > I noticed the following calls in corfu--popup-show before the error: > > * define-fringe-bitmap(corfu--bar [-241] 1 8 (top periodic)) > * define-fringe-bitmap(corfu--nil []) I've adjusted the second call to the following, also for compatibility with older Emacs versions. (define-fringe-bitmap 'corfu--nil [0] 1 1) For the future, maybe `define-fringe-bitmap' should either check its argument carefully and disallow empty bitmaps, or empty bitmaps should be explicitly allowed? I've not seen reports about crashes on other builds, e.g., X11+Cairo or the NS and Carbon builds for Mac. These builds seem to support empty fringe bitmaps. Daniel