From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#60311: json-available-p: make dynamically correct for Windows Date: Mon, 26 Dec 2022 13:11:21 +0100 Message-ID: <87FCD796-629F-44AE-B539-2DDAE6C148F2@gmail.com> References: <83wn6f330g.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60311@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 26 13:12:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9mL3-0007Oy-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Dec 2022 13:12:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9mKq-0000pK-6g; Mon, 26 Dec 2022 07:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mKo-0000os-Lf for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9mKo-0002Yj-DX for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9mKo-0004D9-84 for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 07:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2022 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60311 X-GNU-PR-Package: emacs Original-Received: via spool by 60311-submit@debbugs.gnu.org id=B60311.167205669216146 (code B ref 60311); Mon, 26 Dec 2022 12:12:02 +0000 Original-Received: (at 60311) by debbugs.gnu.org; 26 Dec 2022 12:11:32 +0000 Original-Received: from localhost ([127.0.0.1]:50879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mKJ-0004CM-Jk for submit@debbugs.gnu.org; Mon, 26 Dec 2022 07:11:31 -0500 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:46672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mKH-0004C9-T6 for 60311@debbugs.gnu.org; Mon, 26 Dec 2022 07:11:30 -0500 Original-Received: by mail-lf1-f43.google.com with SMTP id bp15so15698500lfb.13 for <60311@debbugs.gnu.org>; Mon, 26 Dec 2022 04:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=YCrz4BdWHUDpl/GZKeBNP63x8Ys2wy7X5Y5oom5EfKo=; b=Cp0CSSzWVChQtRYs98afulbUAG7d8WcE3y+TppDqQTWcy2FiDF9EmwxwDCIoh/ASi0 5VHOr8Jjfk2ytRSrLJ6OPVSibPg3XSZ3TQyoiK3qphThweAi09ydfgEJA9yMBaARi8LF NmEZQNyfxCNdbOJ2YaxUFCK3ORIU+gVm3LIDUqZhOBtAAbj2pQJkgd73UPbNjKGP7Atd qb2IO1RJ09a3xLwByixK9MfAu9bLBi6sCg68PCJPUufkoG4AZVg6ARNM3U1XurLFLiDy x0XDlBT2bDkXY/CNYkDoORJpio7xZo+lNi9X5Ex2oBynQdFJHZsJxMt6jlj1UGxNS8dv sscQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YCrz4BdWHUDpl/GZKeBNP63x8Ys2wy7X5Y5oom5EfKo=; b=yWdAAPw3HtfmiVog6dINLJai7DGYxqy47vRjVKP3vDLmjItdtjk5deFKtC9jsOlDev hofXQLbUkjKWbBvNOHk0pJKeZ8H1LcWPhBktLZzIEcVXmE9M+0X6+Fs+ouPQ7uXPsDCR ngs2KL0ZrHaQv0s7lpMQ0wfaLjTq9Ly89wqUu3ezMKtWFBc1DhJdtJJ3c3kP0iuv572N tDOfE2f5sIXQlkMOaf55RgDmGfUO1zyLG/NZHTB2p6Xi3xH3kO7U0uKWO9savjrhRuBQ qT9oO4R9E3PnnDZYLibTabBn/ueJuSpTS14JNvC87kTtr59Ba/ItSpTchKrIqVvNK4AF kOOA== X-Gm-Message-State: AFqh2koJuO/mw6QgDsNFv1V+m2S5lwTVIVWYDhK05r6ofo4sr1VxbFDy ur/wJmLuCfMyE9gB8IhS0Ck= X-Google-Smtp-Source: AMrXdXsbj3RsllTHgPzbQwVm99d+h5NE8uql1ICwAkpAWskYsxlNTz5fiUhsoT+tkuHeyN6zvcUMVA== X-Received: by 2002:a05:6512:2390:b0:4b5:649a:9105 with SMTP id c16-20020a056512239000b004b5649a9105mr6310518lfv.65.1672056683434; Mon, 26 Dec 2022 04:11:23 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id m2-20020ac24242000000b0048b0696d0b1sm1781939lfl.90.2022.12.26.04.11.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Dec 2022 04:11:22 -0800 (PST) In-Reply-To: <83wn6f330g.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251895 Archived-At: 25 dec. 2022 kl. 16.40 skrev Eli Zaretskii : > Yes, you are right. But please come up with a smaller changeset which > only changes what strictly needs to be changed. Or if you want, I can > do this myself. Since you have very specific ideas about how to go about it it's better = that you make the change yourself. After all, attempts to remote-control = someone else this way rarely make either party very happy. As long as it gets done I'm not very particular about it myself. >> + (and (eval-when-compile (fboundp 'json-serialize)) >> + ;; If `json--available-p' is present, we need to call it at = run-time. >> + (or (not (eval-when-compile (fboundp 'json--available-p))) >> + (json--available-p)))) >=20 > Btw, I don't understand this use of eval-when-compile here. Can you > explain why should we care at compile time whether these functions are > fboundp? Because we can: we already know the answers when subr.el is compiled, = giving us constant nil or t values that will simplify the function to a = constant or a call to json--available-p. > why not just >=20 > (and (fboundp 'json--available-p) > (json--available-p)) Calling `fboundp` at run time is wasteful, and that patch used the = presence of json--available-p to indicate whether it needs to be called = at run time (on Windows only, but it's good to keep that = platform-dependency in one place). It doesn't matter much if json-available-p is implemented in Lisp or C; = even performance-wise it's a wash.