From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42296: 27.0.91; Correct manual entry for 'concat' w.r.t. allocation [PATCH] Date: Sat, 11 Jul 2020 13:15:39 +0200 Message-ID: <87CAAEDE-4AE2-4224-A3E3-6597E6449B1D@acm.org> References: <83wo3cppc5.fsf@gnu.org> <669987BB-B825-4C2C-B9FD-31F04E0D6013@acm.org> <83r1tkplnc.fsf@gnu.org> <83o8oopk4s.fsf@gnu.org> <70B05C00-862D-412B-83DA-7129BF49C322@acm.org> <834kqfp7ir.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2714"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42296@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 11 13:21:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1juDZi-0000bo-Hz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 13:21:46 +0200 Original-Received: from localhost ([::1]:54382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juDZh-0000Pj-K1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jul 2020 07:21:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juDUA-0001Aq-VK for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 07:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juDUA-0007Ht-6n for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 07:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1juDUA-0004z6-1B for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2020 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42296-submit@debbugs.gnu.org id=B42296.159446615219145 (code B ref 42296); Sat, 11 Jul 2020 11:16:01 +0000 Original-Received: (at 42296) by debbugs.gnu.org; 11 Jul 2020 11:15:52 +0000 Original-Received: from localhost ([127.0.0.1]:43901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juDU0-0004yh-AE for submit@debbugs.gnu.org; Sat, 11 Jul 2020 07:15:52 -0400 Original-Received: from mail1466c50.megamailservers.eu ([91.136.14.66]:36844 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juDTx-0004yS-8b for 42296@debbugs.gnu.org; Sat, 11 Jul 2020 07:15:50 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1594466142; bh=+alj4HL53ukdP5kgNF9YqPBtaaFuoJXnZSfDUGeu4Ag=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=N/DYStAV30/4jLiXqOND1BSe6+p2WAHv06KWQojnMU6bITbiea4kpx0HkpE/Np6UZ szHlSBUhxLmLS0pzNZwc96yXFzA0gnxubl47ZcPIgFph2TuF8PT2D2q9Igtwqbaxk6 0NPE5+Fat4zuVJjDJwwsSIp/jKhqcspVBT4IXjwQ= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 06BBFenv003978; Sat, 11 Jul 2020 11:15:42 +0000 In-Reply-To: <834kqfp7ir.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F24.5F099ED2.0036, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=BZ+mLYl2 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=7PxkP69IKYE2QcuGk4EA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182911 Archived-At: 10 juli 2020 kl. 20.08 skrev Eli Zaretskii : > Fine with me, except that "should not be altered": I object to that, > unless we explain why. My proposed text included such an explanation; > without it, this looks like another dogma that someone sooner or later > will come up and challenge. Let's try again then, elaborating the second paragraph: This function does not always allocate a new string. Callers should not rely on the result being a new string nor on it being @code{eq} to an existing string. In particular, the returned value should not be altered, because doing so may inadvertently change another string, alter a constant string in the program, or even raise an error. To obtain a string that can be mutated, use @code{copy-sequence} on the result.