From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alvaro Ramirez Newsgroups: gmane.emacs.bugs Subject: bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path Date: Sat, 17 Aug 2024 10:27:08 +0100 Message-ID: <87BEF3AD-A1A3-45A6-8A3E-DEDEAA5583EB@xenodium.com> References: <868qwv4jjj.fsf@gnu.org> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4033"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72272@debbugs.gnu.org, copyright-clerk@fsf.org, acorallo@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 11:28:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfFjg-0000t6-RH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 11:28:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfFjW-0006qA-VG; Sat, 17 Aug 2024 05:28:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFjT-0006pd-BP for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:28:23 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfFjT-0004QD-10 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:28:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:Date:Mime-Version:From:To:Subject; bh=CmZjhp80UX/zDS7nZAfIRaCmy/nvwAHtQj0uYF2aufw=; b=nkDb1btVn3SSe4X2gy38o/UKUjxx0F2hTUZeThAIHs9iBhbQh1U1O6IF9qBxi0hyJs10hKQhIXRje6oMFe8/ejGMv/7oKCIkIlTi5ytTPRbp38Vtw0v+NgvgJAeGZKeXsLFEYaVnzNv0lV08Qe5TY+3H3Z2acgS2hw36rkXPU4rRKBJTeKXT5Z9I7cRetx9h9j5jxHfwBEMlArTqnyITPHUMxewXEj22qH+d+ZhTpZzQy9tHud6KeypAy37RZAcyE+5s6bzrReDT6NyM1CfawcMl1zI3lv3LU5dvFxKDBjLm21gtqSQtC3Nn7L/KVe/9Bn2oP95R3wvWMmOk3yPdKA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfFk5-0002YJ-LR for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alvaro Ramirez Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 09:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72272-submit@debbugs.gnu.org id=B72272.17238869209780 (code B ref 72272); Sat, 17 Aug 2024 09:29:01 +0000 Original-Received: (at 72272) by debbugs.gnu.org; 17 Aug 2024 09:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:53500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFjj-0002Xg-Jm for submit@debbugs.gnu.org; Sat, 17 Aug 2024 05:28:39 -0400 Original-Received: from out-170.mta0.migadu.com ([91.218.175.170]:59968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFjh-0002XO-D7 for 72272@debbugs.gnu.org; Sat, 17 Aug 2024 05:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xenodium.com; s=default; t=1723886841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmZjhp80UX/zDS7nZAfIRaCmy/nvwAHtQj0uYF2aufw=; b=yp1tcipDQmH04FrDyoFSl2pO2QVL4IpgdpKtNsXsq+Lt2OsyoK4RG6t2O/1c5tMPcDWesr yg3gf13rHjOaxgugm9tB2CGNUicUbPtk3ropeMPb0GeXoWeT2YennnbEAstxlFpnd8FUDM skP5yvtgPQD6/DkWe2gSWA2Aa2VA/WQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <868qwv4jjj.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290244 Archived-At: > On 17 Aug 2024, at 09:53, Eli Zaretskii wrote: >=20 > =EF=BB=BF >>=20 >> From: Alvaro Ramirez >> Cc: eliz@gnu.org, 72272@debbugs.gnu.org >> Date: Mon, 05 Aug 2024 15:34:17 +0100 >>=20 >> I also modified the patch a little to cater for >> `dired-maybe-insert-subdir` (see >> https://lists.gnu.org/archive/html/emacs-devel/2024-08/msg00033.html) >> and to include a couple of tests. >>=20 >> May be worth noting, the following dired.el comment seemed >> outdated >> https://github.com/emacs-mirror/emacs/blob/c7d9cd722e5a7042a52c92f8497f90= 3bfe9870b8/lisp/dired.el#L1805 >>=20 >> ;; Note that dired-build-subdir-alist will replace the name >> ;; by its expansion, so it does not matter whether what we insert >> ;; here is fully expanded, but it should be absolute. >>=20 >> The mentioned replacement doesn't take place when using >> `dired-maybe-insert-subdir`, so I tweaked the comment. Setting >> invisible property is now needed in two places (to handle current >> location and now subdirs). >>=20 >> Please take a look at the latest patch. Happy to go with a >> different direction if preferred. >=20 > Thanks, this LGTM. Thanks Eli! > However, AFAIU your copyright-assignment paperwork > is not yet completed, so we should wait for that, and then we can > install. +copyright-clerk@fsf.org Sounds good. It=E2=80=99s submitted. Waiting for response.=20=