unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'David Reitter' <david.reitter@gmail.com>,
	3408@emacsbugs.donarmstrong.com
Subject: bug#3408: customize-face not working: seems to apply to frame-face
Date: Thu, 28 May 2009 13:08:18 -0400	[thread overview]
Message-ID: <878wkhf94t.fsf@cyd.mit.edu> (raw)
In-Reply-To: <EFA8E29C8B21465CA45AE70D27C756A2@us.oracle.com> (Drew Adams's message of "Thu, 28 May 2009 08:40:38 -0700")

"Drew Adams" <drew.adams@oracle.com> writes:

>> Mixing set-face-attribute and Customize is a bad idea in general.
>
> It *should not* be a bad idea - or, put as a question, why *should* it
> be a bad idea? Logically, where is the problem?

It's a bad idea in general because face computation has to take into
account subtle interactions between face-new-frame-defaults, defface
settings, X resources (which can be per-frame!), Customize, etc etc etc.
Between Emacs 21 and 22, and between Emacs 22 and 23, there have been
lots of changes in these subtle interactions, many of which are not easy
to explain.

I will take a look at this specific bug, and see if there is an
acceptable fix.  But my advice for the user is to settle on one single
method for changing faces, and stick to it.

In the long run, we need to figure out a way to simplify how faces are
computed, so that this kind of problem does not arise so easily.





  reply	other threads:[~2009-05-28 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28  4:53 bug#3408: customize-face not working: seems to apply to frame-face Chong Yidong
2009-05-28 15:40 ` Drew Adams
2009-05-28 17:08   ` Chong Yidong [this message]
     [not found] <AD8B1B64-DA4C-4FB1-8B1A-4A4E4FDD503C@gmail.com>
2009-05-28  0:40 ` David Reitter
2009-05-28  1:12   ` Glenn Morris
2009-05-28  2:12   ` Kenichi Handa
2009-05-28  3:08     ` David Reitter
2009-05-28 15:40       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wkhf94t.fsf@cyd.mit.edu \
    --to=cyd@stupidchicken.com \
    --cc=3408@emacsbugs.donarmstrong.com \
    --cc=david.reitter@gmail.com \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).