From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5054: Asynchronous vc-bzr-diff (Man truncated) Date: Wed, 13 Jan 2010 02:28:33 +0200 Organization: JURTA Message-ID: <878wc2voem.fsf@mail.jurta.org> References: <4B3F58A5.6080701@gmx.at> <87ljgggfff.fsf@jidanni.org> <4B41BF95.2030106@gmx.at> <87ljge801v.fsf@mail.jurta.org> <4B423CBA.6050001@gmx.at> <87iqbfyoy4.fsf@mail.jurta.org> <4B459896.1050208@gmx.at> <87eim1ebsm.fsf@mail.jurta.org> <4B46EA66.8020905@gmx.at> <87aawnrwut.fsf@mail.jurta.org> <87skadh1wc.fsf@mail.jurta.org> <4B4ADBDB.2000304@gmx.at> <877hrnxd9g.fsf_-_@mail.jurta.org> <201001130001.o0D01qKf025239@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263343789 23325 80.91.229.12 (13 Jan 2010 00:49:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jan 2010 00:49:49 +0000 (UTC) Cc: 5054@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 13 01:49:42 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NUrQY-0001mK-EA for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jan 2010 01:49:38 +0100 Original-Received: from localhost ([127.0.0.1]:55062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUrQZ-00007K-9K for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jan 2010 19:49:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUrQH-0008SE-IZ for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 19:49:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUrQC-0008PI-K4 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 19:49:21 -0500 Original-Received: from [199.232.76.173] (port=34712 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUrQC-0008PE-I8 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 19:49:16 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35314) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUrQA-0000tA-Uo for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2010 19:49:15 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NUrEL-0004no-PC; Tue, 12 Jan 2010 19:37:01 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jan 2010 00:37:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5054 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5054-submit@debbugs.gnu.org id=B5054.126334299018441 (code B ref 5054); Wed, 13 Jan 2010 00:37:01 +0000 Original-Received: (at 5054) by debbugs.gnu.org; 13 Jan 2010 00:36:30 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUrDp-0004nM-PL for submit@debbugs.gnu.org; Tue, 12 Jan 2010 19:36:30 -0500 Original-Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NUrDl-0004n2-1h for 5054@debbugs.gnu.org; Tue, 12 Jan 2010 19:36:27 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.34.19.cable.starman.ee [82.131.34.19]) by mx2.starman.ee (Postfix) with ESMTP id 132AB3F4102; Wed, 13 Jan 2010 02:36:14 +0200 (EET) In-Reply-To: <201001130001.o0D01qKf025239@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 12 Jan 2010 16:01:52 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.0 (---) Resent-Date: Tue, 12 Jan 2010 19:37:01 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34240 Archived-At: > > It seems the bzr vc backend needs the same treatment. > > > > When `vc-diff' reports that there are no differences, then vc > > displays the *vc-diff* buffer with a single line in it: > > > > No changes between working revision and workfile. > > > > This is due to this code in vc.el:vc-diff-internal > > (if (and (zerop (buffer-size)) > (not (get-buffer-process (current-buffer)))) > ;; Treat this case specially so as not to pop the buffer. > (progn > (message "%s" (cdr messages)) > nil) I see that the difference is at `(get-buffer-process (current-buffer))'. When the process is slow, it is still running at the time when execution arrives to this condition. > > bzr's behavior differs from the git backend that doesn't display the > > *vc-diff* buffer. It displays this line only in the echo area. > > vc-git-diff does not call the diff command asynchronously (probably > because nobody had a problem with it being synchronous), but vc-bzr-diff > is asynchronous. I too see no problem with git being synchronous. -- Juri Linkov http://www.jurta.org/emacs/