From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jari Aalto Newsgroups: gmane.emacs.bugs Subject: bug#7705: [PATCH] lisp/emacs-lisp/checkdoc.el - Fix Lisp symbol `some-symbol' should appear in quotes Date: Wed, 22 Dec 2010 12:03:19 +0200 Message-ID: <878vziw2e0.fsf@picasso.cante.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1293013396 20010 80.91.229.12 (22 Dec 2010 10:23:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 22 Dec 2010 10:23:16 +0000 (UTC) To: 7705@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 22 11:23:11 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PVLqh-0001eV-4v for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Dec 2010 11:23:11 +0100 Original-Received: from localhost ([127.0.0.1]:36301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVLqg-0001YQ-DY for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Dec 2010 05:23:10 -0500 Original-Received: from [140.186.70.92] (port=44870 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVLqW-0001YC-HJ for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2010 05:23:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVLqV-0003m6-AX for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2010 05:23:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVLqV-0003ly-4n for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2010 05:22:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PVLRN-0004dg-Rh; Wed, 22 Dec 2010 04:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jari Aalto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Dec 2010 09:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7705 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.129301181317811 (code B ref -1); Wed, 22 Dec 2010 09:57:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Dec 2010 09:56:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVLRE-0004dE-GB for submit@debbugs.gnu.org; Wed, 22 Dec 2010 04:56:52 -0500 Original-Received: from emh02.mail.saunalahti.fi ([62.142.5.108]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVLRA-0004d0-NF for submit@debbugs.gnu.org; Wed, 22 Dec 2010 04:56:50 -0500 Original-Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh02-2.mail.saunalahti.fi (Postfix) with SMTP id E1017EFB9E for ; Wed, 22 Dec 2010 12:03:21 +0200 (EET) Original-Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A06CE9D8D21; Wed, 22 Dec 2010 12:03:21 +0200 Original-Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id B604941BED for ; Wed, 22 Dec 2010 12:03:20 +0200 (EET) Mail-Copies-To: poster X-Antivirus: VAMS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 22 Dec 2010 04:57:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42730 Archived-At: --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: normal In docstrings like this: Return next limit point of 'status' section in current buffer. The limist are those of top level heading: # Changes to be committed: # Changed but not updated: # Untracked files: See manual page of git-status(1). checkdoc reports: Lisp symbol `git-status' should appear in quotes The following patch adjusts regexp by not matchig strings that are immediately followed by "(". The patch is against 0804bcf 2010-12-22 Merge branch 'master' of git://git.sv.gnu.org/emacs 2010-12-22 Jari Aalto * emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): Fix "Lisp symbol `some-symbol' should appear in quotes" by not matchig strings that are immediately followed by "(", like manual page refs some-page(1). -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-emacs-lisp-checkdoc.el-Fix-Lisp-symbol-some-symbol-s.patch >From f43bab31f13260966c18c0f15062b91cefb6cd32 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Wed, 22 Dec 2010 11:58:05 +0200 Subject: [PATCH] emacs-lisp/checkdoc.el: Fix "Lisp symbol `some-symbol' should appear in quotes" Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Do not match strings that are immediately followed by "(", like manual page refs some-page(1). Signed-off-by: Jari Aalto --- lisp/emacs-lisp/checkdoc.el | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 0a3b3c9..42ac504 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1798,7 +1798,9 @@ Replace with \"%s\"? " original replace) (let ((found nil) (start (point)) (msg nil) (ms nil)) (while (and (not msg) (re-search-forward - "[^-([`':a-zA-Z]\\(\\w+[:-]\\(\\w\\|\\s_\\)+\\)[^]']" + ;; Ignore manual page refereces like + ;; git-config(1). + "[^-([`':a-zA-Z]\\(\\w+[:-]\\(\\w\\|\\s_\\)+\\)[^](']" e t)) (setq ms (match-string 1)) ;; A . is a \s_ char, so we must remove periods from -- 1.7.2.3 --=-=-=--