From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9353: 24.0.50; default grep file name face is uglier now Date: Wed, 24 Aug 2011 00:32:39 +0300 Organization: JURTA Message-ID: <878vqjvmo8.fsf@mail.jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314135644 17587 80.91.229.12 (23 Aug 2011 21:40:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 23 Aug 2011 21:40:44 +0000 (UTC) Cc: 9353@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 23 23:40:38 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qvyi6-0001UY-H5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Aug 2011 23:40:38 +0200 Original-Received: from localhost ([::1]:35522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvyi6-0002Cv-3j for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Aug 2011 17:40:38 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvyi2-0002A9-Qp for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 17:40:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qvyi1-0001rW-MG for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 17:40:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qvyi1-0001rS-H0 for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 17:40:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QvykQ-0007V4-4G; Tue, 23 Aug 2011 17:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Aug 2011 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9353-submit@debbugs.gnu.org id=B9353.131413575828796 (code B ref 9353); Tue, 23 Aug 2011 21:43:01 +0000 Original-Received: (at 9353) by debbugs.gnu.org; 23 Aug 2011 21:42:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qvyk2-0007UP-6Z for submit@debbugs.gnu.org; Tue, 23 Aug 2011 17:42:38 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qvyjz-0007UH-GD for 9353@debbugs.gnu.org; Tue, 23 Aug 2011 17:42:36 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id DF3A16E8098; Tue, 23 Aug 2011 14:40:03 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 32DE7451C3A9; Tue, 23 Aug 2011 14:40:02 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Tue, 23 Aug 2011 13:18:54 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 23 Aug 2011 17:43:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50255 Archived-At: > See attached images. The old face inherited from `font-lock-type-face', > and the appearace was OK (though not wonderful). > The new face inherits from a face called `success'. It is uhhhhgggly. FYI, old is new and new is old. I copied the default value of `success' from the old face definition of `compilation-info' that existed in Emacs 23 and older. OTOH, colors of `font-lock-type-face' for grep are new (6 months in the repository). > For one thing, it should not be bold. We should almost never use a bold > face as the default face for something, because boldness does not work > well on some platforms and for some (many) faces. I agree, e.g. with my 10px fonts, bold is unreadable. So I reset the bold attribute from all used faces. Moreover, I customized this face to "ForestGreen", i.e. to the color you are suggesting now. So I agree it's better than the current face definition. The only reason why I took the old value is because I thought it's safer to use the old face no one complained about. > I applaud not inheriting from a font-lock face: there is no logical > connection to a grepped file. But there is also no logical connection > to "success" here. I think if we'll copy the face definition from `font-lock-type-face' to `success', the former should not inherit from the latter, because they are not logically related.