bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Detlev Zundel]

Hi,

In GNUS I use threaded reading of mails.  Sometimes in a longer thread,
I'm only interested in a specific mail "down" the thread, without even
reading the thread starting mail.  This is especially common with git
patch sets of which only one changeset is interesting to me.  Having
read that individual message (and thus marked it as read), I want to
dismiss the whole thread, so I do a 'gnus-summary-top-thread' and
'gnus-summary-kill-thread'.

This workflow used to work perfectly fine until some time ago when the
'gnus-summary-kill-thread' command started to throw the message "Hiding
the thread moved us backwards, aborting!" and left me at the _bottom_ of
the summary.  The latter behaviour is especially unnerving if the
summary has hundreds of mails in it and the "working position" needs to
be recovered manually.

Today I actually looked into what is causing this problem and found this
commit:

http://lists.gnu.org/archive/html/emacs-diffs/2011-05/msg00244.html

  revno: 104293
  author: Teodor Zlatanov <address@hidden>
  committer: Katsumi Yamaoka <address@hidden>
  branch nick: trunk
  timestamp: Fri 2011-05-20 01:00:46 +0000
  message:
    gnus-sum.el (gnus-summary-hide-thread): Fix bug where moving to hide the 
  thread moves us backwards and so we loop forever.
  modified:
    lisp/gnus/ChangeLog
    lisp/gnus/gnus-sum.el
  
For a test I reverted the change manually and sure enough I have my
"regular workflow" back, i.e. the thread is killed as expected, no
message appears and Emacs keeps working as expected - no endless loop is
encountered.

So what is this "fix" supposed to fix and can it be changed so that the
described workflow wtill works?

Thanks
  Detlev


In GNU Emacs 24.1.50.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10)
 of 2012-05-03 on lamuella
Windowing system distributor `The X.Org Foundation', version 11.0.11104000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  shell-dirtrack-mode: t
  desktop-save-mode: t
  dynamic-completion-mode: t
  iswitchb-mode: t
  auto-insert-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:

[...]


Recent messages:
Mark set
End of message [12 times]
Hiding the thread moved us backwards, aborting!
Auto-saving...
Mark saved where search started [3 times]
gnus-summary-hide-thread
Mark set
Opening nntp server on news.gmane.org...done
Hit C-g to stop BBDB from annotating.  5 of 5 addresses processed.
Auto-saving...done

Load-path shadows:
/usr/local/share/emacs/24.1.50/lisp/progmodes/compile hides /usr/local/share/emacs/24.1.50/lisp/cedet/srecode/compile
/usr/local/share/emacs/24.1.50/lisp/textmodes/table hides /usr/local/share/emacs/24.1.50/lisp/cedet/srecode/table
/usr/local/share/emacs/24.1.50/lisp/cedet/semantic hides /usr/local/share/emacs/24.1.50/lisp/cedet/srecode/semantic
/usr/local/share/emacs/24.1.50/lisp/progmodes/cpp hides /usr/local/share/emacs/24.1.50/lisp/cedet/srecode/cpp
/usr/local/share/emacs/24.1.50/lisp/loaddefs hides /usr/local/share/emacs/24.1.50/lisp/cedet/srecode/loaddefs
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/texi hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/texi
/usr/local/share/emacs/24.1.50/lisp/imenu hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/imenu
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/find hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/find
/usr/local/share/emacs/24.1.50/lisp/emacs-lisp/chart hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/chart
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/ctxt hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/ctxt
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/java hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/java
/usr/local/share/emacs/24.1.50/lisp/format hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/format
/usr/local/share/emacs/24.1.50/lisp/sort hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/sort
/usr/local/share/emacs/24.1.50/lisp/loaddefs hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/loaddefs
/usr/local/share/emacs/24.1.50/lisp/emacs-lisp/debug hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/debug
/usr/local/share/emacs/24.1.50/lisp/cedet/semantic/wisent hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/wisent/wisent
/usr/local/share/emacs/24.1.50/lisp/progmodes/python hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/wisent/python
/usr/local/share/emacs/24.1.50/lisp/progmodes/grep hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/symref/grep
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/mode hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/decorate/mode
/usr/local/share/emacs/24.1.50/lisp/cedet/srecode/el hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/bovine/el
/usr/local/share/emacs/24.1.50/lisp/emacs-lisp/debug hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/bovine/debug
/usr/local/share/emacs/24.1.50/lisp/cedet/semantic/complete hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/analyze/complete
/usr/local/share/emacs/24.1.50/lisp/emacs-lisp/debug hides /usr/local/share/emacs/24.1.50/lisp/cedet/semantic/analyze/debug

Features:
(shadow emacsbug gnus-html xml url-cache mm-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
shr-color color shr browse-url flow-fill gnus-dup bbdb-hooks
multi-isearch bbdb-gui sort gnus-cite gnus-async gnus-bcklg gnus-kill qp
gnus-ml gnus-topic nndraft nnmh nnmairix nnml nnfolder bbdb-gnus
bbdb-snarf mail-extr bbdb-com cl netrc gnutls network-stream starttls
tls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg
gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime dig mailcap
nntp gnus-cache gnus-sum nnoo gnus-group gnus-undo nnmail mail-source
gnus-start gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader
wid-edit sh-script executable footnote message sendmail rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev mail-utils gmm-utils mailheader info make-mode
tex-mode shell parse-time eldoc jka-compr tar-mode dired-aux conf-mode
newcomment vc-git face-remap org-wl org-w3m org-vm org-rmail org-mhe
org-mew org-irc org-jsinfo org-infojs org-html org-exp ob-exp
org-exp-blocks find-func org-agenda org-info org-gnus org-docview
org-bibtex bibtex org-bbdb org warnings ob-emacs-lisp ob-tangle ob-ref
ob-lob ob-table org-footnote org-src ob-comint ob-keys ob ob-eval
org-pcomplete pcomplete org-list org-faces org-compat org-entities
org-macs noutline outline easy-mmode format-spec company-autoloads
package tabulated-list desktop glimpse dired compile view mule-util
cal-julian cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew
holidays hol-loaddefs vc-cvs appt diary-lib diary-loaddefs cal-menu
calendar cal-loaddefs disp-table cc-mode cc-fonts easymenu cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cmuscheme
comint ansi-color ring scheme advice help-fns advice-preload
bbdb-autoloads bbdb timezone completion iswitchb autoinsert paren time
cus-start cus-load server keypad url-util url-parse auth-source eieio
assoc gnus-util password-cache url-vars mm-util mail-prsvr byte-opt
bytecomp byte-compile cconv macroexp time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image
regexp-opt fringe lisp-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer loaddefs button faces cus-face files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty emacs)

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Lars Magne Ingebrigtsen]

Detlev Zundel <dzu@denx.de> writes:

> This workflow used to work perfectly fine until some time ago when the
> 'gnus-summary-kill-thread' command started to throw the message "Hiding
> the thread moved us backwards, aborting!" and left me at the _bottom_ of
> the summary.

Hm.  Do you have `gnus-thread-hide-killed' set?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Detlev Zundel]

Hi Lars,

thanks for looking into this!

> Detlev Zundel <dzu@denx.de> writes:
>
>> This workflow used to work perfectly fine until some time ago when the
>> 'gnus-summary-kill-thread' command started to throw the message "Hiding
>> the thread moved us backwards, aborting!" and left me at the _bottom_ of
>> the summary.
>
> Hm.  Do you have `gnus-thread-hide-killed' set?

  gnus-thread-hide-killed is a variable defined in `gnus-sum.el'.
  Its value is t
  
  Documentation:
  *If non-nil, hide killed threads automatically.
  
  You can customize this variable.

So it is set.  In gnus-sum.el I see

  (defcustom gnus-thread-hide-killed t
    "*If non-nil, hide killed threads automatically."
    :group 'gnus-thread
    :type 'boolean)

That means I'm using the default setting.  Isn't that supported?

Thanks
  Detlev

-- 
Programming is like sex: One mistake and you have to support it your lifetime

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Lars Magne Ingebrigtsen]

Detlev Zundel <dzu@denx.de> writes:

> That means I'm using the default setting.  Isn't that supported?

Sure.  But I'm unable to reproduce this bug.  `C-M-k' works on all the
threads I've tried it on.  Do you have a recipe for how to reproduce
this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Achim Gratz]

Lars Magne Ingebrigtsen writes:
> Sure.  But I'm unable to reproduce this bug.  `C-M-k' works on all the
> threads I've tried it on.  Do you have a recipe for how to reproduce
> this bug?

I know this one: Set the cursor in the summary by clicking with the
mouse on an unread thread and then do C-M-k.  It does not fault when the
cursor is set from the keyboard.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Detlev Zundel]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi Lars,

> Detlev Zundel <dzu@denx.de> writes:
>
>> That means I'm using the default setting.  Isn't that supported?
>
> Sure.  But I'm unable to reproduce this bug.  `C-M-k' works on all the
> threads I've tried it on.  Do you have a recipe for how to reproduce
> this bug?

Let me give an example from the recent linux-arm Gmane newsgroup
(gmane.linux.ports.arm.kernel) with screenshots for clarity:

I select only ten messages as I'm sure that I will see at least one
thread:


[-- Attachment #2: sc1.jpg --]
[-- Type: image/jpeg, Size: 52466 bytes --]

[-- Attachment #3: Type: text/plain, Size: 85 bytes --]


Now I read the third message into the thread (without looking at the
thread head):


[-- Attachment #4: sc2.jpg --]
[-- Type: image/jpeg, Size: 98818 bytes --]

[-- Attachment #5: Type: text/plain, Size: 223 bytes --]


Having read that, I want to kill the whole thread, so I move the cursor
to the first message in the thread (could also be done by
'gnus-summary-top-thread') - again without reading it - and do
'gnus-summary-kill-thread':


[-- Attachment #6: sc3.jpg --]
[-- Type: image/jpeg, Size: 93926 bytes --]

[-- Attachment #7: Type: text/plain, Size: 487 bytes --]


I hope this is a more clear recipy on how to reproduce that.

Thanks
  Detlev

-- 
Greenspun's Tenth Rule of Programming: "Any sufficiently complicated C
or Fortran program contains an ad-hoc, informally-specified bug-ridden
slow implementation of half of Common Lisp."
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Detlev Zundel]

Hi Lars,

[...]

> I hope this is a more clear recipy on how to reproduce that.

ping?

Updating to current emacs I still see the same problem.  So I will have
to further carry my local patch.  Can I help somehow to unstall the
problem resolution?

Thanks
  Detlev

-- 
Man sei weder unzufrieden mit sich selbst - denn das waere Kleinmut - noch
selbstzufrieden - denn das waere Dummheit.
                                    --- Baltasar Gracian

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Lars Ingebrigtsen]

This problem should be fixed in the current Emacs trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

bug#11404: 24.1.50; gnus-summary: "Hiding the thread moved us backwards, aborting!" impedes workflow

[Detlev Zundel]

Hi Lars,

> This problem should be fixed in the current Emacs trunk now.

Thanks for this christmas present ;)

I can acknowledge that I do not see the problem anymore with todays git
version from savannah.

Best wishes
  Detlev

-- 
War does not determine who is right. Only who is left. 
                               -- Bertrand Russell