unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: asjo@koldfront.dk (Adam Sjøgren)
To: 1036@debbugs.gnu.org
Subject: bug#1036: [PATCH] * xterm.c (gtk-scroll-bar-adjust-thumb-portion): New variable to determine whether gtk scroll bar thumb size should be adjusted or not. * gtkutil.c (gtk-scroll-bar-adjust-thumb-portion): Use variable.
Date: Sun, 02 Dec 2012 14:07:06 +0100	[thread overview]
Message-ID: <878v9geh6t.fsf@topper.koldfront.dk> (raw)
In-Reply-To: <08F7728F-7C66-4679-B905-E548DDA0E0FA@Freenet.DE>

Seeing that there is no correct solution in sight, maybe it would be
possible to solve the problem like this.

Summary of problem and links to discussions in the previous decade, see
here: http://koldfront.dk/archive/2012/05/27-181826.html

---
 src/ChangeLog |    7 +++++++
 src/gtkutil.c |   18 +++++++++++-------
 src/xterm.c   |   10 ++++++++++
 3 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/src/ChangeLog b/src/ChangeLog
index 80b9b1e..b95cf17 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2012-12-02  Adam Sjøgren  <asjo@koldfront.dk>
+
+	* xterm.c (gtk-scroll-bar-adjust-thumb-portion): New variable to
+	determine whether gtk scroll bar thumb size should be adjusted or
+	not (Bug#1036).
+	* gtkutil.c (gtk-scroll-bar-adjust-thumb-portion): Use variable.
+
 2012-12-01  Paul Eggert  <eggert@cs.ucla.edu>
 
 	* xterm.c (x_draw_image_relief): Remove unused locals (Bug#10500).
diff --git a/src/gtkutil.c b/src/gtkutil.c
index 4367b53..5259fe7 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -3765,13 +3765,17 @@ xg_set_toolkit_scroll_bar_thumb (struct scroll_bar *bar,
 
       adj = gtk_range_get_adjustment (GTK_RANGE (wscroll));
 
-      /* We do the same as for MOTIF in xterm.c, assume 30 chars per line
-         rather than the real portion value.  This makes the thumb less likely
-         to resize and that looks better.  */
-      portion = WINDOW_TOTAL_LINES (XWINDOW (bar->window)) * 30;
-      /* When the thumb is at the bottom, position == whole.
-         So we need to increase `whole' to make space for the thumb.  */
-      whole += portion;
+      if (gtk_scroll_bar_adjust_thumb_portion_p)
+        {
+          /* We do the same as for MOTIF in xterm.c, use 30 chars per
+             line rather than the real portion value.  This makes the
+             thumb less likely to resize and that looks better.  */
+          portion = WINDOW_TOTAL_LINES (XWINDOW (bar->window)) * 30;
+
+          /* When the thumb is at the bottom, position == whole.
+             So we need to increase `whole' to make space for the thumb.  */
+          whole += portion;
+        }
 
       if (whole <= 0)
         top = 0, shown = 1;
diff --git a/src/xterm.c b/src/xterm.c
index bbcff8c..64f069d 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -10791,6 +10791,16 @@ With MS Windows or Nextstep, the value is t.  */);
   Vx_toolkit_scroll_bars = Qnil;
 #endif
 
+#ifdef USE_GTK
+  DEFVAR_BOOL ("gtk-scroll-bar-adjust-thumb-portion",
+              gtk_scroll_bar_adjust_thumb_portion_p,
+              doc: /* Non-nil means adjust the thumb in the
+gtk scroll bar to be less likely to resize which looks better.
+Set to nil if you want the thumb to fill the whole scroll bar
+when the entire buffer is visible.  */);
+  gtk_scroll_bar_adjust_thumb_portion_p = 1;
+#endif
+
   staticpro (&last_mouse_motion_frame);
   last_mouse_motion_frame = Qnil;
 
-- 
1.7.10.4

-- 
 "It's beautiful! And I certainly hope                        Adam Sjøgren
  my parents hate this album!"                           asjo@koldfront.dk





  parent reply	other threads:[~2012-12-02 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 21:05 bug#1036: 23.0.60; GTK+ scroll-bars don't show relation of viewport to whole buffer Peter Dyballa
2008-09-28  1:17 ` Stefan Monnier
2012-12-02 13:07 ` Adam Sjøgren [this message]
2012-12-02 20:51   ` bug#1036: [PATCH] * xterm.c (gtk-scroll-bar-adjust-thumb-portion): New variable to determine whether gtk scroll bar thumb size should be adjusted or not. * gtkutil.c (gtk-scroll-bar-adjust-thumb-portion): Use variable Jan Djärv
2012-12-03 17:22     ` Stefan Monnier
2012-12-31  1:48       ` bug#1036: [PATCH] Add scroll-bar-adjust-thumb-portion Adam Sjøgren
2013-01-04 13:46         ` Jan D.
2013-01-04 19:15           ` Glenn Morris
2013-01-04 19:27             ` bug#1036: " Adam Sjøgren
2013-01-13 15:57               ` Jan Djärv
2013-01-13 15:58                 ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v9geh6t.fsf@topper.koldfront.dk \
    --to=asjo@koldfront.dk \
    --cc=1036@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).