From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#11746: feature request: `isearch-query-replace' should open invisible text Date: Thu, 30 May 2013 03:03:00 +0300 Organization: JURTA Message-ID: <878v2xjpqg.fsf@mail.jurta.org> References: <87mx3z9od7.fsf@web.de> <87pq02btxv.fsf@mail.jurta.org> <87y5eq4pm1.fsf@web.de> <8761y410tk.fsf@mail.jurta.org> <87txlmyc0r.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1369872710 3338 80.91.229.3 (30 May 2013 00:11:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 May 2013 00:11:50 +0000 (UTC) Cc: michael_heerdegen@web.de To: 11746@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 02:11:49 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UhqT7-0000uD-4T for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2013 02:11:49 +0200 Original-Received: from localhost ([::1]:55917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhqT6-0001Pd-Gr for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2013 20:11:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhqSy-0001PS-Du for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 20:11:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhqSt-0007lF-Un for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 20:11:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhqSt-0007lB-RM for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 20:11:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UhqUH-0004v4-Rk for bug-gnu-emacs@gnu.org; Wed, 29 May 2013 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2013 00:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11746-submit@debbugs.gnu.org id=B11746.136987273818830 (code B ref 11746); Thu, 30 May 2013 00:13:01 +0000 Original-Received: (at 11746) by debbugs.gnu.org; 30 May 2013 00:12:18 +0000 Original-Received: from localhost ([127.0.0.1]:41027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhqTZ-0004tf-Ue for submit@debbugs.gnu.org; Wed, 29 May 2013 20:12:18 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:56745 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhqTY-0004tX-0W for 11746@debbugs.gnu.org; Wed, 29 May 2013 20:12:16 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 1B932258B9E91C; Wed, 29 May 2013 17:10:47 -0700 (PDT) In-Reply-To: <87txlmyc0r.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 29 May 2013 01:28:52 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74652 Archived-At: Actually opening hidden overlays is not optimal when the user types `!' for automatic replacement. There is no need to open overlays and immediately close afterwards without seeing opened text by the user. This can be improved with this patch: === modified file 'lisp/replace.el' --- lisp/replace.el 2013-05-29 23:16:44 +0000 +++ lisp/replace.el 2013-05-30 00:00:39 +0000 @@ -2111,6 +2111,9 @@ (defun perform-replace (from-string repl (setq skip-filtered-count (1+ skip-filtered-count))) ;; Optionally ignore invisible matches. ((not (or (eq search-invisible t) + ;; Don't open overlays for automatic replacements. + (and (not query-flag) search-invisible) + ;; Open hidden overlays for interactive replacements. (not (isearch-range-invisible (nth 0 real-match-data) (nth 1 real-match-data))))) (setq skip-invisible-count (1+ skip-invisible-count)))