From: Juri Linkov <juri@jurta.org>
To: 11746@debbugs.gnu.org
Cc: michael_heerdegen@web.de
Subject: bug#11746: feature request: `isearch-query-replace' should open invisible text
Date: Thu, 30 May 2013 03:03:00 +0300 [thread overview]
Message-ID: <878v2xjpqg.fsf@mail.jurta.org> (raw)
In-Reply-To: <87txlmyc0r.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 29 May 2013 01:28:52 +0300")
Actually opening hidden overlays is not optimal when the user types `!'
for automatic replacement. There is no need to open overlays and
immediately close afterwards without seeing opened text by the user.
This can be improved with this patch:
=== modified file 'lisp/replace.el'
--- lisp/replace.el 2013-05-29 23:16:44 +0000
+++ lisp/replace.el 2013-05-30 00:00:39 +0000
@@ -2111,6 +2111,9 @@ (defun perform-replace (from-string repl
(setq skip-filtered-count (1+ skip-filtered-count)))
;; Optionally ignore invisible matches.
((not (or (eq search-invisible t)
+ ;; Don't open overlays for automatic replacements.
+ (and (not query-flag) search-invisible)
+ ;; Open hidden overlays for interactive replacements.
(not (isearch-range-invisible
(nth 0 real-match-data) (nth 1 real-match-data)))))
(setq skip-invisible-count (1+ skip-invisible-count)))
prev parent reply other threads:[~2013-05-30 0:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 17:56 bug#11746: feature request: `isearch-query-replace' should open invisible text Michael Heerdegen
2012-06-19 21:15 ` Juri Linkov
2013-02-14 19:02 ` Juri Linkov
2013-02-14 20:17 ` Michael Heerdegen
2013-02-15 7:54 ` Juri Linkov
2013-05-27 23:04 ` Juri Linkov
2013-05-28 22:28 ` Juri Linkov
2013-05-30 0:03 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v2xjpqg.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=11746@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).