From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Fri, 04 Apr 2014 15:43:43 +0200 Message-ID: <878url6whc.fsf@thinkpad-t440p.fritz.box> References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396619562 18608 80.91.229.3 (4 Apr 2014 13:52:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Apr 2014 13:52:42 +0000 (UTC) Cc: 16090@debbugs.gnu.org, Andreas Politz To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 04 15:52:36 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WW4Xm-0001AH-1V for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 15:52:30 +0200 Original-Received: from localhost ([::1]:50062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4Xl-00030Y-Mr for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 09:52:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4Qf-0000oH-NA for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 09:45:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW4Qa-0007ys-CM for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 09:45:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4QZ-0007xy-T8 for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 09:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WW4QY-0000mA-Sg for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 09:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Apr 2014 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.13966190672900 (code B ref 16090); Fri, 04 Apr 2014 13:45:02 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 13:44:27 +0000 Original-Received: from localhost ([127.0.0.1]:35048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW4Py-0000kf-Bu for submit@debbugs.gnu.org; Fri, 04 Apr 2014 09:44:26 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43785) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW4Pt-0000kR-Od for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 09:44:23 -0400 Original-Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 02A4D20C6E; Fri, 4 Apr 2014 09:44:21 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 04 Apr 2014 09:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=oNjFD9oZ34NSJbSq18vsACV8orw=; b=WaE32YYCcsR3uRfMDvv52NAQn3uH xHCqy3TfOQ3s2Hor7W+ucHuVV+2R0yV1IqZfpParHAvo83ZUCnSVc9NAtp039aai H0Lhph59TM9KDPA7JdHhs4IP5FJF8avHxZAY+dDTx/HEqXC1wcN2o/XJupEnkNcE bX+KOZG2sPoZBZs= X-Sasl-enc: 8/oTRXZPlr9sPB70xGcD7+3bFMqW0cfRkxWvOKSlFZaY 1396619060 Original-Received: from thinkpad-t440p.fritz.box (unknown [95.88.165.230]) by mail.messagingengine.com (Postfix) with ESMTPA id C5C9A680125; Fri, 4 Apr 2014 09:44:19 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Wed, 02 Apr 2014 10:43:34 -0400") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87739 Archived-At: Stefan Monnier writes: > For emacs-24, your patch is too intrusive, so I think a patch along > the lines of Andreas's might be acceptable, but it should use > bookmark-after-jump-hook instead of using a timer. Like so? (defun doc-view-bookmark-jump (bmk) ;; This implements the `handler' function interface for record type ;; returned by `doc-view-bookmark-make-record', which see. (let ((page (bookmark-prop-get bmk 'page))) (add-hook 'bookmark-after-jump-hook (lambda () (setq bookmark-after-jump-hook (cdr bookmark-after-jump-hook)) (when (not (eq major-mode 'doc-view-mode)) (doc-view-toggle-display)) (with-selected-window (or (get-buffer-window (current-buffer) 0) (selected-window)) (doc-view-goto-page page)))) (bookmark-default-handler bmk))) Bye, Tassilo