From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message Date: Wed, 11 Jun 2014 21:11:37 +0200 Message-ID: <878up3tg5y.fsf@yahoo.fr> References: <837g4o1x3r.fsf@gnu.org> <87r42vlavi.fsf@geodiff-mac3.ulb.ac.be> <87ha3rxx79.fsf@bzg.ath.cx> <87zjhjxwaf.fsf@geodiff-mac3.ulb.ac.be> <878up3xvje.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402513958 32421 80.91.229.3 (11 Jun 2014 19:12:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Jun 2014 19:12:38 +0000 (UTC) Cc: Nicolas Richard , 17746@debbugs.gnu.org, David Griffiths To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 11 21:12:30 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wunwj-0007rE-Cp for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jun 2014 21:12:29 +0200 Original-Received: from localhost ([::1]:49090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wunwi-0005Hi-8E for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jun 2014 15:12:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WunwY-00058H-Nz for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 15:12:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WunwT-0005Il-0R for bug-gnu-emacs@gnu.org; Wed, 11 Jun 2014 15:12:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WunwI-000595-E4; Wed, 11 Jun 2014 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WunwH-0000A0-Tc; Wed, 11 Jun 2014 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Wed, 11 Jun 2014 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17746 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 17746-submit@debbugs.gnu.org id=B17746.1402513908595 (code B ref 17746); Wed, 11 Jun 2014 19:12:01 +0000 Original-Received: (at 17746) by debbugs.gnu.org; 11 Jun 2014 19:11:48 +0000 Original-Received: from localhost ([127.0.0.1]:44572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wunw3-00009W-Ar for submit@debbugs.gnu.org; Wed, 11 Jun 2014 15:11:47 -0400 Original-Received: from mailrelay008.isp.belgacom.be ([195.238.6.174]:40437) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wunw0-00009F-KV for 17746@debbugs.gnu.org; Wed, 11 Jun 2014 15:11:45 -0400 X-Belgacom-Dynamic: yes Original-Received: from 208.166-177-91.adsl-dyn.isp.belgacom.be (HELO LDLC-portable) ([91.177.166.208]) by relay.skynet.be with ESMTP; 11 Jun 2014 21:11:37 +0200 In-Reply-To: <878up3xvje.fsf@bzg.ath.cx> (Bastien's message of "Wed, 11 Jun 2014 18:25:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90268 Archived-At: Bastien writes: > Nicolas Richard writes: > >> Bastien writes: >>> PS: The change about throwing an error when recentering a window >>> that does not display the current buffer breaks ~37 tests in Org >>> master branch, even with this fix. I need to digg this further. >> >> For me, fixing also org-fix-ellipsis-at-bol made all tests run as >> expected. > > What do you mean by "fixing"? Removing it entirely? Yes, I admit, I did : (defsubst org-fix-ellipsis-at-bol () nil) But I must have done something wrong or misread the results because now I see some other failures. Moreover, the backtrace that I get from "make test" seems incomplete and it's not obvious to me where the recenter call is made. OTOH I hope that wrapping every call to recenter in a (when (eq (current-buffer) (window-buffer)) (recenter ...)) would fix the tests, no ? -- Nico.