From: Lars Ingebrigtsen <larsi@gnus.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 20032@debbugs.gnu.org
Subject: bug#20032: eww: access bookmarks right from the URI prompt
Date: Fri, 25 Dec 2015 07:35:16 +0100 [thread overview]
Message-ID: <878u4jdoij.fsf@gnus.org> (raw)
In-Reply-To: <878uf7zsya.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 08 Mar 2015 10:25:49 +0000")
Ivan Shmakov <ivan@siamics.net> writes:
> Please consider the revised patch MIMEd.
>
> * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks
> to the default value and :options. (Bug#20032)
> (eww-suggested-bookmarks-annotation): New customizable variable.
> (eww-suggest-bookmarks, eww-remove-annotation)
> (eww-substring-nil-property): New functions.
> (eww-suggested-uris, eww): Use eww-remove-annotation.
I get a compilation warning after applying the patch... (The defvar for
eww-bookmarks should be moved.)
But conceptually I'm not sure this is a good idea. If you have a
bookmarks file, then if you say `M-x eww', you will apparently default
to the first entry in the bookmarks file? That doesn't seem very
helpful. It would be OK to have that as the first entry in the `M-n'
history, but not as the default. If I read the code correctly.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2015-12-25 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 19:45 bug#20032: eww: access bookmarks right from the URI prompt Ivan Shmakov
2015-03-08 10:25 ` Ivan Shmakov
2015-12-25 6:35 ` Lars Ingebrigtsen [this message]
2015-12-26 8:57 ` Ivan Shmakov
2015-12-26 13:05 ` Lars Ingebrigtsen
2015-12-26 16:48 ` Ivan Shmakov
2015-12-26 17:00 ` Lars Ingebrigtsen
2016-02-02 4:33 ` Lars Ingebrigtsen
2017-01-24 22:44 ` Lars Ingebrigtsen
2015-12-25 6:25 ` Lars Ingebrigtsen
2015-12-26 9:42 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u4jdoij.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=20032@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).