From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4048: 23.1; erc-server-reconnect-attempts does not work Date: Sun, 27 Dec 2015 23:37:21 +0100 Message-ID: <878u4f4ixq.fsf@gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451255902 31766 80.91.229.3 (27 Dec 2015 22:38:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 22:38:22 +0000 (UTC) Cc: Andreas Schwab , 4048@debbugs.gnu.org To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 23:38:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDJx4-0001LJ-1h for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 23:38:10 +0100 Original-Received: from localhost ([::1]:42982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJx3-0001oP-1m for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 17:38:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJwz-0001oK-Dt for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDJww-0002wZ-7J for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJww-0002wV-3l for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDJwv-000453-WA for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 4048-submit@debbugs.gnu.org id=B4048.145125586615663 (code B ref 4048); Sun, 27 Dec 2015 22:38:01 +0000 Original-Received: (at 4048) by debbugs.gnu.org; 27 Dec 2015 22:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:45098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJwg-00044Y-Dd for submit@debbugs.gnu.org; Sun, 27 Dec 2015 17:37:46 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:47799) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJwe-00044Q-7I for 4048@debbugs.gnu.org; Sun, 27 Dec 2015 17:37:45 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDJwI-0004mh-0d; Sun, 27 Dec 2015 23:37:22 +0100 In-Reply-To: (Vivek Dasmohapatra's message of "Thu, 11 Feb 2010 01:17:05 +0000 (GMT)") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aDJwI-0004mh-0d MailScanner-NULL-Check: 1451860642.28142@LN38Xcrv4HFodcBZwGxdFw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110871 Archived-At: Vivek Dasmohapatra writes: > Does this patch make the problem go away? It seems to work here. > > The problem was that erc-mode was killing all local variables, even when > the mode was already erc-mode : The patch makes it preserve the > reconnection count in that case, which seems to have the desired effect > without adversely affecting anything else. > > [ Stomping on the route didn't work for me as the existing connection was > grandfathered in by the kernel: Installing a local ircd and shutting it > down behind the client's back worked nicely though. ] IThis patch no longer applies: diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1445,7 +1445,10 @@ Special commands: \\{erc-mode-map} Turning on `erc-mode' runs the hook `erc-mode-hook'." - (kill-all-local-variables) + (let ((recon-count erc-server-reconnect-count) (old-mode major-mode)) + (kill-all-local-variables) + (if (and (eq old-mode 'erc-mode) (integerp recon-count) (< 0 recon-count)) + (setq erc-server-reconnect-count recon-count))) (use-local-map erc-mode-map) (setq mode-name "ERC" major-mode 'erc-mode Is this still a problem in erc in Emacs 25? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no