From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#21990: htmlfontify fails to generate highly highlighted regions Date: Mon, 18 Jan 2016 17:31:04 +0000 Message-ID: <878u3m3icn.fsf@russet.org.uk> References: <56529962.10301@topbug.net> <87io2uwgj5.fsf@russet.org.uk> <56998DB8.50400@topbug.net> <569B3370.2060807@topbug.net> <87si1vkfu9.fsf@russet.org.uk> <569CA0D9.5070006@topbug.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1453138522 2643 80.91.229.3 (18 Jan 2016 17:35:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jan 2016 17:35:22 +0000 (UTC) Cc: 21990@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 18 18:35:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aLDhu-0005kN-1v for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 18:35:10 +0100 Original-Received: from localhost ([::1]:32844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLDht-0000Ay-GS for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 12:35:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLDhp-00009N-7D for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 12:35:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLDhl-0003cK-VD for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 12:35:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLDhl-0003c8-RZ for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 12:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aLDhl-00048Q-KC for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 12:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jan 2016 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21990-submit@debbugs.gnu.org id=B21990.145313844915823 (code B ref 21990); Mon, 18 Jan 2016 17:35:01 +0000 Original-Received: (at 21990) by debbugs.gnu.org; 18 Jan 2016 17:34:09 +0000 Original-Received: from localhost ([127.0.0.1]:53131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLDgu-000479-Tk for submit@debbugs.gnu.org; Mon, 18 Jan 2016 12:34:09 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:38007) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLDgs-000470-Cp for 21990@debbugs.gnu.org; Mon, 18 Jan 2016 12:34:07 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1aLDgr-0008Dn-AX; Mon, 18 Jan 2016 17:34:05 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1aLDgq-0002Xo-TX; Mon, 18 Jan 2016 17:34:04 +0000 In-Reply-To: <569CA0D9.5070006@topbug.net> (Hong Xu's message of "Mon, 18 Jan 2016 00:22:49 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111716 Archived-At: --=-=-= Content-Type: text/plain Hong Xu writes: > I've tested it---yes now the highlighted regions display differently, > but the highlighting actually is just the same as the background... > > I've attached the generated html file, so you can view it. Hmmm. Just test the same file at my end, and it seems to work fine (see attached). Did you do this with emacs -q? --=-=-= Content-Type: text/html Content-Disposition: attachment; filename=temp.patch.html temp.patch 

 
diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el
index 178f3a0..ca456c7 100644
--- a/lisp/htmlfontify.el
+++ b/lisp/htmlfontify.el
@@ -999,7 +999,7 @@ merged by the user - `hfy-flatten-style' should do this."
                   (append
                    parent
                    (hfy-face-to-style-i
-                    (hfy-face-attr-for-class v hfy-display-class)) ))))
+                    (hfy-face-attr-for-class v hfy-display-class))))))
         (setq this
               (if val (case key
                        (:family         (hfy-family    val))
@@ -1018,7 +1018,7 @@ merged by the user - `hfy-flatten-style' should do this."
                        (:italic         (hfy-slant 'italic))))))
       (setq that (hfy-face-to-style-i next))
       ;;(lwarn t :warning "%S => %S" fn (nconc this that parent))
-      (nconc this that parent))) )
+      (nconc this parent that))) )
 
 (defun hfy-size-to-int (spec)
   "Convert SPEC, a CSS font-size specifier, to an Emacs :height attribute 
value.
@@ -1062,7 +1062,7 @@ haven't encountered them yet.  Returns a 
`hfy-style-assoc'."
    ((and (symbolp fn)
          (facep (symbol-value fn)))
     (hfy-face-attr-for-class (symbol-value fn) hfy-display-class))
-   (t nil)))
+   (t fn)))
 
 
 (defun hfy-face-to-style (fn)
--=-=-=--