From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command Date: Wed, 23 Mar 2016 23:27:18 +0200 Organization: LINKOV.NET Message-ID: <878u18x4um.fsf@mail.linkov.net> References: <87fuviigpw.fsf@gmail.com> <83k2ku4bb5.fsf@gnu.org> <8737riibq2.fsf@gmail.com> <837fgu49m1.fsf@gnu.org> <56F24F21.4040107@gmx.at> <878u19gn38.fsf@gmail.com> <56F2E647.7040400@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458769468 27608 80.91.229.3 (23 Mar 2016 21:44:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2016 21:44:28 +0000 (UTC) Cc: "N. Jackson" , 23092@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 23 22:44:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aiqZW-0006KO-Nh for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Mar 2016 22:44:10 +0100 Original-Received: from localhost ([::1]:46274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiqZW-0007A2-41 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Mar 2016 17:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiqZS-00079j-QZ for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2016 17:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiqZO-0006TR-PD for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2016 17:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiqZO-0006TN-LK for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2016 17:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aiqZO-0001Gt-B8 for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2016 17:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2016 21:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23092-submit@debbugs.gnu.org id=B23092.14587693984805 (code B ref 23092); Wed, 23 Mar 2016 21:44:02 +0000 Original-Received: (at 23092) by debbugs.gnu.org; 23 Mar 2016 21:43:18 +0000 Original-Received: from localhost ([127.0.0.1]:34854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiqYg-0001FR-IG for submit@debbugs.gnu.org; Wed, 23 Mar 2016 17:43:18 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:33972 helo=homiemail-a100.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiqYf-0001FH-4q for 23092@debbugs.gnu.org; Wed, 23 Mar 2016 17:43:17 -0400 Original-Received: from homiemail-a100.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a100.g.dreamhost.com (Postfix) with ESMTP id 1367B31A070; Wed, 23 Mar 2016 14:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=jurta.org; bh=818qpuA MLLxaH3cweDjGzgKTIj0=; b=IuIozTElrsBdoVGX9KhTig3ZQtfEe4qEqQb+rQy VHj9KjNOyaleO9aHgl1Zkw7AkPumRCMrzvrMsxV/B1N4b4m02mjjOZ+LCxH2R2K+ IU+uz0AUs7olJac0N6vtC7EA+vtjvzO5Jmr0wjGNjMXrxlxzW47RqLATt3gLuQuj Wztk= Original-Received: from localhost.linkov.net (82.131.89.33.cable.starman.ee [82.131.89.33]) (Authenticated sender: jurta@jurta.org) by homiemail-a100.g.dreamhost.com (Postfix) with ESMTPA id BDF2A31A061; Wed, 23 Mar 2016 14:43:14 -0700 (PDT) In-Reply-To: <56F2E647.7040400@gmx.at> (martin rudalics's message of "Wed, 23 Mar 2016 19:53:59 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115418 Archived-At: >> But in the case of completion of a file path, this assumption is not >> valid. (And completing each directory name down a file path is a >> perfectly normal use case.) The difference is that one is not doing a >> single completion but several discrete completions. > > I'm not sure whether we should by default change something in this case= . > Juri has designed the present concept and I would rather leave it to hi= m > how to proceed. I noticed this deficiency, but failed to properly fix it earlier, because it's only you who completely understands all the intricacies of window-displaying machinery ;-) However, after I looked at this again now, it looks natural to just replace =E2=80=98shrink-window-if-larger-than-buffer=E2=80=99 with =E2=80= =98fit-window-to-buffer=E2=80=99. But I'd leave it to you to decide how good this change is and what consequences it might entail. diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index ecac0ae..6540059 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1835,7 +1835,7 @@ minibuffer-completion-help 'display-buffer-below-selected)) ,(if temp-buffer-resize-mode '(window-height . resize-temp-buffer-window) - '(window-height . shrink-window-if-larger-than-buffer)) + '(window-height . fit-window-to-buffer)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))) nil