From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Date: Mon, 30 May 2016 01:09:21 +0200 Message-ID: <878tys31i6.fsf@gmx.net> References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1464563431 20851 80.91.229.3 (29 May 2016 23:10:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 May 2016 23:10:31 +0000 (UTC) Cc: 23647@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 30 01:10:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b79qa-0000Ng-7d for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 May 2016 01:10:16 +0200 Original-Received: from localhost ([::1]:57196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b79qZ-00032r-CJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2016 19:10:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b79qT-0002zL-JE for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 19:10:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b79qO-000621-Fn for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 19:10:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b79qO-00061f-Cm for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 19:10:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b79qM-00070b-5c for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 19:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.146456338726915 (code B ref 23647); Sun, 29 May 2016 23:10:02 +0000 Original-Received: (at 23647) by debbugs.gnu.org; 29 May 2016 23:09:47 +0000 Original-Received: from localhost ([127.0.0.1]:46711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79q7-000703-3b for submit@debbugs.gnu.org; Sun, 29 May 2016 19:09:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:59274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79q5-0006zq-Ua for 23647@debbugs.gnu.org; Sun, 29 May 2016 19:09:46 -0400 Original-Received: from rosalinde ([89.245.70.247]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M1n4s-1bM57r3bsw-00tmLI; Mon, 30 May 2016 01:09:38 +0200 In-Reply-To: <83eg8lx6wq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 May 2016 17:42:13 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:AA8NUDT41IV+v7/F9DewtPvJtOym7smd9zoUhK3wAVIuzCzOg9X NAZ5aEWJBtmK8AXq7bRRpBbutdPiCiE7aEhfMkJp92WsVUFzj/86knsWN3QnS0SqtIstcgT 9xto1LauPlSrZELVBgSFbc/kBE79u3Je8QL0rGU9HAlW2TK82cZtIupYhGABDK6fQdj3GkQ uBpw5pelKmnc+uw6sN65Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:7OyVZL9qqnM=:9dpAQdIXEYzX1Rd6h5gPym Eopbkg4NWndAyzNB6TN+MABYBDcTk9mW2D807l+2eRUryc5KF/9vexOoTep+cjGFK7znk+kpQ Qsty2eFtZ0z9spsHxfe9xIzC7HIJut/Wldq2gBIuoPSAjRsLUoqhqGRh6vPyxQzTw3dL2mOH0 x0N30nqaBJzeHAMmAWAaDOO/8IFNbGljZzSpVP5q6feir0ucmJCaGCAh3ghrsFpcpruW3SOWe GIN0Nh3MTcwJtdXgc87qSVmJIszIm0/0/pT5xa4P47PInjyLmiUsQVZ9/OzbidoGuAJlHDYyE wWIS8xj3UgV/bx3hitQ5pvCX6wDj4zE7MG+Far/GDOJc91vTeJz2myhQiKWV4hL6+g97GzUF/ r4lReFG5H088xLQl+/XfBHazbiLkFIROIBBsWfiIyBtz7FQ+1zZ+Unw4pX4HIm9eTcp0rxeUH kf32Z3p6FEV8+BUSf0lgi6b13cfXt/9Ekh7EvjgNyCh1rIPoId6DTq3jyEtL1eHNlnlxZq0Zf 2SdhdpW1HTMNfAnQT7PKroLlcbAFKlxZSU7qAfloQitmSGQ/n6tXGJ/OZd2BRzOsBsKaP+cN9 tgn89UJwxzyuGCzZ5HbWzAlsYtsESehCGLKKMbxGVWICKEB2Wzj0kALW7lfAUWrLmQiiyCRnP cKRL0/foTnN5aqIoCp18I7jX4YZcG/CQBD3aNvMkvj4+nsWGTqG1GIdv1XHO17pYqBwXQLAa0 G2/4+Yl90rNOq/QzecvNtGrRD1R5F+gvKX6kzJKthwZJeXtJ1zcWzADqfPl1qkKErMHpgSFo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118846 Archived-At: On Sun, 29 May 2016 17:42:13 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Sun, 29 May 2016 11:52:29 +0200 >>=20 >> O. emacs -Q >> 1. Open a man page that has a link on a hyphenated word, e.g. on my >> system: M-x man RET signal RET, put point on the word spanning lines >> 129-130, which is displayed as `sig- >> nalfd(2)'. >> 2. Type RET (or click mouse-1 or mouse-2) on that link. >> =3D> The error message "Can=E2=80=99t find the 2 sig-nalfd manpage" is d= isplayed. >>=20 >> The following patch makes the link DTRT: >>=20 >> diff --git a/lisp/man.el b/lisp/man.el >> index 5acf90b..5d4cacc 100644 >> --- a/lisp/man.el >> +++ b/lisp/man.el >> @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel >> (quit-restore-window >> (get-buffer-window (current-buffer) t) 'kill) >> (kill-buffer (current-buffer))) >> - (message "Can't find the %s manpage" >> - (Man-page-from-arguments args))) >> + ;; Entries hyphenated due to the window width >> + ;; won't be found in the man database, so remove >> + ;; the hyphenation and look again. >> + (if (string-match "-" args) > > Is it only the ASCII hyphen/minus, or could there be other characters > (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? That possibility didn't occur to me but according to Wikipedia, groff also outputs soft hyphens (octal 255) and indeed I see that the function Man-build-references-alist, which also removes hyphenation (in a more complicated way that doesn't seem to be needed in the present case), also takes the soft hyphen into account. That can be done here too by changing the above string-match regexp to "[-=C2=AD]". If someone knows of other possibilities allowed by [gt]roff, maybe the regexp could be further extended, or the condition reformulated as required. What do you think? >> This is a long-standing bug (presumably since commit >> 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although >> the fix seems safe, I suppose it's too late for emacs-25. So if there >> are no objections, should I commit it to master, or is it ok for the >> upcoming release? > > Master, please. Ok. I'll wait another day or two in case there's more feedback. Thanks. Steve Berman