From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#23642: 24.5; Dired Line Movement, Region Handling Date: Tue, 31 May 2016 00:18:20 +0300 Organization: LINKOV.NET Message-ID: <878tyr1bz7.fsf@mail.linkov.net> References: <79ec4788-6eea-e9a1-afeb-2bbb278cba8e@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1464643389 5328 80.91.229.3 (30 May 2016 21:23:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 May 2016 21:23:09 +0000 (UTC) Cc: 23642@debbugs.gnu.org To: Michael Cain Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 30 23:22:58 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b7UeG-0003gv-PS for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 May 2016 23:22:56 +0200 Original-Received: from localhost ([::1]:33238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7UeG-0005hF-1M for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 May 2016 17:22:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7UdX-00053j-I8 for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 17:22:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7UdO-0000nv-Vj for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 17:22:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7UdO-0000nr-TB for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 17:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b7UdO-0008DE-PW for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 17:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2016 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23642 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23642-submit@debbugs.gnu.org id=B23642.146464331231544 (code B ref 23642); Mon, 30 May 2016 21:22:02 +0000 Original-Received: (at 23642) by debbugs.gnu.org; 30 May 2016 21:21:52 +0000 Original-Received: from localhost ([127.0.0.1]:47815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7UdE-0008Ci-EP for submit@debbugs.gnu.org; Mon, 30 May 2016 17:21:52 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:57357 helo=homiemail-a12.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7UdD-0008Ca-81 for 23642@debbugs.gnu.org; Mon, 30 May 2016 17:21:51 -0400 Original-Received: from homiemail-a12.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTP id 550A01030063; Mon, 30 May 2016 14:21:48 -0700 (PDT) Original-Received: from localhost.linkov.net (85.253.58.75.cable.starman.ee [85.253.58.75]) (Authenticated sender: jurta@jurta.org) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTPA id 770051030062; Mon, 30 May 2016 14:21:47 -0700 (PDT) In-Reply-To: <79ec4788-6eea-e9a1-afeb-2bbb278cba8e@gmail.com> (Michael Cain's message of "Sat, 28 May 2016 17:25:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118875 Archived-At: > (I'm not sure if this is actually a bug or not, just because Dired is > used so frequently and I assume someone probably would've mentioned it > by now. Hopefully this feedback will be helpful anyway) > > I find myself using the writable feature of Dired rather frequently, bu= t > one default of Dired's up/down movement (specifically the shift > selection in Transient Mark mode) is difficult to work around. That is, > I very often try to hold down shift and proceed down lines to create a > region, but this doesn't work by default. > > I've temporarily solved this by making wrapper functions around > `dired-next-line' and `dired-previous-line' that handle the shift > selection, but it also works to add an additional "^" argument to the > existing "p" in those functions. > > Thanks! :) You are right. Shift-selection should be supported in WDired by this pat= ch. BTW, do you think that in WDired it would be more useful to select rectangular regions because file names are organized in columns. Then, for example, =E2=80=98downcase-region=E2=80=99 and =E2=80=98upcase-= region=E2=80=99 will work on the selected regions, not fail are they do now in WDired. diff --git a/lisp/wdired.el b/lisp/wdired.el index 2e68bec..600a813 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -590,7 +590,7 @@ (defun wdired-next-line (arg) "Move down lines then position at filename or the current column. See `wdired-use-dired-vertical-movement'. Optional prefix ARG says how many lines to move; default is one line." - (interactive "p") + (interactive "^p") (with-no-warnings (next-line arg)) (if (or (eq wdired-use-dired-vertical-movement t) (and wdired-use-dired-vertical-movement @@ -603,7 +603,7 @@ (defun wdired-previous-line (arg) "Move up lines then position at filename or the current column. See `wdired-use-dired-vertical-movement'. Optional prefix ARG says how many lines to move; default is one line." - (interactive "p") + (interactive "^p") (with-no-warnings (previous-line arg)) (if (or (eq wdired-use-dired-vertical-movement t) (and wdired-use-dired-vertical-movement