From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24359: Patch for byte compilation bugs Date: Sun, 04 Sep 2016 17:07:53 -0400 Message-ID: <878tv79xw6.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473023305 18130 195.159.176.226 (4 Sep 2016 21:08:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 21:08:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24359@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 04 23:08:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgeeI-0003mX-KT for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 23:08:18 +0200 Original-Received: from localhost ([::1]:51056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgeeG-00043p-8i for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 17:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgee8-00043M-Mp for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 17:08:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgee2-0005M8-Jy for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 17:08:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgee2-0005M4-Gq for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 17:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bgee2-0006VG-CR for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 17:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Sep 2016 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24359-submit@debbugs.gnu.org id=B24359.147302326024962 (code B ref 24359); Sun, 04 Sep 2016 21:08:02 +0000 Original-Received: (at 24359) by debbugs.gnu.org; 4 Sep 2016 21:07:40 +0000 Original-Received: from localhost ([127.0.0.1]:49931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgedg-0006UY-0a for submit@debbugs.gnu.org; Sun, 04 Sep 2016 17:07:40 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:38816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgede-0006UK-Oj for 24359@debbugs.gnu.org; Sun, 04 Sep 2016 17:07:39 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id c198so121318041ith.1 for <24359@debbugs.gnu.org>; Sun, 04 Sep 2016 14:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wVKhKfFTFcl4dp1NDFXxzHriWe+tHXcfP0fJv5TzXO8=; b=OeKs6gV4lsCdqnkPa/Brc833L8wkN6raAeK5fs0LVYVx8T9sOetQpUmbwbBRglqaS8 8qosx39GvFVNu+iFvoDyNoAL9+tv+i1w7++t3ASylQ+wzboyLrVy5gu7Y8WzlqceN4eQ ScSGe1tHTxnY6fF7ClRCPPWWZGsG7CdbNDdLnJFWTu1ng/V6bM9dMVMXPpcBddzBTS/1 KHC/fTjPJmvQgkc/Nd+NVaeIoBu0ny2kI8TkXebPWnbTzm7u6zuFwMi4OGXjoI5xxKN4 NfIO63G1KZNOR+/wXLWAxDhNoKKxPtiZDNb/JSAQ1IdMJkCYx/6hcVlZ7YmdKpDl5R52 Er2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=wVKhKfFTFcl4dp1NDFXxzHriWe+tHXcfP0fJv5TzXO8=; b=BDjeSIbLCbsW6V3kBJR1EuaFIwzYzIWURYQO6E2HkgJ8LXbAtpgMIiXhXJ5Eqa58ac I44ZjXKds6avwXuCmOIOI1c7onaN3Lj1zF0olnzKBuedaE4+DxOBINHnkIa2CdLdtObl mjgA79a2OCb9hl4QXxcZxrCNwtJ9aK+NE3iZmeHD0/8dHpTN0vDL+FZCaAuHnuWu0nsv OxXhws+B3+e3/xq7v1rvYR1S9Mm9Ip4HP0IwOWrjO5b6pq5diI3/YTW90lEpuNNtKaQO BSnKTyPrX9NLdoDQQL8voy+bWf0PCbhUN+aukxXqCIQhAJtJQp+XN+tvjTfcIdLTBsDy hM+g== X-Gm-Message-State: AE9vXwPw3Gr8eJjqrRdb8mcbilBKQQuqooj+I23MPk9oNhptXzJRosOwiAu4g149D+cS1w== X-Received: by 10.36.152.5 with SMTP id n5mr17649208itd.79.1473023253290; Sun, 04 Sep 2016 14:07:33 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id v7sm8225624ita.9.2016.09.04.14.07.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Sep 2016 14:07:32 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Sat, 03 Sep 2016 18:45:27 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122942 Archived-At: There was some suggestion in #23495 (to which I've merged this bug) that it may have been on purpose, but no confirmation of that, and it doesn't really make sense to me, so I think your patch is a good idea. Philipp Stephani writes: > > * lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled) > (macroexp--warn-and-return): Use =E2=80=98byte-compile-warn=E2=80=99 inst= ead of > =E2=80=98byte-compile-log-warning=E2=80=99. > > * lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-bcf) > (byte-compile-setq, byte-compile-funcall): Use > =E2=80=98byte-compile-report-error=E2=80=99 instead of =E2=80=98byte-comp= ile-log-warning=E2=80=99. [...] > * lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use) > (cconv--analyze-function, cconv-analyze-form): Use > =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-log-= warning=E2=80=99. > > * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Use > =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-log-= warning=E2=80=99. > > * lisp/subr.el (add-to-list): Use =E2=80=98byte-compile-report-error=E2= =80=99 instead > of =E2=80=98byte-compile-log-warning=E2=80=99. > (do-after-load-evaluation): Use =E2=80=98byte-compile-warn=E2=80=99 inste= ad of > =E2=80=98byte-compile-log-warning=E2=80=99. I think you can combine all these into one entry. > (defun byte-compile-log-warning (string &optional fill level) > + "Log a message STRING in `byte-compile-log-buffer'. > +Also log the current function and file if not already done. If > +FILL is non-nil, set =E2=80=98warning-fill-prefix=E2=80=99 to four space= s. LEVEL Docstrings should use `', which will be converted to =E2=80=98=E2=80=99 upo= n display.