unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: charles@aurox.ch (Charles A. Roelli)
Cc: Andreas Schwab <schwab@linux-m68k.org>, 25784-done@debbugs.gnu.org
Subject: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el
Date: Mon, 20 Feb 2017 13:32:43 +0100	[thread overview]
Message-ID: <878tp1m49g.fsf@detlef> (raw)
In-Reply-To: <m2k28l8cme.fsf@aurox.ch> (Charles A. Roelli's message of "Mon, 20 Feb 2017 09:55:53 +0100")

charles@aurox.ch (Charles A. Roelli) writes:

Hi Charles,

> I realize now that this change only makes sense if mouse-2 sets point
> when clicked, as it does in Gnus.

Good catch!

> I think what follows is the correct way to do it, and it works as
> expected.

This patch works for using the mouse, but there are problems when you
enter a bug report via RET or menu <Debbugs> -> <Show Reports>.

I've applied the following patch to the repository:

--8<---------------cut here---------------start------------->8---
diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
index f814642..eb94679 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -1350,6 +1350,7 @@ MERGED is the list of bugs merged with this one."
 (defun debbugs-gnu-select-report ()
   "Select the report on the current line."
   (interactive)
+  (when (mouse-event-p last-input-event) (mouse-set-point last-input-event))
   ;; We open the report messages.
   (let* ((status (debbugs-gnu-current-status))
 	 (id (cdr (assq 'id status)))
@@ -1673,6 +1674,7 @@ The following commands are available:
 (defun debbugs-gnu-select-usertag ()
   "Select the user tag on the current line."
   (interactive)
+  (when (mouse-event-p last-input-event) (mouse-set-point last-input-event))
   ;; We open the bug reports.
   (let ((args (get-text-property (line-beginning-position) 'tabulated-list-id)))
     (when args (apply 'debbugs-gnu args))))
--8<---------------cut here---------------end--------------->8---

Will appear with the next debbugs version 0.15. I've not decided yet,
when to release.

Best regards, Michael.





  reply	other threads:[~2017-02-20 12:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 11:20 bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el Charles A. Roelli
2017-02-18 13:43 ` Andreas Schwab
2017-02-19 11:22   ` Charles A. Roelli
2017-02-20  8:16     ` Michael Albinus
2017-02-20  8:55       ` Charles A. Roelli
2017-02-20 12:32         ` Michael Albinus [this message]
2017-02-20 19:40           ` Charles A. Roelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tp1m49g.fsf@detlef \
    --to=michael.albinus@gmx.de \
    --cc=25784-done@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).