From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#25652: 26.0.50; calc says that cos(1 degree) is 0.54 Date: Thu, 18 May 2017 14:51:46 +0900 Message-ID: <878tlu3e6l.fsf@calancha-pc> References: <877f51f7ze.fsf@wilson> <87d1b6j0w3.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1495086737 13142 195.159.176.226 (18 May 2017 05:52:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 May 2017 05:52:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: 25652-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 18 07:52:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBEM9-0003Ju-0j for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 May 2017 07:52:13 +0200 Original-Received: from localhost ([::1]:51891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBEME-0004Am-MN for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 May 2017 01:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBEM1-00043V-Bb for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 01:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBELy-0004aw-7k for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 01:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBELy-0004al-4T for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 01:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dBELx-000577-UF for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 01:52:01 -0400 Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2017 05:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25652 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Mail-Followup-To: 25652@debbugs.gnu.org, tino.calancha@gmail.com, bronger@physik.rwth-aachen.de Original-Received: via spool by 25652-done@debbugs.gnu.org id=D25652.149508672019644 (code D ref 25652); Thu, 18 May 2017 05:52:01 +0000 Original-Received: (at 25652-done) by debbugs.gnu.org; 18 May 2017 05:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:51748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBELw-00056m-KZ for submit@debbugs.gnu.org; Thu, 18 May 2017 01:52:00 -0400 Original-Received: from mail-pf0-f176.google.com ([209.85.192.176]:35568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBELu-00056D-T4 for 25652-done@debbugs.gnu.org; Thu, 18 May 2017 01:51:59 -0400 Original-Received: by mail-pf0-f176.google.com with SMTP id n23so18370152pfb.2 for <25652-done@debbugs.gnu.org>; Wed, 17 May 2017 22:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=H5p/5lmzmn5XyYx+MgoDTyFBEw/EMG13Ii4FnoR01EA=; b=nOhlOOj1LpFpAFrv6C9L2obiNj0WUsy8F78nXFI3h/PL4nMtJDbOEkbqilDn7dGBxc beMnqwaj8rvPqzoE2er/uM3EKlMbHYpYXdO23SlJaVUk9z/ZQA9Ilm3v6SY2wpULhwYD BPDBwRtpO9cmZ6x1bO7fqgSDTZzS8bH1ZvAeTFFB40XZSeLRnYF83WJoQUTkne0ItWip f7LBsz7DbddH9gy95L0eN8wKwRB29Z8r90+OVCMdm2I3rTHAdZ8Ne1Ov83srFm+Atf+C c4QmuEg3nIjrf5FnKGzWAdO/qnyN6BAumGSqrsuCciZZRS6H6tKVXLaPAn16SFfAlRwO q5uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=H5p/5lmzmn5XyYx+MgoDTyFBEw/EMG13Ii4FnoR01EA=; b=QQYJh2+ZVoI8F2xwHBA4m0pMBEnaFj0d0u/nytYps+GpbgYLnACYYrai9PWqosl8Fm P4uW2AI+MBcPmLi/XZ77fvjKZBUs3isFPt7hTA/NssjxpEhoLmVOvN/ugeDtyDdQ5toU dM6/GY1jPnkvVsYZC3KRi8Wl8IvqFJ56lRLxflUB2iKvlyCGUK+yCobS/C2O6o9vthDe B4vHw12HVFdqliHq+cFrsZsmlwrOxOLNomxeg7xdJx8Jhq5wCOAE+ilaxsLp9OtQ7KJ+ fy79u7OblEdYLZaP6ijU4MWkZyQ7iEs0KmN7pU6dPuo6rteBh8WGYJnXz/J/7SZBuEgO Wmjg== X-Gm-Message-State: AODbwcD/X7lNMgW3sYjGaWJXzYpVt114CebSozh4AKgrJPu5U+efauzv 6Ul7eKTxrJQ1Yk1K X-Received: by 10.84.232.76 with SMTP id f12mr2746253pln.101.1495086712673; Wed, 17 May 2017 22:51:52 -0700 (PDT) Original-Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id d2sm9538146pgf.46.2017.05.17.22.51.49 for <25652-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 May 2017 22:51:50 -0700 (PDT) In-Reply-To: <87d1b6j0w3.fsf@users.sourceforge.net> (npostavs's message of "Wed, 17 May 2017 23:32:12 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132595 Archived-At: npostavs@users.sourceforge.net writes: > Tino Calancha writes: > >> Yes, my commit produced this bug. We must revert it. Sorry for that. >> That commit was to fix Bug#23889. It would be nice if we can fix Bug#23889 in >> a new way. >> In that bug the problem was that, if the user inputs a symbolic expression containning >> an angle unit, then this unit is overriden by calc-angle-mode while simplifying such >> expression. >> That should not happen as mentioned in the manual: >> (info "(calc) Trigonometric and Hyperbolic Functions") >> >> That is, >> M-x calc RET >> m d ; Set calc-angle-mode to degrees. >> ' sin (45 deg) RET >> u s ; Must insert the value of: (sin (* 45 pi (/ 180.0))) >> ;; But instead, inserts the value of: (sin (* 45 (expt (/ pi 180.0) 2))) >> ;; i.e., it's applying (/ pi 180) twice. >> >> I have updated the patch: >> 1) Revert 713e922243 >> >> 2) Bind calc-angle-mode to 'rad while simplifying an expression whenever such >> expression contains an unit angle. This way, hopefully, the second factor (/ pi 180) >> won't be applied. >> >> Opinions, comments... > > I'm not familiar enough with calc to say if this is a good idea or not, > but I guess you may as well push this now so that we can discover if it > has any problems sooner rather than later. Thank you. I've reverted my buggy fix, and pushed a new fix for Bug#23889 into master: Revert: eab1a6307b09180bd775cfb6bf7330eb5367bbe0 Fix: c48e539226a062d01b8d5534644fae959506a743