bug#27880: 25.2; elisp-mode-tests may downcase too aggressively

bug#27880: 25.2; elisp-mode-tests may downcase too aggressively

[Rob Browning]

[Refiling as a bug report from a list thread.]

It looks like (in 25.2, and perhaps master too) elisp-mode-tests.el
downcases the xref path (location) for comparison in
xref-elisp-test-run, but that seems to also affect the filesystem lookup
lower down (in xref--goto-location) such that a handful of tests fail if
the build path contains uppercase characters.  i.e. it tries to read the
downcased path, which of course (on ext4) doesn't exist.

In any case, I've hacked up a temporary fix by keeping the original as
"real-xref" and cloning that (and copying the location) to produce the
xref used by the modification and comparison.

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#27880: 25.2; elisp-mode-tests may downcase too aggressively

[npostavs]

merge 27880 25534
quit

Rob Browning <rlb@defaultvalue.org> writes:

> [Refiling as a bug report from a list thread.]
>
> It looks like (in 25.2, and perhaps master too) elisp-mode-tests.el
> downcases the xref path (location) for comparison in
> xref-elisp-test-run, but that seems to also affect the filesystem lookup
> lower down (in xref--goto-location) such that a handful of tests fail if
> the build path contains uppercase characters.  i.e. it tries to read the
> downcased path, which of course (on ext4) doesn't exist.
>
> In any case, I've hacked up a temporary fix by keeping the original as
> "real-xref" and cloning that (and copying the location) to produce the
> xref used by the modification and comparison.
>
> Thanks

This is the same as Bug#25534 "xref ERT tests fail when the source path
is mixed case", right?

bug#27880: 25.2; elisp-mode-tests may downcase too aggressively

[Rob Browning]

npostavs@users.sourceforge.net writes:

> This is the same as Bug#25534 "xref ERT tests fail when the source path
> is mixed case", right?

Looks likely.  And at least for Debian, something like this fixes it:

  +++ b/test/automated/elisp-mode-tests.el
  @@ -179,11 +179,15 @@ xref-elisp-test-descr-to-target
   (defun xref-elisp-test-run (xrefs expected-xrefs)
     (should (= (length xrefs) (length expected-xrefs)))
     (while xrefs
  -    (let* ((xref (pop xrefs))
  +    (let* ((real-xref (pop xrefs))
  +           (xref (clone real-xref))
              (expected (pop expected-xrefs))
              (expected-xref (or (when (consp expected) (car expected)) expected))
              (expected-source (when (consp expected) (cdr expected))))

  +      (setf (oref xref location)
  +            (copy-xref-elisp-location (oref xref location)))
  +
         ;; Downcase the filenames for case-insensitive file systems.
         (setf (xref-elisp-location-file (oref xref location))
               (downcase (xref-elisp-location-file (oref xref location))))
  @@ -193,7 +197,7 @@ xref-elisp-test-run

         (should (equal xref expected-xref))

  -      (xref--goto-location (xref-item-location xref))
  +      (xref--goto-location (xref-item-location real-xref))
         (back-to-indentation)
         (should (looking-at (or expected-source
                                 (xref-elisp-test-descr-to-target expected)))))

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4