From: Rob Browning <rlb@defaultvalue.org>
To: npostavs@users.sourceforge.net
Cc: 27880@debbugs.gnu.org
Subject: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively
Date: Sun, 30 Jul 2017 18:17:00 -0500 [thread overview]
Message-ID: <878tj55xcj.fsf@trouble.defaultvalue.org> (raw)
In-Reply-To: <87zibl7j4r.fsf@users.sourceforge.net>
npostavs@users.sourceforge.net writes:
> This is the same as Bug#25534 "xref ERT tests fail when the source path
> is mixed case", right?
Looks likely. And at least for Debian, something like this fixes it:
+++ b/test/automated/elisp-mode-tests.el
@@ -179,11 +179,15 @@ xref-elisp-test-descr-to-target
(defun xref-elisp-test-run (xrefs expected-xrefs)
(should (= (length xrefs) (length expected-xrefs)))
(while xrefs
- (let* ((xref (pop xrefs))
+ (let* ((real-xref (pop xrefs))
+ (xref (clone real-xref))
(expected (pop expected-xrefs))
(expected-xref (or (when (consp expected) (car expected)) expected))
(expected-source (when (consp expected) (cdr expected))))
+ (setf (oref xref location)
+ (copy-xref-elisp-location (oref xref location)))
+
;; Downcase the filenames for case-insensitive file systems.
(setf (xref-elisp-location-file (oref xref location))
(downcase (xref-elisp-location-file (oref xref location))))
@@ -193,7 +197,7 @@ xref-elisp-test-run
(should (equal xref expected-xref))
- (xref--goto-location (xref-item-location xref))
+ (xref--goto-location (xref-item-location real-xref))
(back-to-indentation)
(should (looking-at (or expected-source
(xref-elisp-test-descr-to-target expected)))))
--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
prev parent reply other threads:[~2017-07-30 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 16:21 bug#27880: 25.2; elisp-mode-tests may downcase too aggressively Rob Browning
2017-07-30 20:41 ` npostavs
2017-07-30 23:17 ` Rob Browning [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tj55xcj.fsf@trouble.defaultvalue.org \
--to=rlb@defaultvalue.org \
--cc=27880@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).