bug#29988: 27.0.50; completing-read: Symbol’s function definition is void: internal-make-closure

bug#29988: 27.0.50; completing-read: Symbol’s function definition is void: internal-make-closure

[Robert Cochran]

Starting from `emacs -Q` on the lastest Git master branch revision
(1cc7bc0f6 "Improve backward compatibility in tramp-archive" at time of
writing):

1) C-h v RET
2) Get error in minibuffer, instead of prompt to specify variable.

A bisect appears to point to ce4865819 ("Fix command repetition with
lexical-binding (Bug#29334)") to be the culprit. I'm afraid I'm not much
help in coming up with a fix though.

At least for me, it took a very deep clean ('git clean -dXf' is what I
used) for different checkouts to actually affect the result; doing a
make distclean and *.elc removal on a known good build did not fix the
error, only by doing the above Git command did I get any changes between
checkouts.

This is also consistent across computers; I encountered this error on my
work laptop first, and was able to reproduce on my personal laptop
afterwards. I did not at the time have a known good revision with which
to double-check on my work laptop, but I suspect that changing to the
revision I now know is good and doing the git clean then a rebuild will
fix the error.

Please let me know if I can be of any more help.

Thanks!


In GNU Emacs 27.0.50 (build 1, x86_64-redhat-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-01-04 built on SoraLaptop
Repository revision: 1cc7bc0f63ab118fda55aa40fa4b571a7c94393e
Windowing system distributor 'Fedora Project', version 11.0.11905000
System Description: Fedora release 27 (Twenty Seven)

Recent messages:
Loading /home/Sora/.emacs.d/customize.el (source)...done
Loading /home/Sora/quicklisp/slime-helper.el (source)...done
Starting Emacs daemon.
Restarting server
When done with this frame, type C-x 5 0
completing-read: Symbol’s function definition is void: internal-make-closure
When done with this frame, type C-x 5 0
command-execute: Command attempted to use minibuffer while in minibuffer
completing-read: Symbol’s function definition is void: internal-make-closure
Mark activated

Configured using:
 'configure --prefix=/home/Sora/local --with-dbus --with-gif --with-jpeg
 --with-png --with-tiff --with-xft --with-xpm --with-x-toolkit=athena
 --with-gpm=no --with-modules --with-gnutls --with-gconf
 --with-imagemagick --with-rsvg --with-libotf --with-m17n_flt
 build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu
 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Werror=format-security
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
 --param=ssp-buffer-size=4 -grecord-gcc-switches
 -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic'
 LDFLAGS=-Wl,-z,relro
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11 MODULES LIBSYSTEMD LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Messages

Minor modes in effect:
  global-auto-complete-mode: t
  show-paren-mode: t
  display-time-mode: t
  display-battery-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime dig mailcap yasnippet emacsbug sendmail help-fns radix-tree
slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu
slime-references slime-compiler-notes-tree slime-scratch
slime-presentations bridge slime-macrostep macrostep slime-mdot-fu
slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl elp slime-parse slime cl-extra help-mode flymake-proc flymake
warnings elec-pair lisp-mnt gud apropos compile etags xref project
arc-mode archive-mode hyperspec thingatpt browse-url cl slime-autoloads
org-rmail org-mhe org-irc org-info org-gnus nnir gnus-sum gnus-group
gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc
nnoo parse-time gnus-spec gnus-int gnus-range message rmc puny rfc822
mml mml-sec epa derived epg mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader gnus-win org-docview doc-view
jka-compr image-mode dired dired-loaddefs org-bibtex bibtex org-bbdb
org-w3m org-element avl-tree generator org org-macro org-footnote
org-pcomplete pcomplete org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob
ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs
org-loaddefs format-spec cal-menu calendar cal-loaddefs firestorm-notes
ace-window avy auto-complete-config auto-complete popup paredit-menu
paredit interactify-count-lines lisp-family maybe-bussard-lua lua-mode
advice edmacro kmacro rx comint ansi-color ring maybe-gnu-c cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs ispell-email ispell rotate-split neato-graph-bar ert pp
find-func ewoc debug tls gnutls whitespace finder-inf tex-site info
package easymenu epg-config url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars
deeper-blue-theme paren gnus seq byte-opt gv bytecomp byte-compile cconv
nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums
time-date mail-utils mm-util mail-prsvr wid-edit cl-loaddefs cl-lib time
battery cus-start cus-load server mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 489364 13760)
 (symbols 48 49390 6)
 (miscs 40 154 231)
 (strings 32 130400 3954)
 (string-bytes 1 3966864)
 (vectors 16 47457)
 (vector-slots 8 906630 32438)
 (floats 8 320 286)
 (intervals 56 405 0)
 (buffers 992 14))

-- 
~Robert Cochran

GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE  E7B9 EC9A 872C 41B2 77C2

bug#29988: 27.0.50; completing-read: Symbol’s function definition is void: internal-make-closure

[Noam Postavsky]

Robert Cochran <robert+Emacs@cochranmail.com> writes:

> Starting from `emacs -Q` on the lastest Git master branch revision
> (1cc7bc0f6 "Improve backward compatibility in tramp-archive" at time of
> writing):
>
> 1) C-h v RET
> 2) Get error in minibuffer, instead of prompt to specify variable.
>
> A bisect appears to point to ce4865819 ("Fix command repetition with
> lexical-binding (Bug#29334)") to be the culprit. I'm afraid I'm not much
> help in coming up with a fix though.

I thought byte-compile-lambda received the source form, but it looks
like it actually gets some kind of semi-compiled thing (which happens to
be valid lisp for simple or non-lexical code).  Getting the original
source form to that function looks to be pretty awkward; maybe the best
option is to revert the change and pursue the alternate methods
suggested by Stefan in Bug#29334.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29334#34

> At least for me, it took a very deep clean ('git clean -dXf' is what I
> used) for different checkouts to actually affect the result; doing a
> make distclean and *.elc removal on a known good build did not fix the
> error, only by doing the above Git command did I get any changes between
> checkouts.

Hmm, I would think removing elc, emacs, and emacs-bootstrap executables
should be enough.

bug#29988: 27.0.50; completing-read: Symbol’s function definition is void: internal-make-closure

[Noam Postavsky]

close 29988 
quit

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> I thought byte-compile-lambda received the source form, but it looks
> like it actually gets some kind of semi-compiled thing (which happens to
> be valid lisp for simple or non-lexical code).  Getting the original
> source form to that function looks to be pretty awkward; maybe the best
> option is to revert the change and pursue the alternate methods
> suggested by Stefan in Bug#29334.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29334#34

I've reverted the change.

[1: 5f72004678]: 2018-01-06 21:22:24 -0500
  Revert "Fix command repetition with lexical-binding (Bug#29334)"
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f720046783c5b29fad3765303c1ad57aba167ce

bug#29988: 27.0.50; completing-read: Symbol’s function definition is void: internal-make-closure

[Robert Cochran]

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> I've reverted the change.

Thanks for looking into this.

-- 
~Robert Cochran

GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE  E7B9 EC9A 872C 41B2 77C2