unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30016@debbugs.gnu.org
Subject: bug#30016: Improve visibility of Process List
Date: Mon, 29 Jan 2018 23:50:37 +0200	[thread overview]
Message-ID: <878tcg1gia.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mv1kgj5w.fsf@mail.linkov.net> (Juri Linkov's message of "Thu,  11 Jan 2018 23:49:47 +0200")

> I meant when *Process List* is displayed on quitting with ‘C-x C-c’
> where the minibuffer is active with the prompt “Active processes exist;
> kill them and exit anyway?”  It allows switching buffers when an
> expected answer is “yes/no”, but doesn't when “y/n”.

I forgot to let-bind pop-up-windows to nil like we do in other
similar places to disable window popping, but not frame popping:

diff --git a/lisp/files.el b/lisp/files.el
index 00622cf..460ed7a 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3314,7 +3314,13 @@ hack-local-variables-confirm
 
       ;; Display the buffer and read a choice.
       (save-window-excursion
-	(pop-to-buffer buf `((display-buffer--maybe-same-window
+	(let (
+              ;; Disable `pop-up-windows' temporarily to allow
+              ;; `display-buffer--maybe-pop-up-frame-or-window'
+              ;; in the display actions below to pop up a frame
+              ;; if `pop-up-frames' is non-nil, but not to pop up a window.
+              (pop-up-windows nil))
+        (pop-to-buffer buf `((display-buffer--maybe-same-window
                               display-buffer-reuse-window
                               display-buffer--maybe-pop-up-frame-or-window
                               display-buffer-at-bottom)
@@ -3322,7 +3328,7 @@ hack-local-variables-confirm
 		                  '(window-height . resize-temp-buffer-window)
 	                        '(window-height . fit-window-to-buffer))
 	                     ,(when temp-buffer-resize-mode
-	                        '(preserve-size . (nil . t)))))
+	                        '(preserve-size . (nil . t))))))
 	(let* ((exit-chars '(?y ?n ?\s ?\C-g ?\C-v))
 	       (prompt (format "Please type %s%s: "
 			       (if offer-save "y, n, or !" "y or n")
@@ -6924,6 +6930,12 @@ save-buffers-kill-emacs
                   (setq active t))
              (setq processes (cdr processes)))
            (or (not active)
+               (let (
+                     ;; Disable `pop-up-windows' temporarily to allow
+                     ;; `display-buffer--maybe-pop-up-frame-or-window'
+                     ;; in the display actions below to pop up a frame
+                     ;; if `pop-up-frames' is non-nil, but not to pop up a window.
+                     (pop-up-windows nil))
                (with-displayed-buffer-window
                 (get-buffer-create "*Process List*")
                 `((display-buffer--maybe-same-window
@@ -6943,7 +6955,7 @@ save-buffers-kill-emacs
                             (yes-or-no-p "Active processes exist; kill them and exit anyway? "))
                         (when (window-live-p window)
                           (quit-restore-window window 'kill)))))
-                (list-processes t)))))
+                (list-processes t))))))
      ;; Query the user for other things, perhaps.
      (run-hook-with-args-until-failure 'kill-emacs-query-functions)
      (or (null confirm)






  reply	other threads:[~2018-01-29 21:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 21:54 bug#30016: Improve visibility of Process List Juri Linkov
2018-01-08  3:57 ` Eli Zaretskii
2018-01-08 23:05   ` Juri Linkov
2018-01-10 21:34     ` Juri Linkov
2018-01-11 15:50       ` Eli Zaretskii
2018-01-11 21:49         ` Juri Linkov
2018-01-29 21:50           ` Juri Linkov [this message]
2018-01-08 23:11   ` Juri Linkov
2018-01-10 21:28     ` Juri Linkov
2018-01-18 21:44   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tcg1gia.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=30016@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).