From: Noam Postavsky <npostavs@gmail.com>
To: 29156@debbugs.gnu.org
Cc: Eric Skoglund <eric@pagefault.se>, Pierre Neidhardt <ambrevar@gmail.com>
Subject: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 10:43:04 -0400 [thread overview]
Message-ID: <878taqvk3r.fsf@gmail.com> (raw)
In-Reply-To: <87vaiprmg5.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 82 bytes --]
[forwarding to list, please use "Reply All" to keep 29156@debbugs.gnu.org on Cc]
[-- Attachment #2: Type: message/rfc822, Size: 1183 bytes --]
From: Eric Skoglund <eric@pagefault.se>
To: Noam Postavsky <npostavs@gmail.com>
Subject: Re: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 15:11:41 +0100
Message-ID: <877eqa7pwi.fsf@pagefault.se>
Thanks for the review!
> More importantly, could you explain a bit how your change works/why it's
> correct?
I'm guessing you mean in the commit message and not here in the bug
report right?
> Not sure this `make-symbol' call, should it rather be `intern'? (Maybe
> we should update signal-process take a string as well a symbol.)
Saw that Eli also agreed, for future reference when do we want to use
`make-symbol` vs `intern`?
> I think the args have already been converted to numbers, or did you mean
> to also add a (put 'eshell/kill 'eshell-no-numeric-conversions t)?
Yes indeed. I'm unsure how I managed to lose that in git...
// Eric
next prev parent reply other threads:[~2018-03-17 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 11:31 bug#29156: 25.3; eshell/kill does not understand -<signal> Pierre Neidhardt
2017-11-05 12:38 ` Noam Postavsky
2018-03-17 0:21 ` bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME> Noam Postavsky
2018-03-17 0:34 ` Noam Postavsky
2018-03-17 8:58 ` Eli Zaretskii
2018-03-17 17:43 ` Eric Skoglund
2018-03-17 19:33 ` Eli Zaretskii
[not found] ` <87muz65rh9.fsf@pagefault.se>
2018-03-23 1:05 ` Noam Postavsky
2018-03-23 6:03 ` Eric Skoglund
2018-03-25 15:34 ` Noam Postavsky
2018-03-17 14:43 ` Noam Postavsky [this message]
2018-03-17 14:54 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878taqvk3r.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=29156@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
--cc=eric@pagefault.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).