From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32479: Fix tracking of freed emacs_values with enabled --module-assertions Date: Sat, 25 Aug 2018 19:03:02 -0400 Message-ID: <878t4uuk0p.fsf@gmail.com> References: <05d6bad8-a739-8fcc-bd32-1291423c85a5@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535238849 22489 195.159.176.226 (25 Aug 2018 23:14:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 25 Aug 2018 23:14:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32479@debbugs.gnu.org To: Sergey Vinokurov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 26 01:14:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fthkq-0005l1-V8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Aug 2018 01:14:05 +0200 Original-Received: from localhost ([::1]:47336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fthmx-0004LG-5v for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Aug 2018 19:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fthmg-0004E5-IL for bug-gnu-emacs@gnu.org; Sat, 25 Aug 2018 19:16:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fthb9-00026y-Fm for bug-gnu-emacs@gnu.org; Sat, 25 Aug 2018 19:04:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fthb8-00023Z-R8 for bug-gnu-emacs@gnu.org; Sat, 25 Aug 2018 19:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fthb8-0007D8-Gd for bug-gnu-emacs@gnu.org; Sat, 25 Aug 2018 19:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Aug 2018 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32479-submit@debbugs.gnu.org id=B32479.153523819227651 (code B ref 32479); Sat, 25 Aug 2018 23:04:02 +0000 Original-Received: (at 32479) by debbugs.gnu.org; 25 Aug 2018 23:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:60825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fthaK-0007Bq-IK for submit@debbugs.gnu.org; Sat, 25 Aug 2018 19:03:12 -0400 Original-Received: from mail-io0-f196.google.com ([209.85.223.196]:45709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fthaJ-0007BW-AQ; Sat, 25 Aug 2018 19:03:11 -0400 Original-Received: by mail-io0-f196.google.com with SMTP id e12-v6so9928426iok.12; Sat, 25 Aug 2018 16:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FbLBw2OsR4y3POD8Vy5/d1qLRwO4O8qd4gx2gAsjuxo=; b=Qnw9BdWissIZeO2OJ/I5sh7+4U/PKAOU1DchGsO1TIEcJ7g05sPf36Cq92gVhYjGED 6cuBj2QqPQ5lA+7Wa8hq7WKvq4LFrbYAQ2bjd9KLIiYY/15qHsWAadTA3enb1D99dmN6 tIxmhRNtjDQxQqtyrPKMI2LmUsqASIDQecNdsoE48M6TGO7N/WBC/EEnH4TLCi3cYROP +ndbzMaWr6XrseoONM0MA8n7h1YqcUSnoEEJc6ZcRxnWvU58zCknERLhNaOd+QkkDreN eZYkfp6qJJIZLvHRe5GE/R5DIYVCL3SAtXQHi6CGXya1zpb9B1HJN08b0mny/UvdK6at zFgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FbLBw2OsR4y3POD8Vy5/d1qLRwO4O8qd4gx2gAsjuxo=; b=TSeCkyJyliHF8prSag9VVcAxu8aWedCAP864waRi/AlmTAuec6yibvqwuWL3owcgy9 BULASWpaRcsE1qVNQscHEsUEY1BSguUSHQwfSNkK75fG1o1T7ZLMBo0/A2UHURdEMm9T UePSg+9cQiTWU4WDk5w0iN4qsvjrIIKpo/pE9a7EtUjd3mDikwetlU1yIzsDnVkbNJFk uNuevza7CC5l17BXY2vsxDDMwRUi/an7Qld1pXVeZ1XwPIk3JLpftnGuRR7RzIMRTY2b cjTbt1SdHlXc8AYU17G7ADDTwK0kuu0eGrxMVl8hZOfsmaI7e1QAPlGy9DDd4+g/rV/f ivgw== X-Gm-Message-State: APzg51A+OnB+E+ZEltg6asaBKDyfyWtifoZZDG1eUlzC3fO+nOskbVHA s1jvYbaKrUolicIaC7Ln5B9A6TiH X-Google-Smtp-Source: ANB0VdYAz897vaK3G24V72ilNMESpsZi/kYL4k6Xq2gIIKvQ1KqO0FkBenUJ4ymxiRDJSizMvLr3DA== X-Received: by 2002:a5e:d803:: with SMTP id l3-v6mr5270360iok.236.1535238185574; Sat, 25 Aug 2018 16:03:05 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e15-v6sm3471953ioh.18.2018.08.25.16.03.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Aug 2018 16:03:04 -0700 (PDT) In-Reply-To: <05d6bad8-a739-8fcc-bd32-1291423c85a5@gmail.com> (Sergey Vinokurov's message of "Mon, 20 Aug 2018 09:27:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149749 Archived-At: tags 32479 fixed close 32479 26.2 quit Sergey Vinokurov writes: > I was developing a dynamic module when I noticed that when > '--module-assertions' are enabled I got strange complaints regarding > value to be freed. Namely, Emacs was producing an error message like the > following one: > > Emacs module assertion: Global value was not found in list of 10 globals > > I tracked it down to a bug in module_free_global_ref. It's traversal of > the linked list of all allocated global values was flawed and only > considered the head of the list. Please find attached my attempt at > fixing it and a test in Emacs test suite that reproduces the issue. Thanks, pushed to emacs-26. P.S. Don't forget to end sentences with a period in the body of the commit message. [1: 54fb383af6]: 2018-08-25 18:57:56 -0400 Fix detection of freed emacs_values (Bug#32479) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=54fb383af6f6af7b72c28f38b308d9b24d2af4f6