From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32731: 26.1.50; Ibuffer filter by mode: Handle >1 mode names Date: Sat, 15 Sep 2018 08:42:54 -0400 Message-ID: <878t43rkxd.fsf@gmail.com> References: <87bm919s5y.fsf@calancha-pc.dy.bbexcite.jp> <874let9lps.fsf@calancha-pc.dy.bbexcite.jp> <87ftydezmi.fsf@gmail.com> <87worn86l5.fsf@calancha-pc.dy.bbexcite.jp> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537015328 2680 195.159.176.226 (15 Sep 2018 12:42:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Sep 2018 12:42:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32731@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 15 14:42:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g19tj-0000a2-Ni for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Sep 2018 14:42:03 +0200 Original-Received: from localhost ([::1]:55438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g19vq-0001JX-9M for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Sep 2018 08:44:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g19vi-0001JF-1a for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 08:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g19vd-0008I6-Vo for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 08:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g19vd-0008Hz-Qx for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 08:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g19vd-0007qN-It for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 08:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Sep 2018 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32731-submit@debbugs.gnu.org id=B32731.153701538730074 (code B ref 32731); Sat, 15 Sep 2018 12:44:01 +0000 Original-Received: (at 32731) by debbugs.gnu.org; 15 Sep 2018 12:43:07 +0000 Original-Received: from localhost ([127.0.0.1]:41171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g19ul-0007p0-CC for submit@debbugs.gnu.org; Sat, 15 Sep 2018 08:43:07 -0400 Original-Received: from mail-io1-f49.google.com ([209.85.166.49]:43349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g19uj-0007oV-JL for 32731@debbugs.gnu.org; Sat, 15 Sep 2018 08:43:06 -0400 Original-Received: by mail-io1-f49.google.com with SMTP id y10-v6so8082948ioa.10 for <32731@debbugs.gnu.org>; Sat, 15 Sep 2018 05:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=vLk0xXrxBUVZwYOe2900cDsw6U4M18p3y0dM14bplRU=; b=nAEF2IeINLnqD98sVsti3/sGQ49PSU7edLZVVwmPgB5y28qoVpbiZ+dqbnRWkoW9W8 7L6txcBVJcbUl+GBbUHYem+ptlQN7kkn5YPDsw5pZ5jrmV2fdquwcup+8+60K1v+XxKe PWmSZYqavZ4ANGK4u4vrNG2dra8d+kpYMkGPQViI1/nY/TIKOYBRGwzDz76Xd7WpoF3c elNbjWrmTaKljYGmIYBDzVA39WLccparjCPOrahdq3rZnLjWMiX3YVixVAVkmq5gKZWp JnYra5G9/n7Gx88T54AesByUcABJNrtdqzYwLF/W27DFh/3tCp4O9mn16JbcfC0xSEX7 1FsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=vLk0xXrxBUVZwYOe2900cDsw6U4M18p3y0dM14bplRU=; b=qlSPr2Tevu2E1K2MO3ohLy6Fn88ZKnZ10gC5OAPbqrxA8E7J4bym2nvNNGAy5sId0m njeLdeFqeGn3STqrxbZSq0fg2A9RX5f8vJ7obfcsKJW8RRryGpgSeHUarrKVakFa3f/J e92YBUZXng75UCulGmMXn/3gTLfDf/XYyQ0klvwOHzi/zlSeWFmhqfOcEEY1NV6e3yos FusjaH9RJpvpyJuGukmJUoB5vshoQDnEcgo5VxPTekLtaO6o6CWxftFwykWSBXw5i1ea t/eW6Uyrv7g4FwAFGXsy0zqiINuuUFGzTH/ZdSWyO0Wlnk6/zGszdGppFHjEjzjAMhdj DpDg== X-Gm-Message-State: APzg51C50Y5W5yA71QKA2OD6UIsL3bd5qVnrUkxu1z38hoDckuVl4o8M MfBuFLaTEpWJ9GT89sG6E9PqO8H2 X-Google-Smtp-Source: ANB0Vda+FPPsQq73QZLSZ4K/BdBSa8CbZBB5EfJGTpaYgswinTRZpYiB1Py9EjF64OcW87n9lbwCSw== X-Received: by 2002:a6b:1706:: with SMTP id 6-v6mr14896473iox.58.1537015379836; Sat, 15 Sep 2018 05:42:59 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x68-v6sm1352560ita.2.2018.09.15.05.42.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Sep 2018 05:42:59 -0700 (PDT) In-Reply-To: <87worn86l5.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sat, 15 Sep 2018 18:15:18 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150331 Archived-At: Tino Calancha writes: > BTW, I've noticed following commit is missing in the release branch: > 'Make ibuffer filters idempotent' > (ee6fe8378a28444cb4913abca4af742f736e9b45) > > I suggest we backport it. > Then, I am OK with the next patch (which uses that commit): Shouldn't this patch be going into master anyway (since it's adding a new feature)? > + (cond ((null (cdr modes)) (ibuffer-filter-by-used-mode (car modes))) > + (t (let ((composed-filter We should handle the (null modes) case too, but otherwise looks good to me.