unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: pierre.techoueyres@free.fr (Pierre Téchoueyres)
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33040@debbugs.gnu.org
Subject: bug#33040: 26.1.50; Epg prompt on Microsoft Windows differ from the GNU/Linux on when asking passphrase
Date: Wed, 24 Oct 2018 21:21:07 +0200	[thread overview]
Message-ID: <878t2nm9r0.fsf@killashandra.ballybran.fr> (raw)
In-Reply-To: <831s8fry59.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Oct 2018 21:35:14 +0300")

[-- Attachment #1: Type: text/plain, Size: 41 bytes --]

Hello Eli,
please find the patch bellow.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: epg prompt patch --]
[-- Type: text/x-patch, Size: 920 bytes --]

From 32644ac1027114d3f4caaf2e25ae985241ab867b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= <pierre.techoueyres@free.fr>
Date: Sun, 14 Oct 2018 17:49:12 +0200
Subject: [PATCH] Unify prompt for gnupg passphrase between GNU/Linux and
 Windows.

* lisp/epg.el (epg--start): Use `raw-text' for coding system instead
  of binary in order to avoid spurious carriage return on Microsoft
  Windows and DOS when prompting for a password.
---
 lisp/epg.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/epg.el b/lisp/epg.el
index 8f26cd34ee..28afa59d8e 100644
--- a/lisp/epg.el
+++ b/lisp/epg.el
@@ -655,7 +655,7 @@ epg--start
 				  :command (cons (epg-context-program context)
 						 args)
 				  :connection-type 'pipe
-				  :coding '(binary . binary)
+				  :coding 'raw-text
 				  :filter #'epg--process-filter
 				  :stderr error-process
 				  :noquery t)))
-- 
2.17.2


[-- Attachment #3: Type: text/plain, Size: 659 bytes --]



Eli Zaretskii <eliz@gnu.org> writes:
>> Sorry, when :coding 'raw-text-unix didn't work as expected I first try
>> 
>> :coding (if (memq system-type '(ms-dos windows-nt))
>>              'raw-text-dos
>>          'raw-text-unix)
>> 
>> then I realized it was equivalent to :
>> :coding 'raw-text
>
> Actually, no: it isn't equivalent.  Just raw-text tells Emacs to use
> the default on encoding (thus -dos on Windows and -unix on GNU/Linux),
> and to _detect_ the EOL format on decoding.  But I don't think this is
> a problem in this case, is it?
>

No, it isn't a problem, and on the contrary it's exactly what I want :
detect the EOL format for decoding.

  reply	other threads:[~2018-10-24 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-14 15:53 bug#33040: 26.1.50; Epg prompt on Microsoft Windows differ from the GNU/Linux on when asking passphrase Pierre Téchoueyres
2018-10-20 10:17 ` Eli Zaretskii
2018-10-24 16:55   ` Pierre Téchoueyres
2018-10-24 17:40     ` Eli Zaretskii
2018-10-24 18:08       ` Pierre Téchoueyres
2018-10-24 18:35         ` Eli Zaretskii
2018-10-24 19:21           ` Pierre Téchoueyres [this message]
2018-10-27  9:38             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t2nm9r0.fsf@killashandra.ballybran.fr \
    --to=pierre.techoueyres@free.fr \
    --cc=33040@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).