* bug#33428: 27.0.50; edebug-print-{length,level} customization types
@ 2018-11-19 10:32 Stephen Berman
2018-11-19 18:37 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2018-11-19 10:32 UTC (permalink / raw)
To: 33428
The doc strings of edebug-print-length and edebug-print-level imply that
nil is a valid value and indeed it is. Yet trying to set the value to
nil via `M-x customize-option' fails with the error "This field should
contain an integer", because nil does not fit the customization type
:integer used in the definitions of these user options. It's been like
this since they were changed from defvars to defcustoms more than 20
years ago (though "If non-nil" was added to the doc strings only a
little less than 10 years ago), so should the fix (below) go into
master, or is it on the order of a documentation fix and suitable for
the release branch?
diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 15f68a62ac..b50b0383da 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -192,11 +192,11 @@ edebug-continue-kbd-macro
(defcustom edebug-print-length 50
"If non-nil, default value of `print-length' for printing results in Edebug."
- :type 'integer
+ :type '(choice integer (const nil))
:group 'edebug)
(defcustom edebug-print-level 50
"If non-nil, default value of `print-level' for printing results in Edebug."
- :type 'integer
+ :type '(choice integer (const nil))
:group 'edebug)
(defcustom edebug-print-circle t
"If non-nil, default value of `print-circle' for printing results in Edebug."
In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
of 2018-11-18 built on rosalinde
Repository revision: 5d140800398287c20230dda79162a7c40016d88e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
System Description: 8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#33428: 27.0.50; edebug-print-{length,level} customization types
2018-11-19 10:32 bug#33428: 27.0.50; edebug-print-{length,level} customization types Stephen Berman
@ 2018-11-19 18:37 ` Eli Zaretskii
2018-11-19 22:15 ` Stephen Berman
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-11-19 18:37 UTC (permalink / raw)
To: Stephen Berman; +Cc: 33428
> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Mon, 19 Nov 2018 11:32:51 +0100
>
> The doc strings of edebug-print-length and edebug-print-level imply that
> nil is a valid value and indeed it is. Yet trying to set the value to
> nil via `M-x customize-option' fails with the error "This field should
> contain an integer", because nil does not fit the customization type
> :integer used in the definitions of these user options. It's been like
> this since they were changed from defvars to defcustoms more than 20
> years ago (though "If non-nil" was added to the doc strings only a
> little less than 10 years ago), so should the fix (below) go into
> master, or is it on the order of a documentation fix and suitable for
> the release branch?
It's fine with me to put this on the release branch.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#33428: 27.0.50; edebug-print-{length,level} customization types
2018-11-19 18:37 ` Eli Zaretskii
@ 2018-11-19 22:15 ` Stephen Berman
2018-11-19 22:16 ` Stephen Berman
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2018-11-19 22:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 33428
On Mon, 19 Nov 2018 20:37:05 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Mon, 19 Nov 2018 11:32:51 +0100
>>
>> The doc strings of edebug-print-length and edebug-print-level imply that
>> nil is a valid value and indeed it is. Yet trying to set the value to
>> nil via `M-x customize-option' fails with the error "This field should
>> contain an integer", because nil does not fit the customization type
>> :integer used in the definitions of these user options. It's been like
>> this since they were changed from defvars to defcustoms more than 20
>> years ago (though "If non-nil" was added to the doc strings only a
>> little less than 10 years ago), so should the fix (below) go into
>> master, or is it on the order of a documentation fix and suitable for
>> the release branch?
>
> It's fine with me to put this on the release branch.
>
> Thanks.
Done in commit d667318a7f.
Steve Berman
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#33428: 27.0.50; edebug-print-{length,level} customization types
2018-11-19 22:15 ` Stephen Berman
@ 2018-11-19 22:16 ` Stephen Berman
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Berman @ 2018-11-19 22:16 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 33428-done
On Mon, 19 Nov 2018 23:15:21 +0100 Stephen Berman <stephen.berman@gmx.net> wrote:
> On Mon, 19 Nov 2018 20:37:05 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>
>>> From: Stephen Berman <stephen.berman@gmx.net>
>>> Date: Mon, 19 Nov 2018 11:32:51 +0100
>>>
>>> The doc strings of edebug-print-length and edebug-print-level imply that
>>> nil is a valid value and indeed it is. Yet trying to set the value to
>>> nil via `M-x customize-option' fails with the error "This field should
>>> contain an integer", because nil does not fit the customization type
>>> :integer used in the definitions of these user options. It's been like
>>> this since they were changed from defvars to defcustoms more than 20
>>> years ago (though "If non-nil" was added to the doc strings only a
>>> little less than 10 years ago), so should the fix (below) go into
>>> master, or is it on the order of a documentation fix and suitable for
>>> the release branch?
>>
>> It's fine with me to put this on the release branch.
>>
>> Thanks.
>
> Done in commit d667318a7f.
>
> Steve Berman
Oops, and closing the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-19 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-19 10:32 bug#33428: 27.0.50; edebug-print-{length,level} customization types Stephen Berman
2018-11-19 18:37 ` Eli Zaretskii
2018-11-19 22:15 ` Stephen Berman
2018-11-19 22:16 ` Stephen Berman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).