unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Tedin <federicotedin@gmail.com>
To: Xu Chunyang <mail@xuchunyang.me>
Cc: 34147@debbugs.gnu.org
Subject: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks
Date: Tue, 05 Feb 2019 20:08:11 -0300	[thread overview]
Message-ID: <878syt96lg.fsf@gmail.com> (raw)
In-Reply-To: <m2munvtl2l.fsf@xuchunyang.me>

> By evaluating describe-package-1 to get detailed Backtrace (I didn't
> paste it since it is very long), it seems the error is caused by the
> "last" expression of describe-package-1:
>
> (insert readme-string)
>
> when readme-string is nil.
>
> I notice Melpa fails to provide the readme file, this URL is 404
>
> https://melpa.org/packages/groovy-mode-readme.txt

It looks like when a package doesn't provide a 'Commentary' field, the
xyz-readme.txt file isn't generated by MELPA (see
https://github.com/melpa/package-build/blob/master/package-build.el#L382).

Other packages without 'Commentary' (in no particular order):
- instapaper
- javap-mode
- tdd-status-mode-line
- jknav
- runtests

Using C-h P on these packages will trigger the same error. I guess we
could replace:

(insert readme-string)

with:

(when readme-string
  (insert readme-string))

or:

(if readme-string
    (insert readme-string)
  (insert "This package does not provide a description."))

to cover cases where the xyz-readme.txt file for the package doesn't
exist.





  reply	other threads:[~2019-02-05 23:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-20 15:17 bug#34147: 27.0.50; M-x describe-package groovy-mode breaks Xu Chunyang
2019-02-05 23:08 ` Federico Tedin [this message]
2019-03-13  0:39   ` Federico Tedin
2019-03-22  4:10     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878syt96lg.fsf@gmail.com \
    --to=federicotedin@gmail.com \
    --cc=34147@debbugs.gnu.org \
    --cc=mail@xuchunyang.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).