From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34292: 26.1; ido-everywhere interferes with find-file Date: Wed, 03 Apr 2019 20:49:48 -0400 Message-ID: <878swqfvbn.fsf@gmail.com> References: <4E3F935E-5A44-4E3E-BC47-1BEA9D60223E@boostpro.com> <87tvfgez8n.fsf@gmail.com> <87r2akez2k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135886"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 34292@debbugs.gnu.org To: Dave Abrahams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 04 02:50:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBqaC-000Z8w-0P for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 02:50:20 +0200 Original-Received: from localhost ([127.0.0.1]:57579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBqaA-0006AN-TS for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 20:50:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBqa0-00068W-0T for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 20:50:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBqZy-0001hh-Jv for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 20:50:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBqZu-0001dA-47 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 20:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBqZt-0004Rn-U8 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 20:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 00:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34292 X-GNU-PR-Package: emacs Original-Received: via spool by 34292-submit@debbugs.gnu.org id=B34292.155433900017084 (code B ref 34292); Thu, 04 Apr 2019 00:50:01 +0000 Original-Received: (at 34292) by debbugs.gnu.org; 4 Apr 2019 00:50:00 +0000 Original-Received: from localhost ([127.0.0.1]:43467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBqZs-0004RU-0s for submit@debbugs.gnu.org; Wed, 03 Apr 2019 20:50:00 -0400 Original-Received: from mail-qt1-f178.google.com ([209.85.160.178]:39244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBqZo-0004RF-OB for 34292@debbugs.gnu.org; Wed, 03 Apr 2019 20:49:57 -0400 Original-Received: by mail-qt1-f178.google.com with SMTP id t28so1315039qte.6 for <34292@debbugs.gnu.org>; Wed, 03 Apr 2019 17:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N1hF8IteIfy8au9TQziHKokhLrvYagVVltCMDe2vQoc=; b=jxdIpmqTPLq20x105e50PiavzL2LMdFkqTiAoZmbGBFFtygIFcZtmR2ecJ6PPK2wKQ t52cXQ/l9t6gTCrCn3ldWvdrg/UaV8ABsBrKTtKc1ntr+2AJJHFP1VHZoGLezVEBbUlz Yw25aiuCt45NyaebJahCWsS8TtsWCcpEQtuMOU9UIlvK9DazL0SFXbmmBXREed5La4rE Nf1zS3XnyFdNcUyg3u8wQXGA9Mb1Vm/5TYroivc0s0kdlgFkctkiPyS1PH+pRybNhr4y /lnAQg1CvW/vvSKzYQtf/wtX93qCFTbd1GITBpz8mHXqFaSPTX6nifqvhoD+NzvuvMQr 4Klg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N1hF8IteIfy8au9TQziHKokhLrvYagVVltCMDe2vQoc=; b=kVJ9rYUf0+EokCUMVsGcdCOdvSiVswbHmJgL3xLAqqRYwhSRUbju5ljinQr9wWfo0z iQRut7700AO56KCJNHArRncN66KplaKUYMY7A2Wz3mpQUja3u3WviMGGu4WJvW0B59rD yNr8LruU2QDkfF+gtaZMdY6W5FGw9zh3Aibf3+9k1xkN3zoPvn7sooi7vQZ3jyoJaWbG E468Y6dJngrdZIvu8zPDaf4qsOHOpp+4bIxVL38r5tCNkFRLmfMNVfZ+ggrjWVd6xJ6X Jmi6rObAkqlADKlTkC6109vBTnN7lOL2Jyo+H6iZeQL0TnEDDT/d5LDs7i/wKqyBnydq PU4g== X-Gm-Message-State: APjAAAUDhVhELJz+94pEEVr5dL0jOamFbIMAFolhrsG0Ym1h4c1cGg/3 d5UxSNrD4+Yiv5kCDzSNhbKZiwNd X-Google-Smtp-Source: APXvYqwU0V8Xg4nm5xIhicJGIHAj2EnvU5BLZ/v44M0jlQt4ZOmasEjTlGJiFeePyzkD1ihikBeulQ== X-Received: by 2002:a0c:b656:: with SMTP id q22mr2351111qvf.205.1554338991082; Wed, 03 Apr 2019 17:49:51 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w68sm6378560qka.18.2019.04.03.17.49.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 17:49:49 -0700 (PDT) In-Reply-To: (Dave Abrahams's message of "Wed, 3 Apr 2019 16:37:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157152 Archived-At: --=-=-= Content-Type: text/plain Dave Abrahams writes: > shouldn't starting ido-everywhere turn on ido-mode automatically, then? Seems doable, does this work for you? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Let-ido-everywhere-turn-on-ido-mode-Bug-34292.patch Content-Description: patch >From a21e8afe70b0f8fef692d235dc85995c01ca4e7a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 3 Apr 2019 20:13:05 -0400 Subject: [PATCH] Let ido-everywhere turn on ido-mode (Bug#34292) * lisp/ido.el (ido-everywhere): Turn on ido-mode, if it's not already on. Otherwise, having ido-everywhere enabled messes all file and buffer reading interactive commands. --- lisp/ido.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/ido.el b/lisp/ido.el index 0854014581..a89f7b0eaa 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -1586,8 +1586,10 @@ (define-minor-mode ido-everywhere (remove-function read-file-name-function #'ido-read-file-name) (remove-function read-buffer-function #'ido-read-buffer) (when ido-everywhere - (add-function :override read-file-name-function #'ido-read-file-name) - (add-function :override read-buffer-function #'ido-read-buffer))) + (if (not ido-mode) + (ido-mode 'both) + (add-function :override read-file-name-function #'ido-read-file-name) + (add-function :override read-buffer-function #'ido-read-buffer)))) (defvar ido-minor-mode-map-entry nil) -- 2.11.0 --=-=-= Content-Type: text/plain (it seems to be working for me now, though I had a transient failure the first time where it refused to open bar, even though ido seemed to be functioning correctly. Maybe a caching thing?) --=-=-=--