From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Mon, 08 Apr 2019 22:36:38 +0300 Organization: LINKOV.NET Message-ID: <878swkxqo1.fsf_-_@mail.linkov.net> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="266594"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , 32676@debbugs.gnu.org To: Ernesto Alfonso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 08 22:29:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDatN-0017C9-2T for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 22:29:21 +0200 Original-Received: from localhost ([127.0.0.1]:58535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDatL-0006J7-So for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 16:29:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDat7-0006HM-VC for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 16:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDat6-0007Tw-0C for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 16:29:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36673) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDat5-0007T9-F2 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 16:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDat5-00058a-As for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 16:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2019 20:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.155475530819642 (code B ref 32676); Mon, 08 Apr 2019 20:29:03 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 8 Apr 2019 20:28:28 +0000 Original-Received: from localhost ([127.0.0.1]:50204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDasW-00056i-GW for submit@debbugs.gnu.org; Mon, 08 Apr 2019 16:28:28 -0400 Original-Received: from purple.birch.relay.mailchannels.net ([23.83.209.150]:25217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDasS-00056Y-Lz for 32676@debbugs.gnu.org; Mon, 08 Apr 2019 16:28:25 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C293B123204; Mon, 8 Apr 2019 20:28:21 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a91.g.dreamhost.com (unknown [100.96.20.50]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2AA3E123D45; Mon, 8 Apr 2019 20:28:21 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a91.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 08 Apr 2019 20:28:21 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Desert-Plucky: 5e8bd9b749d02866_1554755301419_3266421009 X-MC-Loop-Signature: 1554755301419:2518154240 X-MC-Ingress-Time: 1554755301419 Original-Received: from pdx1-sub0-mail-a91.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTP id 9F06C7FA61; Mon, 8 Apr 2019 13:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=WwqjVCTd9POgzmV+FL6ZX7HNm3k=; b= GUV6d43X5mxtJtsyoAPBnUol2T26pEnu3hzHvFFgMFdXXm/7GyZr8Q0tYHJI43Up bQD4dZfnL0dK7ZCys+8mAZQNASHzRcJd4WMafon8mQ0jqOGF/pkb4J3p6KlAEbud Yc/RHG5BUj0HwNc/oROcqx2Q6LplypWuUlGupOqBbAc= Original-Received: from mail.jurta.org (m91-129-99-202.cust.tele2.ee [91.129.99.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTPSA id 113497FA60; Mon, 8 Apr 2019 13:28:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a91 In-Reply-To: (Ernesto Alfonso's message of "Sun, 7 Apr 2019 14:56:53 -0700") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudefgdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrvddtvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdelledrvddtvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvrhhjohgrlhhgohesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157358 Archived-At: > I'd like to know if this patch is still being considered? Why not? Your patch provides a helpful feature. I see only 2 problems with its latest version: 1. compilation-current-error should be generalized not to be too compilation-specific; 2. next-error-hook should not be used for core features, you could call next-error-message-highlight directly from next-error-found. PS: maybe a better name for defcustom would be next-error-message-highlight, not next-error-message-highlight-p, to be more future-proof, for the case when someone might want to add more choices later (e.g. fringe, timers, etc.)