From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35675: 27.0.50; Is line-number-at-pos unnecessarily slow? Date: Sat, 11 May 2019 21:36:59 +0100 Message-ID: <878svcwwwk.fsf@tcd.ie> References: <87zhnuuj0y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50331"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35675@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 11 22:38:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPYl9-000CyN-3N for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 May 2019 22:38:19 +0200 Original-Received: from localhost ([127.0.0.1]:35075 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPYl8-000474-3a for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 May 2019 16:38:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPYku-00043K-A9 for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 16:38:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPYkt-0002hp-GL for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 16:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPYks-0002gJ-LN for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 16:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPYkr-0004y1-Kw for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 16:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 May 2019 20:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35675 X-GNU-PR-Package: emacs Original-Received: via spool by 35675-submit@debbugs.gnu.org id=B35675.155760703219034 (code B ref 35675); Sat, 11 May 2019 20:38:01 +0000 Original-Received: (at 35675) by debbugs.gnu.org; 11 May 2019 20:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:41254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPYk4-0004ww-15 for submit@debbugs.gnu.org; Sat, 11 May 2019 16:37:12 -0400 Original-Received: from mail-ed1-f66.google.com ([209.85.208.66]:37653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPYjz-0004wh-Le for 35675@debbugs.gnu.org; Sat, 11 May 2019 16:37:10 -0400 Original-Received: by mail-ed1-f66.google.com with SMTP id w37so10746041edw.4 for <35675@debbugs.gnu.org>; Sat, 11 May 2019 13:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AvMHuT739u5GH/t+Q7Ta7kRnMP+oRXRa/7cRhIKlXrg=; b=PqK/0L6769P9PBVOMaln5sfc8d2yHluy54dbW5EvzWNWky9gEmN+WbwAg25MNGFKUC mwjI5q1hUgPVS8c/50/LZ5GiRRnv7dVG5lZrdhfYln+SYZACqiywLOK84heKECW/ODZN sHgbQTq2u0z0RUJINCZ0TKAonc7tyAmsrUo9letI70y0Gs6iNUL3GpwhTKIVQ5lmsl/l JxwnBEwJJI6a660c/3cSa47eMI0fvPRsQep3QZXzBPkxQjSEjE83z59folfMulnrWe9y /BPBBtnyyythBysXcQtl0EF9fJzSxY5CZLp/jAGXfsaqr18aKpKhjd0M80qvX/YR1ayM 1pGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AvMHuT739u5GH/t+Q7Ta7kRnMP+oRXRa/7cRhIKlXrg=; b=BYWi4YUtLO9RcDFs8koSX4cmP8SLdb4wn5GqB94w3vctfYH2JEyGu3mrRwGyWcQg+I pftMuVReiD2lXY0gMl9LzoTPKFLotEoKby9YKkfBCNMnBRhFreEZQoHHPlgnoGfCO8a+ m+PPznd1gRWE+b2g3TiwrfHozz5HNHNqTIXodO3lZshI8/utlhc7UazgcJQDPviuGdu8 LSP8go9LYNplW1Bd/eu6cnJ1GFvMg+GvTlf39WxMDDJx+uThhZkb+LpdRFO4IQcwkTP9 dmZ3cCmMl+v5jZmgg4t1ZJH9v6V9GELeZfRoPJTZI0ic1jAUblbeQVBXBwo4m77KcEmJ EFhw== X-Gm-Message-State: APjAAAUMfE1Pr8A/NIymnSdqmD6eF1WWuGHEex5sPWCLhI8Fs4c4guBJ wUWtGHvO8ReM9mBl4bs8+wrNEEJ2i+IGhw== X-Google-Smtp-Source: APXvYqydGS5H4aZZ5UMBZnWMY3HEbYfB80PDDMukGznldEtZh7gZbBgLA7hKU/lKRDyB6KsDT/skOA== X-Received: by 2002:a17:906:7b58:: with SMTP id n24mr14927231ejo.224.1557607021797; Sat, 11 May 2019 13:37:01 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id p60sm2507175edp.0.2019.05.11.13.37.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 11 May 2019 13:37:00 -0700 (PDT) In-Reply-To: <87zhnuuj0y.fsf@gmail.com> (Alex Branham's message of "Fri, 10 May 2019 15:55:09 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159097 Archived-At: Alex Branham writes: > line-number-at-pos basically regex searches forward for \n's and > counts them up. It only does this (via count-lines) if selective-display is t, which is deprecated and seldom used. Otherwise it uses the value returned by forward-line (defined in C), which calls find_newline, which AFAIK uses the buffer's newline cache to some extent (I'm not familiar with its implementation). Either way, as Eli says, there's often an algorithmic solution to slowness in uses of count-lines. Thanks, -- Basil