From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18859: 24.3; ibuffer-mark-by-file-name-regexp does not match displayed name Date: Sat, 03 Aug 2019 18:54:07 +0200 Message-ID: <878ssagpg0.fsf@mouse.gnus.org> References: <87bnox9pn8.fsf@sc3d.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267615"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 18859@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 03 18:55:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htxJI-0017UW-Mg for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Aug 2019 18:55:12 +0200 Original-Received: from localhost ([::1]:41038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htxJH-0008Fp-Mv for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Aug 2019 12:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45014) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htxJ9-0008F9-W6 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 12:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htxJ8-0002Pb-I7 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 12:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htxJ8-0002Oe-00 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htxJ7-0003e0-Q1 for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2019 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18859 X-GNU-PR-Package: emacs Original-Received: via spool by 18859-submit@debbugs.gnu.org id=B18859.156485125513934 (code B ref 18859); Sat, 03 Aug 2019 16:55:01 +0000 Original-Received: (at 18859) by debbugs.gnu.org; 3 Aug 2019 16:54:15 +0000 Original-Received: from localhost ([127.0.0.1]:59812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htxIN-0003cf-BN for submit@debbugs.gnu.org; Sat, 03 Aug 2019 12:54:15 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htxIL-0003cT-96 for 18859@debbugs.gnu.org; Sat, 03 Aug 2019 12:54:13 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htxIG-0006DM-Iu; Sat, 03 Aug 2019 18:54:11 +0200 In-Reply-To: <87bnox9pn8.fsf@sc3d.org> (Reuben Thomas's message of "Mon, 27 Oct 2014 21:19:39 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164470 Archived-At: Reuben Thomas writes: > In the *IBuffer*, files in my home directory are displayed with names > starting with =E2=80=98~=E2=80=99, but when I type % f ~ RET I get no mat= ches. If I type > instead % f /home/MYUSER RET then all files in my home directory are > matched. > > I=E2=80=99m not convinced that the matches should be made in the second c= ase, > even; but certainly they _should_ be made in the first. The following patch fixes this by matching on the abbreviated file name (which is what ibuffer uses to create the displayed file name). But I guess this could be a controversial change -- does anybody have an objection to making this change?=20=20 diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index 1b69574a39..06a2248d40 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -1846,7 +1846,8 @@ ibuffer-mark-by-file-name-regexp (stringp dired-directory) dired-directory))))) (when name - (string-match regexp name)))))) + ;; Match on the displayed file name (which is abbreviated). + (string-match regexp (abbreviate-file-name name))))))) =20 ;;;###autoload (defun ibuffer-mark-by-content-regexp (regexp &optional all-buffers) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no