unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Branham <alex.branham@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 22700@debbugs.gnu.org
Subject: bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line
Date: Thu, 15 Aug 2019 09:27:02 -0500	[thread overview]
Message-ID: <878sruy05l.fsf@gmail.com> (raw)
In-Reply-To: <jwvh86j4b2s.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 14 Aug 2019 18:50:12 -0400")

On Wed 14 Aug 2019 at 18:50, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> This is because cursor-sensor--detect doesn't call
>> cursor-sensor-functions if the text property hasn't changed[1]. Since ERC
>> applies the property to _all_ of the message, the text property remains
>> `eq' and so it doesn't get called when it should.
>
> How 'bout the patch below which makes the function different on
> each message?

Works well unless you C-n/p and point remains inside the same IRC
message. Probably a happy medium between what I suggested and the
problems Noam pointed out though. Should we go ahead and apply this to
master? It's clearly an improvement over what's there now, which doesn't
really work at all.

Thanks,
Alex





  reply	other threads:[~2019-08-15 14:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 16:07 bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line William G. Gardella
2018-04-14 18:49 ` Lars Ingebrigtsen
2018-04-15  0:06   ` Stefan Monnier
2018-04-15 13:01     ` Lars Ingebrigtsen
2019-08-13 20:40       ` Alex Branham
2019-08-13 22:11         ` Lars Ingebrigtsen
2019-08-13 22:13           ` Noam Postavsky
2019-08-14  0:33             ` Alex Branham
2019-08-14  2:40               ` Eli Zaretskii
2019-08-14 13:49                 ` Alex Branham
2019-08-14 14:39                   ` Eli Zaretskii
2019-08-14 14:56                   ` Noam Postavsky
2019-08-14 15:16                     ` Alex Branham
2019-08-14 22:50         ` Stefan Monnier
2019-08-15 14:27           ` Alex Branham [this message]
2019-08-15 23:41             ` Lars Ingebrigtsen
2019-08-16 13:25               ` Alex Branham
2019-08-19  9:46             ` Stefan Monnier
2019-08-27 15:08               ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sruy05l.fsf@gmail.com \
    --to=alex.branham@gmail.com \
    --cc=22700@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).