From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24779: 26.0.50; Incorrect Edebug spec for define-skeleton Date: Fri, 23 Aug 2019 02:22:07 +0200 Message-ID: <878srkbuj4.fsf@mouse.gnus.org> References: <87v9vnhb4l.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="259000"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24779@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 02:23:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xMF-0015H4-O3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 02:23:11 +0200 Original-Received: from localhost ([::1]:50558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xME-0003mG-2X for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Aug 2019 20:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42667) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xM7-0003lm-8P for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0xM6-0001Kh-2J for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0xM5-0001Kb-VW for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0xM5-0001kP-QZ for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24779-submit@debbugs.gnu.org id=B24779.15665197356639 (code B ref 24779); Fri, 23 Aug 2019 00:23:01 +0000 Original-Received: (at 24779) by debbugs.gnu.org; 23 Aug 2019 00:22:15 +0000 Original-Received: from localhost ([127.0.0.1]:38575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLK-0001iz-IF for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:14 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xLI-0001ir-Uh for 24779@debbugs.gnu.org; Thu, 22 Aug 2019 20:22:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xLD-0001sm-U6; Fri, 23 Aug 2019 02:22:11 +0200 In-Reply-To: <87v9vnhb4l.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 15:15:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165613 Archived-At: Lars Ingebrigtsen writes: > I'm able to reproduce that, too, and adding "|" to the list of strings > in the spec seems to fix this. I know nothing about any of this, > though, so... Is this the right thing to do? > > diff --git a/lisp/skeleton.el b/lisp/skeleton.el > index bce73d6bfe..67fc4aae15 100644 > --- a/lisp/skeleton.el > +++ b/lisp/skeleton.el > @@ -105,8 +105,8 @@ skeleton-point > (defvar skeleton-regions) > > (def-edebug-spec skeleton-edebug-spec > - ([&or null stringp (stringp &rest stringp) [[¬ atom] def-form]] > - &rest &or "n" "_" "-" ">" "@" "&" "!" "resume:" > + ([&or null stringp (stringp &rest stringp) [[¬ atom] sexp]] > + &rest &or "n" "_" "-" ">" "@" "&" "!" "|" "resume:" > ("quote" def-form) skeleton-edebug-spec def-form)) > ;;;###autoload > (defmacro define-skeleton (command documentation &rest skeleton) There weren't any comments, and this does seem to fix the test cases, so I've applied this now. But like I said, I don't really know this area, so if this is the wrong thing to do, feel free to revert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no