From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30449: imenu contains redundant '*Rescan*' item with auto refresh Date: Fri, 20 Sep 2019 15:02:18 +0200 Message-ID: <878sqjazol.fsf@gnus.org> References: <33378FAE-C23F-4B17-A468-65406AF6D393@mnewton.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18849"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30449@debbugs.gnu.org To: Matthew Newton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 15:04:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBIa9-0004kF-J1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 15:04:17 +0200 Original-Received: from localhost ([::1]:59306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBIa7-0002SH-9K for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 09:04:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50850) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBIYz-0001rF-Aj for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 09:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBIYx-0000nD-4T for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 09:03:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBIYw-0000mq-C3 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 09:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBIYw-0006Ig-59 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30449 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo fixed patch Original-Received: via spool by 30449-submit@debbugs.gnu.org id=B30449.156898454523413 (code B ref 30449); Fri, 20 Sep 2019 13:03:02 +0000 Original-Received: (at 30449) by debbugs.gnu.org; 20 Sep 2019 13:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:56948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIYL-00065K-7y for submit@debbugs.gnu.org; Fri, 20 Sep 2019 09:02:25 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIYI-00062h-IG for 30449@debbugs.gnu.org; Fri, 20 Sep 2019 09:02:23 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBIYE-0000ng-I6; Fri, 20 Sep 2019 15:02:20 +0200 In-Reply-To: <33378FAE-C23F-4B17-A468-65406AF6D393@mnewton.com> (Matthew Newton's message of "Thu, 19 Sep 2019 14:36:47 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166763 Archived-At: Matthew Newton writes: > I don=E2=80=99t know the codebase at all and I just spent a couple minute= s looking at it. But shouldn=E2=80=99t imenu--make-index-alist always retur= n a list? So the last lines would be: > > (if imenu-auto-rescan > imenu--index-alist > ;; Add a rescan option to the index. > (cons imenu--rescan-item imenu--index-alist)) Yes, that looks like the correct fix. I've now applied it to the Emacs trunk. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no