unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#31658: 25.2; Number of changes undone should be controlled by a variable
@ 2018-05-30 17:59 Ruy Exel
  2019-10-09 21:58 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Ruy Exel @ 2018-05-30 17:59 UTC (permalink / raw)
  To: 31658

After I updated Emacs to the latest version I noticed that the behavior
of the undo command has changed in the sense that a single invocation of
undo effectively undoes many more recent changes than it used to and I
often find myself having to re-do the changes and reentering the whole
information again rather than taking advantage of the undo command.

After a little fiddling I realized that this feature is controlled by
the function 'undo-auto-amalgamate' which contains the line

  (< last-amalgamating-count 20)

apparently bundling up to 20 recent changes for the next invocation of
undo.

My solution was simply to edit that function, replacing 20 by zero, and
the old behavior, which I am used to, was restored.

The purpose of this bug-report/feature-request is to suggest that
instead of hard coding a fixed number, such as 20, the number of changes
bundled together should be determined by a variable which the user could
customize if desired.

In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
 of 2017-12-09 built on tictoc
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:    Ubuntu 14.04.5 LTS





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#31658: 25.2; Number of changes undone should be controlled by a variable
  2018-05-30 17:59 bug#31658: 25.2; Number of changes undone should be controlled by a variable Ruy Exel
@ 2019-10-09 21:58 ` Lars Ingebrigtsen
  2019-10-10  7:32   ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-09 21:58 UTC (permalink / raw)
  To: Ruy Exel; +Cc: 31658

Ruy Exel <ruyexel@gmail.com> writes:

> After I updated Emacs to the latest version I noticed that the behavior
> of the undo command has changed in the sense that a single invocation of
> undo effectively undoes many more recent changes than it used to and I
> often find myself having to re-do the changes and reentering the whole
> information again rather than taking advantage of the undo command.
>
> After a little fiddling I realized that this feature is controlled by
> the function 'undo-auto-amalgamate' which contains the line
>
>   (< last-amalgamating-count 20)
>
> apparently bundling up to 20 recent changes for the next invocation of
> undo.
>
> My solution was simply to edit that function, replacing 20 by zero, and
> the old behavior, which I am used to, was restored.
>
> The purpose of this bug-report/feature-request is to suggest that
> instead of hard coding a fixed number, such as 20, the number of changes
> bundled together should be determined by a variable which the user could
> customize if desired.

I think that sounds like a reasonable (and useful) request.  Does
anybody object to adding such a defcustom?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#31658: 25.2; Number of changes undone should be controlled by a variable
  2019-10-09 21:58 ` Lars Ingebrigtsen
@ 2019-10-10  7:32   ` Eli Zaretskii
  2019-10-11  7:24     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2019-10-10  7:32 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: ruyexel, 31658

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 09 Oct 2019 23:58:55 +0200
> Cc: 31658@debbugs.gnu.org
> 
> > The purpose of this bug-report/feature-request is to suggest that
> > instead of hard coding a fixed number, such as 20, the number of changes
> > bundled together should be determined by a variable which the user could
> > customize if desired.
> 
> I think that sounds like a reasonable (and useful) request.  Does
> anybody object to adding such a defcustom?

Let's begin with defvar, please.  I'm not sure I like exposing the
bowels of undo to users, there be dragons.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#31658: 25.2; Number of changes undone should be controlled by a variable
  2019-10-10  7:32   ` Eli Zaretskii
@ 2019-10-11  7:24     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-11  7:24 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: ruyexel, 31658

Eli Zaretskii <eliz@gnu.org> writes:

>> I think that sounds like a reasonable (and useful) request.  Does
>> anybody object to adding such a defcustom?
>
> Let's begin with defvar, please.  I'm not sure I like exposing the
> bowels of undo to users, there be dragons.

OK; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-11  7:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 17:59 bug#31658: 25.2; Number of changes undone should be controlled by a variable Ruy Exel
2019-10-09 21:58 ` Lars Ingebrigtsen
2019-10-10  7:32   ` Eli Zaretskii
2019-10-11  7:24     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).