From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#12436: 24.2.50; rename `(next|previous)-multiframe-window' Date: Wed, 30 Oct 2019 23:30:53 +0100 Message-ID: <878sp1x3vm.fsf@joffe.skangas.se> References: <41448D3E81B245CAA20C88FD41B31D26@us.oracle.com> <87fuu57img.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="43708"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 12436@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 23:32:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPwW8-000BFd-8L for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 23:32:40 +0100 Original-Received: from localhost ([::1]:44965 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPwW7-0004Ss-3N for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 18:32:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41857) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPwVZ-000440-FX for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 18:32:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPwVW-0003qN-Vc for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 18:32:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPwVW-0003oX-94 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 18:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPwVW-0003Il-44 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 18:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12436 X-GNU-PR-Package: emacs Original-Received: via spool by 12436-submit@debbugs.gnu.org id=B12436.157247469312647 (code B ref 12436); Wed, 30 Oct 2019 22:32:02 +0000 Original-Received: (at 12436) by debbugs.gnu.org; 30 Oct 2019 22:31:33 +0000 Original-Received: from localhost ([127.0.0.1]:51782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPwV3-0003Hv-ED for submit@debbugs.gnu.org; Wed, 30 Oct 2019 18:31:33 -0400 Original-Received: from giraff.fripost.org ([193.234.15.44]:42388 helo=outgoing.fripost.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPwV1-0003Hf-Df for 12436@debbugs.gnu.org; Wed, 30 Oct 2019 18:31:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by outgoing.fripost.org (Postfix) with ESMTP id 9DB4D187EAF2; Wed, 30 Oct 2019 23:31:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=x.fripost.org; h= content-type:content-type:mime-version:user-agent:message-id :in-reply-to:date:date:references:subject:subject:from:from; s= 9df9cdc7e101629b5003b587945afa70; t=1572474685; x=1574289086; bh=X1dWvCGbyVsEaYVHfGZNuOzVJ/2oMQbB3K4V1CjnVDw=; b=Yhmzjdxe+Ucl mbhYk78SdL/3pprixNkXrRsWY0SPCzOIG1Y0pK7R6DuJ220IqYfqT/EdcKn8HmhV ik4ntxff5v0ji/ARCPdAD5q6ZNW3jepCBOWe19dFvgd7q5XAzFY6QhpmPDJVqcsK zGoLVdUjaUx213kZjgqdzOaM8Q/Spt+LCP9/yV2Vsqhq57RR8BiNDK4bMadO39cQ 36jRUpB8QdGDLiG05XvUqcwQiYSwj/qquQhO5KzIwg6DnDwXITazLS+TT8cNpO/q Ok6SYcjfwlMZsiRKH1iCzjNa/1FPQnS/FYSur7Lu1gpZCHepRvnV5I2GouY9yiL8 HyEvn3+sdA== X-Virus-Scanned: Debian amavisd-new at fripost.org Original-Received: from outgoing.fripost.org ([127.0.0.1]) by localhost (giraff.fripost.org [127.0.0.1]) (amavisd-new, port 10040) with LMTP id 3KbFfk9-CLVy; Wed, 30 Oct 2019 23:31:25 +0100 (CET) Original-Received: from smtp.fripost.org (unknown [172.16.0.6]) by outgoing.fripost.org (Postfix) with ESMTP id 774DC187EAE6; Wed, 30 Oct 2019 23:31:25 +0100 (CET) Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by smtp.fripost.org (Postfix) with ESMTPSA id 33A06599F72B; Wed, 30 Oct 2019 23:31:05 +0100 (CET) Original-Received: from skangas by joffe.skangas.se with local (Exim 4.92) (envelope-from ) id 1iPwUP-0006P5-Op; Wed, 30 Oct 2019 23:30:53 +0100 In-Reply-To: <87fuu57img.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2016 19:23:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170473 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > "Drew Adams" writes: > >> Rename these commands and deprecate the old names. There is no such >> thing as a multiframe window, which would mean a window on more than one >> frame. These commands should be called something like: >> `(next|previous)-window-any-frame'. > > I agree. Any objections? There does not seem to be many users of these > functions: > > ./frame.el:522:(defun next-multiframe-window () > ./frame.el:530:(defun previous-multiframe-window () > ./term/ns-win.el:105:(define-key global-map [?\s-'] 'next-multiframe-window) Makes sense to me. Any objections to the below patch? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Rename-multiframe-window-to-window-any-frame.patch >From 1ee698b0b0722c18ee211d79821370af2f60af56 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Wed, 30 Oct 2019 23:27:37 +0100 Subject: [PATCH] Rename `*-multiframe-window' to '*-window-any-frame' Suggested by Drew Adams. * lisp/frame.el (next-multiframe-window): Define as obsolete alias for... (next-window-any-frame): ...new function name. (previous-multiframe-window): Define as obsolete alias for... (previous-window-any-frame): ...new function name. (Bug#12436) * lisp/term/ns-win.el (global-map): Use new command name. * doc/emacs/windows.texi (Other Window): Document it. * etc/NEWS: Announce it. --- doc/emacs/windows.texi | 4 ++-- etc/NEWS | 5 +++++ lisp/frame.el | 8 ++++++-- lisp/term/ns-win.el | 2 +- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/doc/emacs/windows.texi b/doc/emacs/windows.texi index 19f6cff7bf..53e9a4bb58 100644 --- a/doc/emacs/windows.texi +++ b/doc/emacs/windows.texi @@ -181,12 +181,12 @@ Other Window back and finish supplying the minibuffer argument that is requested. @xref{Minibuffer Edit}. -@findex next-multiframe-window +@findex next-window-any-frame The @code{other-window} command will normally only switch to the next window in the current frame (unless otherwise configured). If you work in a multi-frame environment and you want windows in all frames to be part of the cycle, you can rebind @kbd{C-x o} to the -@code{next-multiframe-window} command. (@xref{Rebinding}, for how to +@code{next-window-any-frame} command. (@xref{Rebinding}, for how to rebind a command.) @kindex C-M-v diff --git a/etc/NEWS b/etc/NEWS index cd1e46bb87..bb288a4aac 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -202,6 +202,11 @@ the new version of the file again.) * Changes in Emacs 27.1 ++++ +** 'next-multiframe-window' and 'previous-multiframe-window' are obsolete. +Use new names 'next-window-any-frame' and 'previous-window-any-frame' +instead. + ** emacsclient +++ diff --git a/lisp/frame.el b/lisp/frame.el index 92fe57fbe6..7aa1b75f1f 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -673,21 +673,25 @@ get-other-frame is not considered (see `next-frame')." (if (equal (next-frame) (selected-frame)) (make-frame) (next-frame))) -(defun next-multiframe-window () +(defun next-window-any-frame () "Select the next window, regardless of which frame it is on." (interactive) (select-window (next-window (selected-window) (> (minibuffer-depth) 0) 0)) (select-frame-set-input-focus (selected-frame))) +(define-obsolete-function-alias 'next-multiframe-window + 'next-window-any-frame "27.1") -(defun previous-multiframe-window () +(defun previous-window-any-frame () "Select the previous window, regardless of which frame it is on." (interactive) (select-window (previous-window (selected-window) (> (minibuffer-depth) 0) 0)) (select-frame-set-input-focus (selected-frame))) +(define-obsolete-function-alias 'previous-multiframe-window + 'previous-window-any-frame "27.1") (defun window-system-for-display (display) "Return the window system for DISPLAY. diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el index 83b845b1a5..1841e679ac 100644 --- a/lisp/term/ns-win.el +++ b/lisp/term/ns-win.el @@ -102,7 +102,7 @@ 'ns-alternatives-map ;; Here are some Nextstep-like bindings for command key sequences. (define-key global-map [?\s-,] 'customize) -(define-key global-map [?\s-'] 'next-multiframe-window) +(define-key global-map [?\s-'] 'next-window-any-frame) (define-key global-map [?\s-`] 'other-frame) (define-key global-map [?\s-~] 'ns-prev-frame) (define-key global-map [?\s--] 'center-line) -- 2.20.1 --=-=-= Content-Type: text/plain Best regards, Stefan Kangas --=-=-=--