From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17272: bug#19064: bug#17272: bug#19064: 25.0.50; `message' overwrites `y-or-n-p' prompt, so user misses it Date: Wed, 20 Nov 2019 00:28:15 +0200 Organization: LINKOV.NET Message-ID: <878sobqxb4.fsf@mail.linkov.net> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87wps1m7co.fsf@web.de> <87y4chjdop.fsf@gnus.org> <87o8ys3131.fsf@gnus.org> <875zjx6hs6.fsf@mail.linkov.net> <87sgmy3x22.fsf@gnus.org> <871rugbqmy.fsf@mail.linkov.net> <87d0dxyh7z.fsf@gnus.org> <53c55db5-d623-4946-af2e-d141e7bc7acd@default> <87sgmrpir5.fsf@web.de> <87mucya2a7.fsf@web.de> <87mucy4cb2.fsf@web.de> <621b98dc-0fe9-4eef-9e11-7580fb446e97@default> <87k1822ocn.fsf@web.de> <87lfsfmtk0.fsf@mail.linkov.net> <874kz3gibu.fsf@gnus.org> <87bltaw3xz.fsf@mail.linkov.net> <87r224x54p.fsf@mail.linkov.net> <87v9rgnv0o.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100386"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , 17272@debbugs.gnu.org, 19064@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 00:21:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXCoO-000PxH-2E for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 00:21:32 +0100 Original-Received: from localhost ([::1]:52306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXCoM-0005iI-Qo for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Nov 2019 18:21:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43754) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXCo1-0005gl-WC for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:21:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXCnv-0000fp-7f for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:21:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXCnv-0000fl-2U for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXCnu-0004Sg-7Q for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2019 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17272-submit@debbugs.gnu.org id=B17272.157420562817015 (code B ref 17272); Tue, 19 Nov 2019 23:21:02 +0000 Original-Received: (at 17272) by debbugs.gnu.org; 19 Nov 2019 23:20:28 +0000 Original-Received: from localhost ([127.0.0.1]:48698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCnL-0004QM-PF for submit@debbugs.gnu.org; Tue, 19 Nov 2019 18:20:28 -0500 Original-Received: from bumble.birch.relay.mailchannels.net ([23.83.209.25]:21681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCnI-0004Q6-Bo; Tue, 19 Nov 2019 18:20:26 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5BCAA8C159A; Tue, 19 Nov 2019 23:20:23 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-83-20.trex.outbound.svc.cluster.local [100.96.83.20]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C757B8C1737; Tue, 19 Nov 2019 23:20:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 19 Nov 2019 23:20:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Irritate-Scare: 5a1d582856c978d7_1574205623160_3245983446 X-MC-Loop-Signature: 1574205623160:193071215 X-MC-Ingress-Time: 1574205623160 Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id 93AE47FC55; Tue, 19 Nov 2019 15:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=L+pTGz lPWzlV+h06fUWN454uTjk=; b=B70/UJj6LlpLwYWEXtCDQZ6dhXCTj7K6NAMLMY bOMFGc17fMan8axJAMFY4PufVIimPQSifa7LYAuKVZN7XWDN5UBN9e7cBd6SN0mL ijwlz8J4zu3ua0VMj+QOgjKAO4ooRiaDpRCcDMIRD4cQuLhpe0VDICLYnzaAhhH8 qdx8E= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id 107E27FC58; Tue, 19 Nov 2019 15:20:16 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 In-Reply-To: <87v9rgnv0o.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Nov 2019 09:13:43 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172023 Archived-At: >> The variable name is =E2=80=98message-in-echo-area=E2=80=99. After a = little testing, >> it seems to handle all such cases well: > > I have not tested the patch, but it looks good to me. Actually this patch needs more testing. I found already two cases that might be annoying. Better to anticipate a possible angry reaction and fix these cases in advance. The first case is when doing completion, the message "Making completion list..." is displayed in the minibuffer for 2 seconds. I don't understand why this message is needed at all, but at least this patch restores its previous behavior that displays that message in the echo area and doesn't wait. diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6e72eb73f9..b3fc3b8ab0 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1838,7 +1838,7 @@ completion--done (defun minibuffer-completion-help (&optional start end) "Display a list of possible completions of the current minibuffer cont= ents." (interactive) - (message "Making completion list...") + (message-in-echo-area "Making completion list...") (let* ((start (or start (minibuffer-prompt-end))) (end (or end (point-max))) (string (buffer-substring start end)) @@ -1849,7 +1849,7 @@ minibuffer-completion-help minibuffer-completion-predicate (- (point) start) md))) - (message nil) + (message-in-echo-area nil) (if (or (null completions) (and (not (consp (cdr completions))) (equal (car completions) string))) Another case when using isearch in minibuffer, the failed search message is displayed at the end of the minibuffer instead of in the search prompt in the echo area. This patch restores the previous behavior: diff --git a/lisp/isearch.el b/lisp/isearch.el index 4f3342782d..1705b050b5 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2011,7 +2011,7 @@ isearch-message-properties (defun isearch--momentary-message (string) "Print STRING at the end of the isearch prompt for 1 second." (let ((message-log-max nil)) - (message "%s%s%s" + (message-in-echo-area "%s%s%s" (isearch-message-prefix nil isearch-nonincremental) isearch-message (apply #'propertize (format " [%s]" string) @@ -3168,7 +3170,7 @@ isearch-message (isearch-message-prefix ellipsis isearch-nonincremental) m (isearch-message-suffix c-q-hack))) - (if c-q-hack m (let ((message-log-max nil)) (message "%s" m))))) + (if c-q-hack m (let ((message-log-max nil)) (message-in-echo-area "%= s" m))))) =20 (defun isearch--describe-regexp-mode (regexp-function &optional space-be= fore) "Make a string for describing REGEXP-FUNCTION.